On Thu, Feb 15, 2018 at 06:23:06PM +0530, Gyan Doshi wrote:
>
> On 2/15/2018 8:57 AM, Michael Niedermayer wrote:
> >On Tue, Feb 13, 2018 at 12:33:56AM +0530, Gyan Doshi wrote:
>
> >>+if (st->codecpar->codec_id == AV_CODEC_ID_PCM_DVD) {
> >>+if (size < 3) {
> >>+av_log(ctx,
On 2/15/2018 8:58 AM, Michael Niedermayer wrote:
On Tue, Feb 13, 2018 at 12:36:15AM +0530, Gyan Doshi wrote:
FATE patch and sample file attached. Sample file should go into (new) mpegps
directory in suite.
have you checked that none of the existing fate samples can be used ?
Yes. There's
On 2/15/2018 8:57 AM, Michael Niedermayer wrote:
On Tue, Feb 13, 2018 at 12:33:56AM +0530, Gyan Doshi wrote:
+if (st->codecpar->codec_id == AV_CODEC_ID_PCM_DVD) {
+if (size < 3) {
+av_log(ctx, AV_LOG_ERROR, "Invalid packet size %d\n", size);
+return -1;
On Tue, Feb 13, 2018 at 12:36:15AM +0530, Gyan Doshi wrote:
>
> On 2/3/2018 3:59 AM, Michael Niedermayer wrote:
>
> >>Subject: [PATCH v2] avformat/mpegenc - accept PCM_DVD streams
> >>
> >>PCM_S16BE stream packets in MPEG-PS have a 3-byte header
> >>and recognized as PCM_DVD by the demuxer which
On Tue, Feb 13, 2018 at 12:33:56AM +0530, Gyan Doshi wrote:
>
> On 2/3/2018 4:02 AM, Michael Niedermayer wrote:
>
> >>--- a/libavformat/mpegenc.c
> >>+++ b/libavformat/mpegenc.c
>
> >>+
> >>+if (st->codecpar->codec_id == AV_CODEC_ID_PCM_DVD) {
> >>+/* Skip first 3 bytes of packet dat
On 2/14/2018 3:59 AM, Michael Niedermayer wrote:
On Mon, Jan 29, 2018 at 06:53:06PM +0530, Gyan Doshi wrote:
On 1/29/2018 3:47 PM, Carl Eugen Hoyos wrote:
How did you test this patch?
By remuxing with patched ffmpeg and then checking with ffprobe, but not
ffplay!
muxer side changes shou
On Mon, Jan 29, 2018 at 06:53:06PM +0530, Gyan Doshi wrote:
>
> On 1/29/2018 3:47 PM, Carl Eugen Hoyos wrote:
>
> >How did you test this patch?
>
> By remuxing with patched ffmpeg and then checking with ffprobe, but not
> ffplay!
muxer side changes should be tested against something else than f
On Tue, Feb 13, 2018 at 12:36:15AM +0530, Gyan Doshi wrote:
>
> On 2/3/2018 3:59 AM, Michael Niedermayer wrote:
>
> >>Subject: [PATCH v2] avformat/mpegenc - accept PCM_DVD streams
> >>
> >>PCM_S16BE stream packets in MPEG-PS have a 3-byte header
> >>and recognized as PCM_DVD by the demuxer which
On 2/3/2018 4:02 AM, Michael Niedermayer wrote:
--- a/libavformat/mpegenc.c
+++ b/libavformat/mpegenc.c
+
+if (st->codecpar->codec_id == AV_CODEC_ID_PCM_DVD) {
+/* Skip first 3 bytes of packet data, which comprise PCM header
+ and will be written fresh by this muxer. */
On 2/3/2018 3:59 AM, Michael Niedermayer wrote:
Subject: [PATCH v2] avformat/mpegenc - accept PCM_DVD streams
PCM_S16BE stream packets in MPEG-PS have a 3-byte header
and recognized as PCM_DVD by the demuxer which prevents
their proper remuxing in MPEG-1/2 PS.
its probably a good idea to add
On Thu, Feb 08, 2018 at 02:04:57PM +0530, Gyan Doshi wrote:
>
>
> On 2/3/2018 3:59 AM, Michael Niedermayer wrote:
>
> >>PCM_S16BE stream packets in MPEG-PS have a 3-byte header
> >>and recognized as PCM_DVD by the demuxer which prevents
> >>their proper remuxing in MPEG-1/2 PS.
> >
> >its probab
On 2/3/2018 3:59 AM, Michael Niedermayer wrote:
PCM_S16BE stream packets in MPEG-PS have a 3-byte header
and recognized as PCM_DVD by the demuxer which prevents
their proper remuxing in MPEG-1/2 PS.
its probably a good idea to add a fate test for this too.
(could be in a seperate patch)
Wh
On Thu, Feb 01, 2018 at 07:52:55PM +0530, Gyan Doshi wrote:
> On 1/29/2018 6:53 PM, Gyan Doshi wrote:
> >
> >On 1/29/2018 3:47 PM, Carl Eugen Hoyos wrote:
> >
> >>How did you test this patch?
> >
> >By remuxing with patched ffmpeg and then checking with ffprobe, but not
> >ffplay!
> ...
> >Sorry, I
On Thu, Feb 01, 2018 at 07:52:55PM +0530, Gyan Doshi wrote:
> On 1/29/2018 6:53 PM, Gyan Doshi wrote:
> >
> >On 1/29/2018 3:47 PM, Carl Eugen Hoyos wrote:
> >
> >>How did you test this patch?
> >
> >By remuxing with patched ffmpeg and then checking with ffprobe, but not
> >ffplay!
> ...
> >Sorry, I
On 1/29/2018 6:53 PM, Gyan Doshi wrote:
On 1/29/2018 3:47 PM, Carl Eugen Hoyos wrote:
How did you test this patch?
By remuxing with patched ffmpeg and then checking with ffprobe, but not
ffplay!
...
Sorry, I'll rework and submit.
Revised and tested patch attached.
From 78757309bbfbc9d9e
On 1/29/2018 3:47 PM, Carl Eugen Hoyos wrote:
How did you test this patch?
By remuxing with patched ffmpeg and then checking with ffprobe, but not
ffplay!
On playback, I see the output is garbled, because the PCM_DVD header
carries over from the source packet and also breaks LPCM block
a
2018-01-29 8:12 GMT+01:00 Gyan Doshi :
How did you test this patch?
Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
17 matches
Mail list logo
