Re: [FFmpeg-devel] [PATCH v2] avcodec: Add librav1e encoder

2019-05-29 Thread Moritz Barsnick
Hi, > +during configuration. You need to explicitly configue the build with ^ configure > +Sets the maximum qauntizer (floor) to use when using bitrate mode. ^ quantizer Cheers, Moritz

Re: [FFmpeg-devel] [PATCH v2] avcodec: Add librav1e encoder

2019-05-29 Thread Derek Buitenhuis
On 29/05/2019 17:12, James Almer wrote: >> +end: >> +if (cfg) >> +rav1e_config_unref(cfg); >> + >> +if (ret) >> +librav1e_encode_close(avctx); > > Use the FF_CODEC_CAP_INIT_CLEANUP flag in AVCodec.caps_internal instead. > It will call AVCodec.close() on AVCodec.init()

Re: [FFmpeg-devel] [PATCH v2] avcodec: Add librav1e encoder

2019-05-29 Thread James Almer
On 5/29/2019 11:41 AM, Derek Buitenhuis wrote: > Uses the crav1e C bindings for rav1e. > > Port to the new send/receive API by: James Almer . > > Signed-off-by: Derek Buitenhuis > --- > The only thing I didn't address from the last set of replies was the > second 'ret' variable, since I prefer

Re: [FFmpeg-devel] [PATCH v2] avcodec: Add librav1e encoder

2019-05-29 Thread Derek Buitenhuis
On 29/05/2019 16:01, Lynne wrote: > for (int i = 0; i < desc->nb_components; i++) { > rav1e_frame_fill_plane() should probably return an error if the plane index > is invalid. Yep. Fixed locally. - Derek ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v2] avcodec: Add librav1e encoder

2019-05-29 Thread Lynne
May 29, 2019, 3:41 PM by derek.buitenh...@gmail.com: > + > +static int librav1e_send_frame(AVCodecContext *avctx, const AVFrame *frame) > +{ > +librav1eContext *ctx = avctx->priv_data; > +int ret; > + > +if (!ctx->rframe && frame) { > +const AVPixFmtDescriptor *desc =