Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/hashenc: add streamhash muxer

2019-09-19 Thread Peter B.
btw: If you need anything to be tested, just let me know :) Cheers! Peter ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/hashenc: add streamhash muxer

2019-09-12 Thread Moritz Barsnick
On Thu, Sep 12, 2019 at 13:44:57 +0200, Peter B. wrote: > If I understand this correctly, does it mean that the order of streams > output by the streamhash muxer will be "in order of type" (video, audio, > etc), independent of the order in the source? Since it's a muxer, and not a hashing demuxer

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/hashenc: add streamhash muxer

2019-09-12 Thread Gyan
On 12-09-2019 05:14 PM, Peter B. wrote: Hi :) On 11/09/2019 17:57, Gyan wrote: On 11-09-2019 08:19 PM, Moritz Barsnick wrote: The original user suggesting this muxer also requested a stream type indicator. Is that info really useful and not redundant, assuming the user will need to

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/hashenc: add streamhash muxer

2019-09-12 Thread Peter B.
Hi :) On 11/09/2019 17:57, Gyan wrote: > > On 11-09-2019 08:19 PM, Moritz Barsnick wrote: >> The original user suggesting this muxer also requested a stream type >> indicator. Is that info really useful and not redundant, assuming the >> user will need to understand the implications of remuxing

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/hashenc: add streamhash muxer

2019-09-11 Thread Gyan
On 11-09-2019 08:19 PM, Moritz Barsnick wrote: On Wed, Sep 11, 2019 at 19:57:43 +0530, Gyan wrote: +ffmpeg -i INPUT -f streamhash -hash md5 - +@end example Since there's no mapping, this will select only one video and audio stream, but more importantly the video will be first, which may not

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/hashenc: add streamhash muxer

2019-09-11 Thread Moritz Barsnick
On Wed, Sep 11, 2019 at 19:57:43 +0530, Gyan wrote: > > +ffmpeg -i INPUT -f streamhash -hash md5 - > > +@end example > Since there's no mapping, this will select only one video and audio > stream, but more importantly the video will be first, which may not be > the case in the input. Maybe add

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/hashenc: add streamhash muxer

2019-09-11 Thread Gyan
On 11-09-2019 07:04 PM, Moritz Barsnick wrote: Implemented as a variant of the hash muxer, reusing most functions, and making use of the previously introduced array of hashes. --- Changelog| 1 + doc/muxers.texi | 46 ++ libavformat/Makefile

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/hashenc: add streamhash muxer

2019-09-11 Thread Moritz Barsnick
On Wed, Sep 11, 2019 at 11:08:01 -0300, James Almer wrote: > > +static int streamhash_init(struct AVFormatContext *s) > > +{ > > +int res, i; > > +struct HashContext *c = s->priv_data; > > +c->per_stream = 1; > > +c->hashes = av_mallocz_array(s->nb_streams, sizeof(c->hashes)); > >

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/hashenc: add streamhash muxer

2019-09-11 Thread James Almer
On 9/11/2019 10:34 AM, Moritz Barsnick wrote: > Implemented as a variant of the hash muxer, reusing most functions, > and making use of the previously introduced array of hashes. > --- > Changelog| 1 + > doc/muxers.texi | 46 ++ >