Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-30 Thread Moritz Barsnick
On Wed, May 29, 2019 at 19:28:24 +0100, Derek Buitenhuis wrote: > +during configuration. You need to explicitly configue the build with ^ configure > +Sets the maximum qauntizer (floor) to use when using bitrate mode. ^ quantizer

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-30 Thread James Almer
On 5/30/2019 1:37 PM, Derek Buitenhuis wrote: > On 30/05/2019 17:27, James Almer wrote: >> All three options are important to get decent and/or fast encodings, so >> if you'd rather not add options for them, you should document what >> key=value combinations can be passed to rav1e-params, either

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-30 Thread Derek Buitenhuis
On 30/05/2019 17:27, James Almer wrote: > All three options are important to get decent and/or fast encodings, so > if you'd rather not add options for them, you should document what > key=value combinations can be passed to rav1e-params, either in > encoders.doxy, or as a printed list like

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-30 Thread James Almer
On 5/30/2019 1:15 PM, Derek Buitenhuis wrote: > On 30/05/2019 15:51, James Almer wrote: >> You could add tile-columns, tile-rows, and speed options. > > I'm of two minds here. > > One one hand, it is convenient. > > On the other hand, you may end up with a crappy pile of stuff > like libx264.c

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-30 Thread Derek Buitenhuis
On 30/05/2019 15:51, James Almer wrote: > You could add tile-columns, tile-rows, and speed options. I'm of two minds here. One one hand, it is convenient. On the other hand, you may end up with a crappy pile of stuff like libx264.c where everything has its own option or aomenc where new stuff

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-30 Thread James Almer
On 5/29/2019 3:28 PM, Derek Buitenhuis wrote: > Uses the crav1e C bindings for rav1e. > > Port to the new send/receive API by: James Almer . > > Signed-off-by: Derek Buitenhuis > --- > Changes since v2: > > * Removed 4:0:0 support; seems broken in rav1e (ref: >

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-29 Thread Vittorio Giovara
On Wed, May 29, 2019 at 2:28 PM Derek Buitenhuis wrote: > Uses the crav1e C bindings for rav1e. > --- a/doc/encoders.texi > +++ b/doc/encoders.texi > @@ -1378,6 +1378,35 @@ makes it possible to store non-rgb pix_fmts. > > @end table > > +@section librav1e > + > +rav1e AV1 encoder wrapper. > + >

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-29 Thread James Almer
On 5/29/2019 3:28 PM, Derek Buitenhuis wrote: > Uses the crav1e C bindings for rav1e. > > Port to the new send/receive API by: James Almer . > > Signed-off-by: Derek Buitenhuis > --- > Changes since v2: > > * Removed 4:0:0 support; seems broken in rav1e (ref: >