Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-14 Thread Bodecs Bela
2018.08.06. 16:20 keltezéssel, Steven Liu írta: On Aug 6, 2018, at 19:29, Ronak Patel wrote: On Aug 6, 2018, at 7:19 AM, Liu Steven wrote: 在 2018年8月6日,下午7:12,Ronak Patel 写道: On Aug 5, 2018, at 10:54 PM, Liu Steven wrote: 在 2018年8月4日,上午2:17,Ronak 写道: I have read this patch

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-13 Thread Steven Liu
> On Aug 14, 2018, at 05:06, Ronak wrote: > >> >> On Aug 13, 2018, at 10:49 AM, Steven Liu wrote: >>> Hi Steven, Did you have a chance to review this patch? I haven't seen your feedback yet. Did you have a chance to try it out? I would like to get this

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-13 Thread Ronak
> On Aug 13, 2018, at 4:48 PM, Ronak wrote: > > On Aug 13, 2018, at 10:49 AM, Steven Liu wrote: >> >>> >>> Hi Steven, >>> >>> Did you have a chance to review this patch? I haven't seen your feedback >>> yet. Did you have a chance to try it out? >>> I would like to get this merged this

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-13 Thread Ronak
On Aug 13, 2018, at 10:49 AM, Steven Liu wrote: > >> >> Hi Steven, >> >> Did you have a chance to review this patch? I haven't seen your feedback >> yet. Did you have a chance to try it out? >> I would like to get this merged this week. > 1. you MUST update the TARGET DURATION if the new

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-13 Thread Steven Liu
> > Hi Steven, > > Did you have a chance to review this patch? I haven't seen your feedback yet. > Did you have a chance to try it out? > I would like to get this merged this week. 1. you MUST update the TARGET DURATION if the new fragment is long than old fragment, don't only test your audio

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-13 Thread Ronak
> On Aug 10, 2018, at 6:31 AM, Ronak Patel > wrote: > >> >> On Aug 8, 2018, at 5:37 PM, Ronak wrote: >> >> >> >>> On Aug 8, 2018, at 3:52 PM, Ronak wrote: >>> >>> >>> On Aug 6, 2018, at 10:20 AM, Steven Liu wrote: >> On Aug 6, 2018, at 19:29, Ronak Patel

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-10 Thread Ronak Patel
On Aug 10, 2018, at 7:30 AM, Liu Steven wrote: >>> >>> Hi Steven, >>> >>> Please see my new patch taking your feedback into account. >>> >>> Ronak >> >> Hi Steven, >> >> Did you have a chance to review? I’m going to send you a new patch for >> dashenc.c shortly. > Don’t worry, i

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-10 Thread Liu Steven
>>> >> >> Hi Steven, >> >> Please see my new patch taking your feedback into account. >> >> Ronak > > Hi Steven, > > Did you have a chance to review? I’m going to send you a new patch for > dashenc.c shortly. Don’t worry, i will review it weekend, but i think your ways is not a better way,

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-10 Thread Ronak Patel
> On Aug 8, 2018, at 5:37 PM, Ronak wrote: > > > >> On Aug 8, 2018, at 3:52 PM, Ronak wrote: >> >> >> >>> On Aug 6, 2018, at 10:20 AM, Steven Liu wrote: >>> >>> >>> > On Aug 6, 2018, at 19:29, Ronak Patel > wrote: > > > On Aug 6, 2018, at 7:19 AM, Liu Steven

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-08 Thread Ronak
> On Aug 8, 2018, at 3:52 PM, Ronak wrote: > > > >> On Aug 6, 2018, at 10:20 AM, Steven Liu wrote: >> >> >> >>> On Aug 6, 2018, at 19:29, Ronak Patel >>> wrote: >>> On Aug 6, 2018, at 7:19 AM, Liu Steven wrote: >> 在 2018年8月6日,下午7:12,Ronak Patel 写道:

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-08 Thread Ronak
> On Aug 6, 2018, at 10:20 AM, Steven Liu wrote: > > > >> On Aug 6, 2018, at 19:29, Ronak Patel >> wrote: >> >>> >>> On Aug 6, 2018, at 7:19 AM, Liu Steven wrote: >>> >>> >>> > 在 2018年8月6日,下午7:12,Ronak Patel 写道: > > > On Aug 5, 2018, at 10:54 PM, Liu Steven wrote:

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-06 Thread Steven Liu
> On Aug 6, 2018, at 19:29, Ronak Patel > wrote: > >> >> On Aug 6, 2018, at 7:19 AM, Liu Steven wrote: >> >> >> 在 2018年8月6日,下午7:12,Ronak Patel 写道: On Aug 5, 2018, at 10:54 PM, Liu Steven wrote: > 在 2018年8月4日,上午2:17,Ronak 写道: >

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-06 Thread Ronak Patel
> On Aug 6, 2018, at 7:19 AM, Liu Steven wrote: > > > >>> 在 2018年8月6日,下午7:12,Ronak Patel 写道: >>> >>> >>> On Aug 5, 2018, at 10:54 PM, Liu Steven wrote: >>> >>> >>> 在 2018年8月4日,上午2:17,Ronak 写道: >> I have read this patch some problem for this patch. >>

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-06 Thread Liu Steven
> 在 2018年8月6日,下午7:12,Ronak Patel 写道: > >> >> On Aug 5, 2018, at 10:54 PM, Liu Steven wrote: >> >> >> >>> 在 2018年8月4日,上午2:17,Ronak 写道: >>> > I have read this patch some problem for this patch. > > 1. maybe there will have a problem when duration is not same when

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-06 Thread Ronak Patel
> On Aug 5, 2018, at 10:54 PM, Liu Steven wrote: > > > >> 在 2018年8月4日,上午2:17,Ronak 写道: >> I have read this patch some problem for this patch. 1. maybe there will have a problem when duration is not same when every fragment, for example:

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-05 Thread Liu Steven
> 在 2018年8月4日,上午2:17,Ronak 写道: > >>> I have read this patch some problem for this patch. >>> >>> 1. maybe there will have a problem when duration is not same when every >>> fragment, for example: >>> liuqideMacBook-Pro:xxx liuqi$ ./ffmpeg -v quiet -i >>>

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-05 Thread Ronak Patel
> I'm attaching a new patch that resolves all of these issues, while still > resolving this bug for VOD playlists. > > Can you please review? > > <0001-libavformat-hlsenc-Fix-HLS-Manifest-Generation-from-.patch> Hi Steven, Can you please have a look at the updated patch and tell me what you

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-03 Thread Ronak
>> I have read this patch some problem for this patch. >> >> 1. maybe there will have a problem when duration is not same when every >> fragment, for example: >> liuqideMacBook-Pro:xxx liuqi$ ./ffmpeg -v quiet -i >> ~/Movies/Test/bbb_sunflower_1080p_30fps_normal.mp4 -c

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-01 Thread Ronak Patel
> On Aug 1, 2018, at 9:30 PM, Ronak Patel > wrote: > > >> On Aug 1, 2018, at 7:30 PM, Steven Liu wrote: >> >> >> >>> On Aug 2, 2018, at 07:22, Steven Liu wrote: >>> >>> >>> > On Aug 2, 2018, at 06:20, Ronak wrote: > > > On Aug 1, 2018, at 4:41 PM, Steven Liu

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-01 Thread Ronak Patel
> On Aug 1, 2018, at 7:30 PM, Steven Liu wrote: > > > >> On Aug 2, 2018, at 07:22, Steven Liu wrote: >> >> >> On Aug 2, 2018, at 06:20, Ronak wrote: On Aug 1, 2018, at 4:41 PM, Steven Liu wrote: > On Aug 2, 2018, at 03:50, Ronak wrote: >

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-01 Thread Steven Liu
> On Aug 2, 2018, at 07:22, Steven Liu wrote: > > > >> On Aug 2, 2018, at 06:20, Ronak wrote: >> >>> >>> On Aug 1, 2018, at 4:41 PM, Steven Liu wrote: >>> >>> >>> On Aug 2, 2018, at 03:50, Ronak wrote: <0001-libavformat-hlsenc-Fix-HLS-Manifest-Generation-from-.patch>

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-01 Thread Steven Liu
> On Aug 2, 2018, at 06:20, Ronak wrote: > >> >> On Aug 1, 2018, at 4:41 PM, Steven Liu wrote: >> >> >> >>> On Aug 2, 2018, at 03:50, Ronak wrote: >>> >>> <0001-libavformat-hlsenc-Fix-HLS-Manifest-Generation-from-.patch> >> From e7ff03ed52c709d647a112833427b44c41e3ed12 Mon Sep 17

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-01 Thread Ronak
> On Aug 1, 2018, at 4:41 PM, Steven Liu wrote: > > > >> On Aug 2, 2018, at 03:50, Ronak wrote: >> >> <0001-libavformat-hlsenc-Fix-HLS-Manifest-Generation-from-.patch> > From e7ff03ed52c709d647a112833427b44c41e3ed12 Mon Sep 17 00:00:00 2001 > From: "Ronak Patel (Audible)" > Date: Tue, 31

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-01 Thread Steven Liu
> On Aug 2, 2018, at 03:50, Ronak wrote: > > <0001-libavformat-hlsenc-Fix-HLS-Manifest-Generation-from-.patch> From e7ff03ed52c709d647a112833427b44c41e3ed12 Mon Sep 17 00:00:00 2001 From: "Ronak Patel (Audible)" Date: Tue, 31 Jul 2018 19:05:18 -0400 Subject: [PATCH] libavformat/hlsenc: Fix

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-01 Thread Ronak
> On Aug 1, 2018, at 2:14 PM, Carl Eugen Hoyos wrote: > > 2018-08-01 20:02 GMT+02:00, Ronak : >> I'm re-sending the attachment. > > Your patch contains tabs that cannot be committed to FFmpeg's repository - > please remove them. > Sounds good. Tabs are now removed.

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-01 Thread Carl Eugen Hoyos
2018-08-01 20:02 GMT+02:00, Ronak : > I'm re-sending the attachment. Your patch contains tabs that cannot be committed to FFmpeg's repository - please remove them. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-01 Thread Ronak
I'm re-sending the attachment. Not sure why it's not showing up. 0001-libavformat-hlsenc-Fix-HLS-Manifest-Generation-from-.patch Description: Binary data > On Aug 1, 2018, at 1:56 PM, Carl Eugen Hoyos wrote: > > 2018-08-01 18:39 GMT+02:00, Ronak : > >> Here's my first proposed patch for

Re: [FFmpeg-devel] First Patch for hlsenc.c for https://trac.ffmpeg.org/ticket/7281

2018-08-01 Thread Carl Eugen Hoyos
2018-08-01 18:39 GMT+02:00, Ronak : > Here's my first proposed patch for fixing > https://trac.ffmpeg.org/ticket/7281 No patch visible here: http://ffmpeg.org/pipermail/ffmpeg-devel/2018-August/232785.html Carl Eugen ___ ffmpeg-devel mailing list