Re: [FFmpeg-devel] avcodec/utvideoenc : add SIMD (SSSE3) for sub_left_pred

2018-01-28 Thread Martin Vignali
2018-01-14 14:31 GMT+01:00 Martin Vignali : > Hello, > > new patch in attach > no more segfault if i remove movsxdifnidn, after change in the > "declare_func_emms" > part > > I also modify the checkasm test, following your comments > > Martin > > Pushed Martin

Re: [FFmpeg-devel] avcodec/utvideoenc : add SIMD (SSSE3) for sub_left_pred

2018-01-14 Thread Martin Vignali
Hello, new patch in attach no more segfault if i remove movsxdifnidn, after change in the "declare_func_emms" part I also modify the checkasm test, following your comments Martin 0001-avcodec-utvideoenc-add-SIMD-avx-for-sub_left_predict.patch Description: Binary data

Re: [FFmpeg-devel] avcodec/utvideoenc : add SIMD (SSSE3) for sub_left_pred

2018-01-14 Thread James Almer
On 1/14/2018 7:46 AM, Henrik Gramner wrote: > On Sat, Jan 13, 2018 at 5:22 PM, Martin Vignali > wrote: >> +#define randomize_buffers(buf, size) \ >> +do { \ >> +int j; \ >> +uint8_t

Re: [FFmpeg-devel] avcodec/utvideoenc : add SIMD (SSSE3) for sub_left_pred

2018-01-14 Thread Henrik Gramner
On Sat, Jan 13, 2018 at 5:22 PM, Martin Vignali wrote: > +#define randomize_buffers(buf, size) \ > +do { \ > +int j; \ > +uint8_t *tmp_buf = (uint8_t *)buf;\ > +for (j = 0; j <

Re: [FFmpeg-devel] avcodec/utvideoenc : add SIMD (SSSE3) for sub_left_pred

2018-01-13 Thread Henrik Gramner
On Sat, Jan 13, 2018 at 5:22 PM, Martin Vignali wrote: > i try to change int width -> ptrdiff_t width to remove movsxdifnidn > but i have a segfault if height > 1 I'm guessing due to > +declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *dst, const uint8_t > *src, >

Re: [FFmpeg-devel] avcodec/utvideoenc : add SIMD (SSSE3) for sub_left_pred

2018-01-13 Thread Martin Vignali
Hello, Following Henrik Gramner's comments, new patch in attach i try to change int width -> ptrdiff_t width to remove movsxdifnidn but i have a segfault if height > 1 pass fate test for me. Martin 0001-avcodec-utvideoenc-add-SIMD-avx-for.patch Description: Binary data

Re: [FFmpeg-devel] avcodec/utvideoenc : add SIMD (SSSE3) for sub_left_pred

2018-01-12 Thread Michael Niedermayer
On Fri, Jan 12, 2018 at 09:57:03AM +0100, Martin Vignali wrote: > > > > this changes the output: > > make -j12 && ./ffmpeg -i ~/videos/matrixbench_mpeg2.mpg -an -vcodec > > utvideo -t 1 -pix_fmt yuv420p -pred left -t 1 test2.avi > > > > -rw-r- 1 michael michael 3744402 Jan 12 04:20 test2.avi

Re: [FFmpeg-devel] avcodec/utvideoenc : add SIMD (SSSE3) for sub_left_pred

2018-01-12 Thread Henrik Gramner
On Thu, Jan 11, 2018 at 9:45 PM, Martin Vignali wrote: > +if (check_func(c.sub_left_predict, "sub_left_predict")) { > +call_ref(dst0, src0, stride, width, height); > +call_new(dst1, src0, stride, width, height); > +if (memcmp(dst0, dst1,

Re: [FFmpeg-devel] avcodec/utvideoenc : add SIMD (SSSE3) for sub_left_pred

2018-01-12 Thread Martin Vignali
> > this changes the output: > make -j12 && ./ffmpeg -i ~/videos/matrixbench_mpeg2.mpg -an -vcodec > utvideo -t 1 -pix_fmt yuv420p -pred left -t 1 test2.avi > > -rw-r- 1 michael michael 3744402 Jan 12 04:20 test2.avi > -rw-r- 1 michael michael 3753358 Jan 12 04:19 test.avi > > > Hello,

Re: [FFmpeg-devel] avcodec/utvideoenc : add SIMD (SSSE3) for sub_left_pred

2018-01-11 Thread Michael Niedermayer
On Thu, Jan 11, 2018 at 09:45:07PM +0100, Martin Vignali wrote: > Hello, > > in attach patch to add SIMD for sub_left_pred in utvideoenc > > 001 : add SIMD for utvideoenc > 002 : add checkasm for llviddspenc (diff bytes and sub_left_pred) > > Encoding result : > ./ffmpeg -i utvideo_file.avi