[Firebird-devel] Regression FB3RC1 vs FB2.5?

2015-11-12 Thread liviuslivius
Hi,   i prepare test comparison between FB2.5 vs FB3.0RC1 and found this regression both databases was restored from same backup file (db are the same)     WI-V3.0.0.32172 Firebird 3.0 Release Candidate 1 WI-V2.5.3.26738 Firebird 2.5     SELECT  W.* FROM  WPLATA W WHERE  W.WPLATA_KWOTA > 0  AND W.W

[Firebird-devel] [FB-Tracker] Created: (CORE-5016) Server crashes with database corruption when DELETE after adding new referencing column

2015-11-12 Thread Tim Kelly (JIRA)
Server crashes with database corruption when DELETE after adding new referencing column --- Key: CORE-5016 URL: http://tracker.firebirdsql.org/browse/CORE-5016 Projec

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Vlad Khorsun
13.11.2015 0:02, Dimitry Sibiryakov wrote: > 12.11.2015 22:30, Vlad Khorsun wrote: >>> Yep. As I said, good old style plugins: separate library for each, a >>> definite entry point for each type which returns ready-to-use plugin class instead of pointless factory. >> I see no

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Dimitry Sibiryakov
12.11.2015 22:30, Vlad Khorsun wrote: >> Yep. As I said, good old style plugins: separate library for each, a >> definite entry >> >point for each type which returns ready-to-use plugin class instead of >> >pointless factory. > I see no good reason to force people to isolate tightly coup

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Vlad Khorsun
12.11.2015 21:33, Dimitry Sibiryakov wrote: > 12.11.2015 20:12, Vlad Khorsun wrote: >> How much ? Do yo know way better ? > > Not much, I agree. But still it is excess. > >> Do yo know way better ? > > Yep. As I said, good old style plugins: separate library for each, a > definite e

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Dimitry Sibiryakov
12.11.2015 20:12, Vlad Khorsun wrote: > How much ? Do yo know way better ? Not much, I agree. But still it is excess. > Do yo know way better ? Yep. As I said, good old style plugins: separate library for each, a definite entry point for each type which returns ready-to-use plugin c

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Dimitry Sibiryakov
12.11.2015 19:57, Adriano dos Santos Fernandes wrote: > Not only config file, the FB/Java plugin needs a *.jar directory. You can put "JarDirecory=c:\whatever\" into you plugin's config. > The design choose by Firebird code is that defaults does not need to be > listed in the config file. It's

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Vlad Khorsun
12.11.2015 20:24, Adriano dos Santos Fernandes wrote: ... > BTW, another info the plugin entry point could receive now: the library > filename. > > This way it can load additional configuration files, for example. > > That can be obtained by it himself, but it's trick, it's platform dependent.

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Vlad Khorsun
12.11.2015 20:14, Dimitry Sibiryakov wrote: > 12.11.2015 19:07, Vlad Khorsun wrote: >> And what a problem do you see there ? > > None. Just some unnecessary work and pollution of internal tables. How much ? Do yo know way better ? ... >> Plugin Manager is a component of fbclient

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Adriano dos Santos Fernandes
On 12/11/2015 16:44, Dimitry Sibiryakov wrote: > 12.11.2015 19:24, Adriano dos Santos Fernandes wrote: >> BTW, another info the plugin entry point could receive now: the library >> filename. >> >> This way it can load additional configuration files, for example. >It already can be done with ICo

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Dimitry Sibiryakov
12.11.2015 19:24, Adriano dos Santos Fernandes wrote: > BTW, another info the plugin entry point could receive now: the library > filename. > > This way it can load additional configuration files, for example. It already can be done with IConfig that provides access to all configuration a plug

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Vlad Khorsun
12.11.2015 20:19, Adriano dos Santos Fernandes wrote: > On 12/11/2015 15:35, Vlad Khorsun wrote: ... >> I have no objection to add IStatus to the FB_PLUGIN_ENTRY_POINT. >> >> But i see no need in IPluginInitialization. > > IPluginInitialization is a way to make things extensible. How ??

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Adriano dos Santos Fernandes
On 12/11/2015 16:19, Adriano dos Santos Fernandes wrote: > On 12/11/2015 15:35, Vlad Khorsun wrote: >> 12.11.2015 19:19, Adriano dos Santos Fernandes wrote: >>> On 12/11/2015 14:51, Vlad Khorsun wrote: 12.11.2015 17:20, Adriano dos Santos Fernandes wrote: > Hi! > > Currently plugin

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Adriano dos Santos Fernandes
On 12/11/2015 15:35, Vlad Khorsun wrote: > 12.11.2015 19:19, Adriano dos Santos Fernandes wrote: >> On 12/11/2015 14:51, Vlad Khorsun wrote: >>> 12.11.2015 17:20, Adriano dos Santos Fernandes wrote: Hi! Currently plugin entry points receives just an IMaster. It cannot do mu

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Dimitry Sibiryakov
12.11.2015 19:07, Vlad Khorsun wrote: > And what a problem do you see there ? None. Just some unnecessary work and pollution of internal tables. > If you think you see a problem - report it. Already done privately to Alex. > Plugin Manager is a component of fbclient, Dispatche

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Vlad Khorsun
12.11.2015 19:51, Dimitry Sibiryakov wrote: > 12.11.2015 18:37, Vlad Khorsun wrote: >> Plugin manager (not the engine itself) used list of plugins of given >> kind which is configured >> in firebird.conf > > Right. But when their modules are loaded, they register all plugins they > imple

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Dimitry Sibiryakov
12.11.2015 18:37, Vlad Khorsun wrote: > Plugin manager (not the engine itself) used list of plugins of given kind > which is configured > in firebird.conf Right. But when their modules are loaded, they register all plugins they implements, even those that are not needed. Next, for Key

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Vlad Khorsun
12.11.2015 19:25, Dimitry Sibiryakov wrote: > 12.11.2015 18:19, Adriano dos Santos Fernandes wrote: >> And that can be answered in one go: the engine already lazily load plugins. > > It is not quite so, plugins are loaded by engine even if they are not > needed, because > engine cannot predict

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Vlad Khorsun
12.11.2015 19:19, Adriano dos Santos Fernandes wrote: > On 12/11/2015 14:51, Vlad Khorsun wrote: >> 12.11.2015 17:20, Adriano dos Santos Fernandes wrote: >>> Hi! >>> >>> Currently plugin entry points receives just an IMaster. >>> >>> It cannot do much things with only this. >> Example ? >> >>>

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Dimitry Sibiryakov
12.11.2015 18:19, Adriano dos Santos Fernandes wrote: > And that can be answered in one go: the engine already lazily load plugins. It is not quite so, plugins are loaded by engine even if they are not needed, because engine cannot predict which one will register required plugin afterward.

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Adriano dos Santos Fernandes
On 12/11/2015 14:51, Vlad Khorsun wrote: > 12.11.2015 17:20, Adriano dos Santos Fernandes wrote: >> Hi! >> >> Currently plugin entry points receives just an IMaster. >> >> It cannot do much things with only this. >Example ? > >> Not all plugins will register a factory >Why ? > >> and do all

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Vlad Khorsun
12.11.2015 17:20, Adriano dos Santos Fernandes wrote: > Hi! > > Currently plugin entry points receives just an IMaster. > > It cannot do much things with only this. Example ? > Not all plugins will register a factory Why ? > and do all the work lazily. I see no problem to create facto

Re: [Firebird-devel] Plugin initialization

2015-11-12 Thread Dimitry Sibiryakov
12.11.2015 16:20, Adriano dos Santos Fernandes wrote: > So the prototype will become: > > void FB_PLUGIN_ENTRY_POINT(IStatus*, IPluginInitialization*); Take a step further: a) Use separate entry points for separate plugin types. b) Drop factory, let entry point to return plugin itself. c) Drop

[Firebird-devel] Plugin initialization

2015-11-12 Thread Adriano dos Santos Fernandes
Hi! Currently plugin entry points receives just an IMaster. It cannot do much things with only this. Not all plugins will register a factory and do all the work lazily. It should receive a "plugin config" parameter and an Status to report errors to the engine, to log them or return to the user.

Re: [Firebird-devel] Initialization of CryptoManager

2015-11-12 Thread Dimitry Sibiryakov
12.11.2015 15:05, Alex Peshkoff wrote: > No, it's not possible (at least I do not see such bug in current code). I see. IMHO, startCryptThread() is far from obvious place for initialization. May be a comment in the beginning, stating that this routine is called synchronously at every sing

[Firebird-devel] [FB-Tracker] Created: (CORE-5015) AV in engine could happen when ON DISCONNECT trigger posted event

2015-11-12 Thread Vlad Khorsun (JIRA)
AV in engine could happen when ON DISCONNECT trigger posted event - Key: CORE-5015 URL: http://tracker.firebirdsql.org/browse/CORE-5015 Project: Firebird Core Issue Type: Bug

Re: [Firebird-devel] Initialization of CryptoManager

2015-11-12 Thread Alex Peshkoff
On 11/12/2015 04:52 PM, Dimitry Sibiryakov wrote: > Hello, All. > > In code of CryptoManager I see only one place where variable "crypt" is > initialized > during normal operations. Is it possible that if encrypted database has no > single > encrypted page (yet), new pages will be written

[Firebird-devel] Initialization of CryptoManager

2015-11-12 Thread Dimitry Sibiryakov
Hello, All. In code of CryptoManager I see only one place where variable "crypt" is initialized during normal operations. Is it possible that if encrypted database has no single encrypted page (yet), new pages will be written unencrypted as well? Say, if initial encryption thread faile

[Firebird-devel] [FB-Tracker] Created: (CORE-5014) Interrupt of aux connection during TCP setup phase causes unclear error messages in firebird.log

2015-11-12 Thread Alexander Peshkov (JIRA)
Interrupt of aux connection during TCP setup phase causes unclear error messages in firebird.log Key: CORE-5014 URL: http://tracker.firebirdsql.org/browse/CORE-5014

Re: [Firebird-devel] Key holder and several keys

2015-11-12 Thread Dimitry Sibiryakov
11.11.2015 16:24, Alex Peshkoff wrote: > What about database name - I think it can be useful not for > crypt-related plugins only. Therefore I plan to add it to PluginConfig > interface, both alias and filename. What else worth adding there? It would be nice to know database page size and versi

[Firebird-devel] [FB-Tracker] Created: (CORE-5013) Comments in a view DDL that follow last byte of query aren't included in this view source

2015-11-12 Thread Pavel Zotov (JIRA)
Comments in a view DDL that follow last byte of query aren't included in this view source - Key: CORE-5013 URL: http://tracker.firebirdsql.org/browse/CORE-5013 Pr

[Firebird-devel] [FB-Tracker] Created: (CORE-5012) Inline comment ("-- ...") in a view DDL can lead to problem with compiling database metadata that is extracted later by ISQL -X (2.5 only)

2015-11-12 Thread Pavel Zotov (JIRA)
Inline comment ("-- ...") in a view DDL can lead to problem with compiling database metadata that is extracted later by ISQL -X (2.5 only) -- Ke