Re: [Firebird-devel] ICU in HEAD

2019-02-08 Thread Dimitry Sibiryakov
08.02.2019 12:29, Alex Peshkoff via Firebird-devel wrote: - adapt search knowing existing versions numbers (see http://site.icu-project.org/download) Yes, this should be efficient. I would limit tried versions to only those which are known to work with Firebird. For example, cut off tho

Re: [Firebird-devel] ICU in HEAD

2019-02-08 Thread Adriano dos Santos Fernandes
On 08/02/2019 09:29, Alex Peshkoff via Firebird-devel wrote: > On 2/8/19 12:15 PM, Vlad Khorsun wrote: >> 08.02.2019 10:48, Alex Peshkoff via Firebird-devel wrote: >>> On 2/8/19 10:56 AM, Vlad Khorsun wrote: >>   Is it time to re-think how UnicodeUtil::getConversionICU() search for ICU li

Re: [Firebird-devel] ICU in HEAD

2019-02-08 Thread Alex Peshkoff via Firebird-devel
On 2/8/19 3:00 PM, Vlad Khorsun wrote: 08.02.2019 13:29, Alex Peshkoff via Firebird-devel wrote: On 2/8/19 12:15 PM, Vlad Khorsun wrote: 08.02.2019 10:48, Alex Peshkoff via Firebird-devel wrote: On 2/8/19 10:56 AM, Vlad Khorsun wrote:   Is it time to re-think how UnicodeUtil::getConversionIC

Re: [Firebird-devel] ICU in HEAD

2019-02-08 Thread Vlad Khorsun
08.02.2019 13:29, Alex Peshkoff via Firebird-devel wrote: On 2/8/19 12:15 PM, Vlad Khorsun wrote: 08.02.2019 10:48, Alex Peshkoff via Firebird-devel wrote: On 2/8/19 10:56 AM, Vlad Khorsun wrote:   Is it time to re-think how UnicodeUtil::getConversionICU() search for ICU library ? Sugges

Re: [Firebird-devel] ICU in HEAD

2019-02-08 Thread Alex Peshkoff via Firebird-devel
On 2/8/19 12:15 PM, Vlad Khorsun wrote: 08.02.2019 10:48, Alex Peshkoff via Firebird-devel wrote: On 2/8/19 10:56 AM, Vlad Khorsun wrote:   Is it time to re-think how UnicodeUtil::getConversionICU() search for ICU library ? Suggestions? The fastest way sooner of all will be storing favori

Re: [Firebird-devel] ICU in HEAD

2019-02-08 Thread Alex Peshkoff via Firebird-devel
On 2/8/19 2:24 PM, Dimitry Sibiryakov wrote: 08.02.2019 12:21, Alex Peshkoff via Firebird-devel wrote:   The error you are getting is different, so I would guess that search loop is aborted faster in this case. Is it good idea to provide full error message? (like I did - not to make other gue

Re: [Firebird-devel] ICU in HEAD

2019-02-08 Thread Dimitry Sibiryakov
08.02.2019 12:21, Alex Peshkoff via Firebird-devel wrote:   The error you are getting is different, so I would guess that search loop is aborted faster in this case. Is it good idea to provide full error message? (like I did - not to make other guess) Not in this case, but here it is: cre

Re: [Firebird-devel] ICU in HEAD

2019-02-08 Thread Alex Peshkoff via Firebird-devel
On 2/8/19 2:01 PM, Dimitry Sibiryakov wrote: 08.02.2019 8:31, Alex Peshkoff via Firebird-devel wrote: I can't reproduce performance problem: # time (echo 'exit;' | ./isql employee) Statement failed, SQLSTATE = XX000 Could not find acceptable ICU library -Missing entrypoint u_setDataDirectory in

Re: [Firebird-devel] ICU in HEAD

2019-02-08 Thread Dimitry Sibiryakov
08.02.2019 10:15, Vlad Khorsun wrote:   Also, we could limit number of ICU versions to check: - exclude really old versions (at least with old X.Y versioning scheme, i.e. 4.8 and older) - adapt search knowing existing versions numbers (see http://site.icu-project.org/download) - guess number o

Re: [Firebird-devel] ICU in HEAD

2019-02-08 Thread Dimitry Sibiryakov
08.02.2019 8:31, Alex Peshkoff via Firebird-devel wrote: I can't reproduce performance problem: # time (echo 'exit;' | ./isql employee) Statement failed, SQLSTATE = XX000 Could not find acceptable ICU library -Missing entrypoint u_setDataDirectory in ICU library The error you are getting is

Re: [Firebird-devel] ICU in HEAD

2019-02-08 Thread Vlad Khorsun
08.02.2019 10:48, Alex Peshkoff via Firebird-devel wrote: On 2/8/19 10:56 AM, Vlad Khorsun wrote:   Is it time to re-think how UnicodeUtil::getConversionICU() search for ICU library ? Suggestions? The fastest way sooner of all will be storing favorite ICU verson (once detected using long p

Re: [Firebird-devel] ICU in HEAD

2019-02-08 Thread Alex Peshkoff via Firebird-devel
On 2/8/19 10:56 AM, Vlad Khorsun wrote: 08.02.2019 9:31, Alex Peshkoff via Firebird-devel wrote: On 2/7/19 6:14 PM, Dimitry Sibiryakov wrote: Hello, All.   I somehow understand why build of current HEAD is failing with message "Could not find acceptable ICU library", but I wonder why it take

Re: [Firebird-devel] ICU in HEAD

2019-02-07 Thread Vlad Khorsun
08.02.2019 9:31, Alex Peshkoff via Firebird-devel wrote: On 2/7/19 6:14 PM, Dimitry Sibiryakov wrote: Hello, All.   I somehow understand why build of current HEAD is failing with message "Could not find acceptable ICU library", but I wonder why it takes so much time to get this error? More tha

Re: [Firebird-devel] ICU in HEAD

2019-02-07 Thread Alex Peshkoff via Firebird-devel
On 2/7/19 6:14 PM, Dimitry Sibiryakov wrote: Hello, All.   I somehow understand why build of current HEAD is failing with message "Could not find acceptable ICU library", but I wonder why it takes so much time to get this error? More than 15 second between running of isql and this failure on

Re: [Firebird-devel] ICU in HEAD

2019-02-07 Thread Roman Simakov
Have you tried to profile? :) чт, 7 февр. 2019 г. в 18:15, Dimitry Sibiryakov : > >Hello, All. > >I somehow understand why build of current HEAD is failing with message > "Could not find > acceptable ICU library", but I wonder why it takes so much time to get this > error? More > than 15