[Firebird-devel] Plan formatting

2019-09-10 Thread liviuslivius
Hi   i work a little on https://github.com/FirebirdSQL/firebird/pull/223. I know this is not top 1 priority for the team, but i need some decisions from the team about formatting   1. Style of the name of xml nodes "JoinType" like MSSQL "Join-Type" like Postgress "Join_Type" other proposition..  

Re: [Firebird-devel] Plan formatting

2019-09-10 Thread Mark Rotteveel
On 10-9-2019 10:16, liviuslivius wrote: Hi i work a little on https://github.com/FirebirdSQL/firebird/pull/223. I know this is not top 1 priority for the team, but i need some decisions from the team about formatting 1. Style of the name of xml nodes "JoinType" like MSSQL "Join-Type" like Postg

Re: [Firebird-devel] "set decfloat bind double precision" and others

2019-09-10 Thread Mark Rotteveel
On 9-9-2019 16:31, liviuslivius wrote: Maybe this sample will be better. Some sql tool which need run itself some internall queries but user need different settings for he/she queries by this tool. That doesn't make much sense either. The bind property settings are intended to handle client c

Re: [Firebird-devel] Plan formatting

2019-09-10 Thread Adriano dos Santos Fernandes
On 10/09/2019 05:16, liviuslivius wrote: > Hi >   > i work a little on https://github.com/FirebirdSQL/firebird/pull/223. > I know this is not top 1 priority for the team, but i need some > decisions from the team about formatting >   > 1. Style of the name of xml nodes > "JoinType" like MSSQL > "Jo

Re: [Firebird-devel] "set decfloat bind double precision" and others

2019-09-10 Thread Adriano dos Santos Fernandes
On 10/09/2019 07:08, Mark Rotteveel wrote: > > The SQL standard defines a number of session management statements > that all start with SET: > > - SET SESSION CHARACTERISTICS AS > - SET SESSION AUTHORIZATION .. > - SET ROLE .. > - SET TIME ZONE .. > - SET CATALOG .. > - SET SCHEMA .. > - SET NAMES

Re: [Firebird-devel] Plan formatting

2019-09-10 Thread liviuslivius
>> I prefer JoinType with camelCase attributesOk, name convention two votes.  >> But does it mean that you prefere format with attributes then? Or longer one >> but without attributes at all?>> And if you use a xml schema, you should >> publish that schema.It is no real schema. It is now as adver

Re: [Firebird-devel] Plan formatting

2019-09-10 Thread Dimitry Sibiryakov
10.09.2019 13:30, liviuslivius wrote: But does it mean that you prefere format with attributes then? Or longer one but without attributes at all? I'm not a team member but as an user I would prefer format that is understood by already existing tools. -- WBR, SD. Firebird-Devel mailing

Re: [Firebird-devel] "set decfloat bind double precision" and others

2019-09-10 Thread liviuslivius
>>Ok, this makes a bit more sense then. Yes, i do not ask exacly about BIND only all SET commands >> Although why obtain it through MON$STATEMENTS, when that is what the >> information API is for. >>And keep in mind that querying MON$STATEMENTS is relatively expensive, so >>building a feature

Re: [Firebird-devel] Plan formatting

2019-09-10 Thread liviuslivius
It is not repleacement of current plan only another plan format.Current one is default then tools not affected.Regards,Karol Bieniaszewski Oryginalna wiadomość Od: Dimitry Sibiryakov Data: 10.09.2019 13:35 (GMT+01:00) Do: For discussion among Firebird Developers Temat: Re:

Re: [Firebird-devel] Plan formatting

2019-09-10 Thread Adriano dos Santos Fernandes
On 10/09/2019 08:30, liviuslivius wrote: > >> I prefer JoinType with camelCase attributes > > Ok, name convention two votes.  > > But does it mean that you prefere format with attributes then? With attributes, example: name="name", and not name. Nodes only for structures. > Or longer one but wi

Re: [Firebird-devel] Plan formatting

2019-09-10 Thread liviuslivius
>> A schema is a form of documentation and for tooling (classes generation). >> It's very welcome. Of course it will be good to have it. I do not negate this. But i suppose it is not required at start. >>With attributes, example: name="name", and not name. >>Nodes only for structures. I do not

Re: [Firebird-devel] "set decfloat bind double precision" and others

2019-09-10 Thread Alex Peshkoff via Firebird-devel
On 10.09.2019 14:35, liviuslivius wrote: The SQL standard defines a number of session management statements that all start with SET: That's funny but a number of session management statements begin not with SET but with ALTER SESSION. SQL standard is not too careful in this aspect. Fi

Re: [Firebird-devel] Plan formatting

2019-09-10 Thread Dimitry Sibiryakov
10.09.2019 14:11, liviuslivius wrote: It is not repleacement of current plan only another plan format. Current one is default then tools not affected. Yes. I meant non-Firebird tools like MS Management Studio etc. -- WBR, SD. Firebird-Devel mailing list, web interface at https://lists.

[Firebird-devel] Handling FbException

2019-09-10 Thread Jiří Činčura
Hi *, every example I've found uses this structure: catch (const FbException& error) { char buf[256]; utl->formatStatus(buf, sizeof(buf), error.getStatus()); // ... } Is is guaranteed that the 256 buffer is enough? I'm no expert in C++, but I would expect no and hence some other way to get