Re: [Fish-users] Fixing title setting in OS X

2010-04-03 Thread Ben Hoskings
2010/4/3 David Frascone d...@frascone.com I need to check out a linux tree from darcs and apply these changes to make sure I'm not breaking anything . . . My git repo (and yours if you cloned from mine) contains the full history, so to get the current state of the darcs repo (i.e. Axel's

Re: [Fish-users] Fixing title setting in OS X

2010-04-02 Thread Isaac Dupree
On 04/02/10 10:26, David Frascone wrote: So, how do you think this should be generically fixed? In my tree, I simply commented out the /dev/tty setting. But, I don't want to break things for linux. And, I don't want to have conditional compilations, if they can be avoided. as you wish... I

Re: [Fish-users] Fixing title setting in OS X

2010-04-02 Thread David Frascone
On Fri, Apr 2, 2010 at 1:23 PM, Isaac Dupree m...@isaac.cedarswampstudios.org wrote: as you wish... I think conditional compilation for accessing Linux vs. Darwin /dev/ filenames makes a ton of sense. (Or use a C if() and a system-call that tells you which system it is, if you wish, if such

Re: [Fish-users] Fixing title setting in OS X

2010-04-02 Thread Isaac Dupree
On 04/02/10 13:34, David Frascone wrote: So, given the ttys difference -- think we should go with an env setting, or a quick fix that works for Darwin? just use the appropriate check for ttys in the code. And make sure that you add a comment for what each string-check is checking for (e.g.

Re: [Fish-users] Fixing title setting in OS X

2010-04-02 Thread David Frascone
On Fri, Apr 2, 2010 at 2:17 PM, Isaac Dupree m...@isaac.cedarswampstudios.org wrote: On 04/02/10 13:34, David Frascone wrote: So, given the ttys difference -- think we should go with an env setting, or a quick fix that works for Darwin? just use the appropriate check for ttys in the