Re: [Fish-users] Fixing title setting in OS X
2010/4/3 David Frascone d...@frascone.com I need to check out a linux tree from darcs and apply these changes to make sure I'm not breaking anything . . . My git repo (and yours if you cloned from mine) contains the full history, so to get the current state of the darcs repo (i.e. Axel's latest code), you can just do something like git commit -a -m 'Temp' # if you have uncommitted changes git checkout -b axel git reset --hard 1eb089d # That's axel's latest commit, from early '09 —Ben -- Download Intel#174; Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev___ Fish-users mailing list Fish-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/fish-users
Re: [Fish-users] Fixing title setting in OS X
On 04/02/10 10:26, David Frascone wrote: So, how do you think this should be generically fixed? In my tree, I simply commented out the /dev/tty setting. But, I don't want to break things for linux. And, I don't want to have conditional compilations, if they can be avoided. as you wish... I think conditional compilation for accessing Linux vs. Darwin /dev/ filenames makes a ton of sense. (Or use a C if() and a system-call that tells you which system it is, if you wish, if such a thing exists... it's conventional to use conditional-compilation!) But you'll have to tell me, what is the exact naming convention that Darwin/OSX uses? (for example, is /dev/tty1 a device-name on Darwin, or not? If not, then we can tell the difference just based on the names, with just a small bit of coding.) Should I abuse another environment variable? Even still, how should it look? #linux set FISH_TERMINALS_WITH_TITLES /dev/pts whatever screen uses #osx set FISH_TERMINALS_WITH_TITLES /dev/tty whatever screen uses Then the code can go through that and do the strnstr? I don't particularly like adding more special environment variables either, but I like it better than conditional compilation. I suppose special fish environment variables could be used... make sure that they're initialized correctly for each system though, even if you share ~/.config/fish/ between a Mac and a Linux system and go back and forth... and it would clearly be just as much conditional as compiling it into the C code. And I can tell that you're not engineering with weird hackers on weird embedded Linux setups in mind, so this configurability would probably not be useful even for dealing with that. -Isaac -- Download Intel#174; Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev ___ Fish-users mailing list Fish-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/fish-users
Re: [Fish-users] Fixing title setting in OS X
On Fri, Apr 2, 2010 at 1:23 PM, Isaac Dupree m...@isaac.cedarswampstudios.org wrote: as you wish... I think conditional compilation for accessing Linux vs. Darwin /dev/ filenames makes a ton of sense. (Or use a C if() and a system-call that tells you which system it is, if you wish, if such a thing exists... it's conventional to use conditional-compilation!) But you'll have to tell me, what is the exact naming convention that Darwin/OSX uses? (for example, is /dev/tty1 a device-name on Darwin, or not? If not, then we can tell the difference just based on the names, with just a small bit of coding.) Good point: Darwin is using: codemon...@daves-mbp ~/dotfiles tty /dev/ttys015 I think ttys may be safe to use! I suppose special fish environment variables could be used... make sure that they're initialized correctly for each system though, even if you share ~/.config/fish/ between a Mac and a Linux system and go back and forth... and it would clearly be just as much conditional as compiling it into the C code. And I can tell that you're not engineering with weird hackers on weird embedded Linux setups in mind, so this configurability would probably not be useful even for dealing with that. So, given the ttys difference -- think we should go with an env setting, or a quick fix that works for Darwin? I need to get some virtual machines set up anyway, I'll try to set up a BSD one too, to see if that breaks. . . -Dave -- Download Intel#174; Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev___ Fish-users mailing list Fish-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/fish-users
Re: [Fish-users] Fixing title setting in OS X
On 04/02/10 13:34, David Frascone wrote: So, given the ttys difference -- think we should go with an env setting, or a quick fix that works for Darwin? just use the appropriate check for ttys in the code. And make sure that you add a comment for what each string-check is checking for (e.g. Darwin terminals, Linux ptys, Linux console terminals... it's a dark area of Unix, so just be clear enough that people can go search the internet to learn more if they need to fix it or something). -- Download Intel#174; Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev ___ Fish-users mailing list Fish-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/fish-users
Re: [Fish-users] Fixing title setting in OS X
On Fri, Apr 2, 2010 at 2:17 PM, Isaac Dupree m...@isaac.cedarswampstudios.org wrote: On 04/02/10 13:34, David Frascone wrote: So, given the ttys difference -- think we should go with an env setting, or a quick fix that works for Darwin? just use the appropriate check for ttys in the code. And make sure that you add a comment for what each string-check is checking for (e.g. Darwin terminals, Linux ptys, Linux console terminals... it's a dark area of Unix, so just be clear enough that people can go search the internet to learn more if they need to fix it or something). Ok -- code done. Seems to work well on OS X. http://github.com/CodeMonk/fish/commit/e11e78dfd762b80ccd4172a740e38fee0dc2c1e0 I need to check out a linux tree from darcs and apply these changes to make sure I'm not breaking anything . . . looks much cleaner though. Since tty is a substring of ttys, there had to be a nested check, but, seems pretty obvious by the comments. (If not, let me know, and I'll be even more verbose) -Dave -- Download Intel#174; Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev___ Fish-users mailing list Fish-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/fish-users
