Ulrich Klauer wrote:
Another huge but minor patch: Change under difference licenses
into under different licenses (in 55 files).
Applied, thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com
Ulrich Klauer wrote:
README still had 1.2.1 instead of 1.3.0, and a duplicate copyright line.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev
Dagobert Michelsen wrote:
Hi Erik,
Am 07.04.2013 um 12:25 schrieb Erik de Castro Lopo mle...@mega-nerd.com:
Dagobert Michelsen wrote:
Yes, C99 is on and according to B.2.18 from
http://docs.oracle.com/cd/E19205-01/819-5265/bjapp/index.html
also casual use. What does not work
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
from gettext/iconv installations.
[1] https://raw.github.com/manphiz/patches/master/patch-flac-macosx.patch
Forgot to send to mailling list. Resend as per request by Martijn.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
Martijn van Beurden wrote:
On 26-05-13 14:20, Martijn van Beurden wrote:
On 26-05-13 11:33, Erik de Castro Lopo wrote:
Hi all,
In my latest commit I have updated all version strings and copyright
dates.
Here are two patches for the website, updating the copyright as well
Ulrich Klauer wrote:
Erik de Castro Lopo wrote:
In my latest commit I have updated all version strings and copyright
dates.
Here are some fixes to this. (Patch 2 compressed due to mailing list
size constraints.) Instead of the first patch, it would also be fine
to leave
tests.
If we can come up with a quick fix for this I'll accept it.
Cheers,
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http
the release.
-1000 for doing it before :-)
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Ulrich Klauer wrote:
Hi,
a patch for the website, to point to downloads.xiph.org for source
tarballs instead of SourceForge.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com
.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
in getting to this.
The first and the third patch were fine, but the second (Fix dead links
and update news) doesn't apply. Can you please try regenerating that
patch and resending?
Cheers,
Erik
--
--
Erik de Castro Lopo
http://www.mega
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
I meant introduced in libFLAC 1.2.0 there of course
Added. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http
through this thread and can't figure out what was
actually decided and which patch I should be looking at.
Clues?
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev
it should be in some
MSVC version dependant macro, so that new compilers don't need hacks.
Awesome, thanks.
Cheers,
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev
, and if it helps the Intel compiler, why not?
All three applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Ulrich Klauer wrote:
Erik de Castro Lopo wrote:
There is a bunch of seemingly windows related stuff in the top level
directory flac.pbproj which has not been touched since 2009.
Apparently, it is a Project Builder project, from NeXTSTEP/MacOS X.
Wikipedia says it was an IDE
into this. However,
these results still show that there hasn't been a (severe) regression in
performance on linux.
Awesome, thanks!
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
of the patches, I only did the
rebasing (which was trivial).
Thanks Ulrich. Applied.
Cheers,
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
there are
prettier solutions however?
Lets see the patch first and then see if we can make it prettier.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing
Martijn van Beurden wrote:
Sorry, I'm making a big mess of this. Please ignore the previous one. I
used set -x instead of set -e
On 25-04-13 15:25, Martijn van Beurden wrote:
On 25-04-13 11:38, Erik de Castro Lopo wrote:
Lets see the patch first and then see if we can make it prettier
at that more closely after I've figured out the lshift issue.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org
Else'
issue:
https://en.wikipedia.org/wiki/Dangling_else
Anyway, fixed now.
Cheers,
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
Martijn van Beurden wrote:
On 24-04-13 14:34, Erik de Castro Lopo wrote:
That's an error in the awk script, which is embedded in the shell
script. I know GNU awk supports lshift, maybe BSD awk doesn't. I'll
investigate that futher.
On my system awk links to mawk 1.3.3
Yep fails
Erik de Castro Lopo wrote:
Martijn van Beurden wrote:
On 24-04-13 14:34, Erik de Castro Lopo wrote:
That's an error in the awk script, which is embedded in the shell
script. I know GNU awk supports lshift, maybe BSD awk doesn't. I'll
investigate that futher.
On my system awk
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Martijn van Beurden wrote:
This patch fixes the issue mentioned below.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev
is maximum. Patch attached.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac
. Thanks!
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Cristian Rodríguez wrote:
---
src/libFLAC++/Makefile.am | 2 +-
src/libFLAC/Makefile.am | 2 +-
src/metaflac/Makefile.am | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
Applied. Thanks.
Erik
--
--
Erik de
isn't using C-locale.
At least it did so for all locales I tried (Finnish, German, English US).
Applied, with the change from 0x32 to 32. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com
Martijn van Beurden wrote:
I just saw I forgot to fix the feed on the news page. Here's a patch for
that one as well.
All four patches applied and pushed. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com
and it compiled
nicely. This is current git (2de567f), all tests passed after this small
change.
Fixed in git HEAD. Thanks for the problem report.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Hi all,
Sorry for the delay in responding to patches etc. Insanely busy until
the weekend. Will deal with incoming then.
Cheers,
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
regarding overlinking in case anyone
is wondering: http://wiki.mandriva.com/en/Overlinking
Applied! Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev
again.
From my reading the ISO C99 spec, this code should compile with a C99
compliant compiler.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Erik de Castro Lopo wrote:
decode.c: In function ‘write_callback’:
decode.c:965:28: warning: cast increases required alignment of target
type [-Wcast-align]
decode.c:966:28: warning: cast increases required alignment of target
type [-Wcast-align]
decode.c:967:28: warning: cast
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
it won't make it into the release.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
LRN wrote:
flac-1.3.0pre3/include/share/compat.h:146:31: fatal error:
share/win_utf8_io.h: No such file or directory
Add that to EXTRA_DIST in include/share/Makefile.am.
Thanks.
Erik
--
--
Erik de Castro Lopo
http
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
functions that
didn't get utf-8 decoding
msvc_flac_version: changes versions number from 1.3.0pre2 to 1.3.0pre3
compat_h_msvc_fix: fixes compiling on MSVC
Applied, thanks!
Erik
--
--
Erik de Castro Lopo
http://www.mega
Erik de Castro Lopo wrote:
I need someone which can use git and the MinGW compiler on windows to
test something for me. Specifically, this:
Thanks to Janne Hyvärinen for running these tests.
We have come to the conclusion that the bug is in Wine, not in FLAC.
When cross-compiling from Linux
be using flac_stat_
instead.
d) Would be nice to reduce the #ifdef hackery.
I'll have a look at this some more and probably hack the above myself.
Then I'm commit it and get you to check it.
Cheers,
Erik
--
--
Erik de Castro Lopo
, I'm getting this too.
On the list of things to fix before the release :-).
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http
+%N) conversion after Jaren's
POSIX patches were all applied.
Cheers,
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http
released :-).
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Janne Hyvärinen wrote:
Here's a patch that fixes WAVE64 format handling. GUID had one word
incorrectly in little endian order.
Applied, thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com
Erik de Castro Lopo wrote:
Hi all,
There are a bunch of sprintf calls in the FLAC code base and I'd like
to replace them with calls to snprintf but I know that can cause
problems with at least some versions of Visual Studio.
Whats the current state of play in this regard?
Does MSVS have
Erik de Castro Lopo wrote:
Does MSVS have stdarg.h?
Hmm, seems to:
http://msdn.microsoft.com/en-us/library/kb57fad8%28v=vs.80%29.aspx
Hope it works as expected.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com
the defines? This way, it should support
mingw builds too.
+1
I'd like to see some way to do this to:
a) Make this usable from MinGW compiled binaries.
b) Reduce the the amount of inline #ifdef hackery.
Cheers,
Erik
--
--
Erik de
Janne Hyvärinen wrote:
Patch for snprintf stuff.
Applied and pushed.
Thats it for me tonight.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
been
long gone.
LibFLAC_dynamic was complaining in debug mode about conflicts with
libcmt, I excluded it from the project there as I saw no other way to
solve the problem.
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http
replaced all the old
calls to sprintf/_snprintf.
Cheers,
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
Janne Hyvärinen wrote:
On 14.3.2013 9:37, Erik de Castro Lopo wrote:
Janne Hyvärinen wrote:
The patch was made from the published pre2 version. It missed the MinGW
changes that were applied to git version.
Patch applied. Thanks.
Erik
Unfortunately with this commit the LRN's
the std
behaviour as stated at e.g. http://linux.die.net/man/3/snprintf
Yes, now I remember, that one is horribly broken.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com
the best way to avoid this is wrap both inside a flac specific
API and only use the flac specific version.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing
in src/flac/main.c that was easy and
obvious to fix, the other in include/share/compat.h. Can you please
send your version of that file?
Thanks,
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com
review and test before committing.
Thanks!
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo
, this is a good compromise. I improved the comments slightly
as well.
Cheers,
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http
.
Cheersm
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
don't make our problem any worse.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
will
have to avoid touchng anything in the directories:
include/FLAC
include/FLAC++
as these are the public API headers and we don't want to change the API
in this release.
Cheers,
Erik
--
--
Erik de Castro Lopo
http://www.mega
Erik de Castro Lopo wrote:
JonY wrote:
Please do a link time test instead, I am not getting this error and
would like to keep stack protector on.
I'll write an m4 macro.
I have attampted to write a macro that reliably detects the availability
of stack smash protection.
I currently
metadata_object.o
CXXLDtest_libFLAC++
/usr/home/erikd/flac/src/libFLAC/.libs/libFLAC.so: undefined reference to
`__stack_chk_fail_local'
*** [test_libFLAC++] Error code 1
Erik
--
--
Erik de Castro Lopo
http
,
that simply should not be necessary. I suggest this is an error in the
Visual Studio project files.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev
JonY wrote:
Please do a link time test instead, I am not getting this error and
would like to keep stack protector on.
I'll write an m4 macro.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com
Martijn van Beurden wrote:
On 09-03-13 01:01, Erik de Castro Lopo wrote:
I would like to know how many years I have to wait before we can ditch
this stuff. I intend to do some testing on platforms I have available
today and roll a second pre-release after my testing.
Talking about
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
LRN wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09.03.2013 15:37, Erik de Castro Lopo wrote:
Hi all,
Second and hopefully final pre-release is here:
http://downloads.xiph.org/releases/flac/beta/
src/libFLAC/metadata_iterators.c:442:4: warning: implicit declaration
Ben Allison wrote:
This should be enough to fix it
Applied, thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http
should supply something
suitable. Here's the commit:
commit c506b2f43e2fadd70141322c774bc196c2c65cc3
Author: Erik de Castro Lopo er...@mega-nerd.com
Date: Fri Feb 10 19:19:11 2012 +1100
include/FLAC/ordinals.h : Remove CPP hackery.
This change assumes that a C99
Erik de Castro Lopo wrote:
LRN wrote:
I've sent a utf-8 support patch to flac-dev, but it didn't arrive. The
patch file is around 64k, so i believe that this is the problem. Maybe
i should compress it?
Maybe send it directly to me, erikd at my usual domain name.
I have LRN's patch
(const
FLAC__Metadata_SimpleIterator *iterator);
That needs to be fixed.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
patches)
but that makes the code better and should eventually get the code
into flac.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
libFLAC, because I'm not as familiar with the rest of the
codebase. But I will make another pass today with the other library and
binaries.
Great, thanks!
Cheers,
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
this current release.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
nu774 wrote:
(2013/03/05 7:19), Erik de Castro Lopo wrote:
Err, thats a link to a post talking about flac's WAV reader being limited
to 4Gig files. Problem is, *all* WAV files greater than 4Gig are mal-formed.
Due to limitations in the way WAV files are specified, no valid WAV file
can
and flac
basically uses off_t everywhere for seek offset and file size.
This requires an API change and hence is something that will need to
wait for the next release.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com
Cristian Rodríguez wrote:
On 03/05/2013 03:32 AM, Erik de Castro Lopo wrote:
May look at CMake after this current release.
That will make the situation reverse, that is, better for windows,
insane for the rest of the world.
*If* I get around to it, it will be in a branch
changelog is available here:
https://git.xiph.org/?p=flac.git;a=summary
or in any git clone of this repo.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing
it on a daily basis (as I know you've experienced with libsndfile, Erik).
Yes, painfully aware of this. I'll be relying on others to keep the VS
project files up-to-date.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com
in MSVC? I know it
works for GCC and Clang as its required for C99.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http
501 - 600 of 802 matches
Mail list logo
