[flac-dev] [GIT PULL] Assorted bugfixes and improvements (from openSUSE)

2012-03-29 Thread Cristian Rodríguez
for you to fetch changes up to 3a060556772c5d6a6464afddfda7c3ad2f93a306: Remove winamp2 plugin. (2012-03-29 13:51:24 -0300) Cristian Rodríguez (4): Use a single source-code wide definition of min() and max() Support

Re: [flac-dev] [GIT PULL] Assorted bugfixes and improvements (from openSUSE)

2012-03-29 Thread Cristian Rodríguez
El 29/03/12 14:32, Cristian Rodríguez escribió: The following changes since commit b78d8e4db10e57b8d82bb82e4e3662d5dedd7255: FLAC__bitmath_ilog2,FLAC__bitmath_ilog2_wide,COUNT_ZERO_MSBS: add gcc specific optimizations (2012-03-28 15:43:48 -0300) are available in the git repository at: git

Re: [flac-dev] [GIT PULL] Assorted bugfixes and improvements (from openSUSE)

2012-03-30 Thread Cristian Rodríguez
El 30/03/12 07:14, Erik de Castro Lopo escribió: * 7077ba8be2.. Use a single source-code wide definition of min() and max() I like the idea of this commit but don't understand why it modifies configure.ac. I also don't think the FLAC_SAFE_MIN/MAX defintions belong in the file

Re: [flac-dev] [GIT PULL] Assorted bugfixes and improvements (from openSUSE)

2012-03-30 Thread Cristian Rodríguez
El 30/03/12 07:14, Erik de Castro Lopo escribió: Cristian Rodríguez wrote: The following changes since commit b78d8e4db10e57b8d82bb82e4e3662d5dedd7255: FLAC__bitmath_ilog2,FLAC__bitmath_ilog2_wide,COUNT_ZERO_MSBS: add gcc specific optimizations (2012-03-28 15:43:48 -0300) are available

[flac-dev] [PATCH] Fix buffer overflow in metaflac

2012-04-04 Thread Cristian Rodríguez
strlen() returns the length excluding the terminating null byte..then an string of len 4 will be off-by-one in application_id[4]; GCC 4.7 detects this bug. --- src/metaflac/options.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/metaflac/options.c

[flac-dev] [PATCH] remove unnecesary typedef in bitwriter.c

2012-04-05 Thread Cristian Rodríguez
--- src/libFLAC/bitwriter.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/src/libFLAC/bitwriter.c b/src/libFLAC/bitwriter.c index 651440d..7da4b15 100644 --- a/src/libFLAC/bitwriter.c +++ b/src/libFLAC/bitwriter.c @@ -43,12 +43,11 @@ /*

[flac-dev] [PATCH 2/2] V2: Use a single definition of MIN and MAX in sources

2012-04-05 Thread Cristian Rodríguez
--- configure.ac |7 + src/libFLAC/bitreader.c | 12 ++--- src/libFLAC/bitwriter.c |8 ++ src/libFLAC/fixed.c | 18 + src/libFLAC/format.c |8 ++

Re: [flac-dev] [PATCH] Fix buffer overflow in metaflac

2012-04-05 Thread Cristian Rodríguez
El 05/04/12 18:30, Brian Willoughby escribió: Agreed. I was going to suggest memcpy() or something equivalent, because the FLAC structure is not literally a C string, but rather a 32-bit field that may or may not have a terminating NULL. Erik's code should work correctly in all cases. Yep,

[flac-dev] [PATCH 2/2] Update and improve autotools build

2012-04-07 Thread Cristian Rodríguez
- INCLUDES is deprecated, and CPPFLAGS is an user-defined variable, use the proper AM_CPPFLAGS instead - Remove FLAC__INLINE definition, providing proper replacement for MSVC compilers. - Detect if we have C99 's lround and provide a replacement for windows... --- configure.ac

Re: [flac-dev] Where is configure

2012-04-09 Thread Cristian Rodríguez
On 09/04/12 22:50, Danpoleary wrote: Hello, I downloaded the complete src from cvs. and as normal, I try to run ./configure, but it does not exist. All the documentation talks about it, but it is nowhere to be found. Was it removed from src? no, It is just that autogenerated files do not

Re: [flac-dev] Where is configure

2012-04-10 Thread Cristian Rodríguez
El 10/04/12 02:02, Ralph Giles escribió: On 9 April 2012 18:50, Danpolearydanpole...@netscape.net wrote: I downloaded the complete src from cvs. and as normal, I try to run ./configure, but it does not exist. All the documentation talks about it, but it is nowhere to be found. Also please

Re: [flac-dev] remove src/libFLAC/ia32 permanently?

2012-04-12 Thread Cristian Rodríguez
El 12/04/12 22:55, Ben Allison escribió: No. It is much faster, measurably. Anyone who believes the old adage that compilers outperform humans isn't writing math code or is just a lousy assembly programmer. In which system/compiler did you tried it ?

[flac-dev] [PATCH] Remove local_strtoull, windows has equivalent function _strtoui64

2012-04-17 Thread Cristian Rodríguez
--- include/share/compat.h|8 src/flac/main.c | 37 + src/share/grabbag/seektable.c | 31 +-- 3 files changed, 10 insertions(+), 66 deletions(-) diff --git a/include/share/compat.h

[flac-dev] [PATCH 2/2] replace local_strtoull with _strtoui64 in windows

2012-04-17 Thread Cristian Rodríguez
Previous patch replaced the other local_strtoll with _strtoi64 --- include/share/compat.h |3 ++- src/metaflac/options.c | 23 +-- 2 files changed, 3 insertions(+), 23 deletions(-) diff --git a/include/share/compat.h b/include/share/compat.h index ff5c8af..8ad3698

[flac-dev] [PATCH 3/3] export MALLOC_PERTURB_ and MALLOC_CHECK_ in test suite

2012-04-17 Thread Cristian Rodríguez
That enables an special implementation that checks for common memory errors and will save us from a lot pain. --- test/test_bins.sh |2 ++ test/test_flac.sh |2 ++ test/test_grabbag.sh |2 ++ test/test_libFLAC++.sh |2 ++ test/test_libFLAC.sh |3 +++

Re: [flac-dev] [PATCH 3/3] export MALLOC_PERTURB_ and MALLOC_CHECK_ in test suite

2012-04-18 Thread Cristian Rodríguez
On 18/04/12 09:08, Erik de Castro Lopo wrote: Cristian Rodríguez wrote: That enables an special implementation that checks for common memory errors and will save us from a lot pain. --- test/test_bins.sh |2 ++ test/test_flac.sh |2 ++ test/test_grabbag.sh |2

Re: [flac-dev] [Flac-dev] Git branch with compiling fixes for win32

2012-05-04 Thread Cristian Rodríguez
El 03/05/12 12:19, Miroslav Lichvar escribió: Hi Josh, nice to see you here again. On Wed, Apr 25, 2012 at 04:26:05PM -0700, Josh Coalson wrote: (Jumping in again, maybe at the wrong point since this doesn't seem to involve encoding, but here goes.) Miroslav's patches have always been

Re: [flac-dev] [Flac-dev] Git branch with compiling fixes for win32

2012-05-04 Thread Cristian Rodríguez
El 03/05/12 12:19, Miroslav Lichvar escribió: It makes the C function faster than the corresponding asm routine, so if it's included I'd suggest to just drop the asm function to not keep around more asm code than is necessary. With current compilers it is very likely that those routines are

Re: [flac-dev] [Flac-dev] Git branch with compiling fixes for win32

2012-05-04 Thread Cristian Rodríguez
El 04/05/12 11:53, Miroslav Lichvar escribió: On Fri, May 04, 2012 at 11:13:05AM -0400, Cristian Rodríguez wrote: Both Erick and I did already submitted patches to the tree that do just exactly what your flac-1.2.1-bitreader.patch intended.. please checkout current GIT tree. The most

Re: [flac-dev] [Flac-dev] Git branch with compiling fixes for win32

2012-05-04 Thread Cristian Rodríguez
El 04/05/12 12:09, Miroslav Lichvar escribió: On Fri, May 04, 2012 at 05:53:23PM +0200, Miroslav Lichvar wrote: The most interesting part of the patch is the rewrite of the FLAC__bitreader_read_rice_signed_block function, which in the git repo seems to have only couple lines changed since

[flac-dev] [PATCH] Optionally, allow distros to use openssl for MD5 verification

2012-05-05 Thread Cristian Rodríguez
This has the advantage of being more efficient than the included routines and allows distros to centralize crypto mainteniance on a few libraries. --- configure.ac |4 +- m4/ax_check_openssl.m4| 124 +

Re: [flac-dev] [PATCH] Add missing functions to SeekTable class

2012-05-06 Thread Cristian Rodríguez
El 06/05/12 19:18, Josh Coalson escribió: From: Cristian Rodríguezcrrodrig...@opensuse.org Sent: Sunday, May 6, 2012 8:24 AM El 05/05/12 02:23, Bastiaan Timmer escribió: The attached patch adds the missing FLAC__metadata_object_seektable_*() functions from FLAC's metadata object methods

Re: [flac-dev] [Flac-dev] Git branch with compiling fixes for win32

2012-05-07 Thread Cristian Rodríguez
and it seems decoding is a tiny bit faster than with the git version. Unfortunately I don't recall the details. On Mon, May 07, 2012 at 01:23:03PM -0400, Cristian Rodríguez wrote: Did you build with -fprofile-generate ... then make check .. then rebuild with -fprofile-use ? No, I have not tried

Re: [flac-dev] [PATCH] Optionally, allow distros to use openssl for MD5 verification

2012-05-07 Thread Cristian Rodríguez
El 07/05/12 16:19, Eric Wong escribió: flac and metaflac do not use openSSL, only libFLAC does. But since flac/metaflac use libFLAC, I suspect (IANAL) the relationship can be transitive. (But being an optional dependency helps as distros can avoid potential issues). That's why it is

Re: [flac-dev] [PATCH] Add missing functions to VorbisComment class + a few other things

2012-05-07 Thread Cristian Rodríguez
El 07/05/12 17:02, Bastiaan Timmer escribió: Attached is a patch that adds 5 missing FLAC__metadata_object_vorbiscomment_* functions to the VorbisComment class. In my previous message I stated 8 functions were missing, but on closer inspection, 3 of those belong in the VorbisComment::Entry

[flac-dev] [PATCH 2/2] bitmath: Finish up optimizations

2012-05-08 Thread Cristian Rodríguez
This patch adds support for other compilers and systems including MSVC, Intel C compiler etc.. --- src/libFLAC/bitmath.c | 48 - src/libFLAC/bitreader.c | 54 ++- src/libFLAC/include/private/bitmath.h | 120

Re: [flac-dev] Patch for cross compilation with MinGW32

2012-07-01 Thread Cristian Rodríguez
El 23/06/12 22:23, Christoph Terasa escribió: Hello, I had some difficulties compiling the current git ( http://git.xiph.org/?p=flac.git;a=commit;h=a7e3705d051bafd1cae90f6605287cc1d9f2a18d ) using the Ubuntu 12.04 supplied MinGW32 cross compiler: I configured the FLAC build with

Re: [flac-dev] Shared library won't build when cross-compiling.

2012-12-12 Thread Cristian Rodríguez
El 22/08/12 04:03, Nathan Osman escribió: I'm having trouble cross-compiling FLAC for Windows from Linux. I am using the following commands: ./configure --host=i686-w64-mingw32 --prefix=/usr/i686-w64-mingw32 --enable-shared make The process completes successfully but I only end up with

Re: [flac-dev] Commonly getting FLAC__STREAM_ENCODER_VERIFY_MISMATCH_IN_AUDIO_DATA on valid audio

2013-02-07 Thread Cristian Rodríguez
El 07/02/13 19:07, Collin escribió: I'm using libflac on Windows to compress some audio samples. I'm building the library locally, using Visual Studio 2010. Each set of data is 2-5 MB and well formed PCM encoded data. I'm finding some very odd behavior. If I enable verify on the encode

Re: [flac-dev] flac 1.3.0pre1 prelease

2013-03-02 Thread Cristian Rodríguez
El 02/03/13 20:22, Erik de Castro Lopo escribió: Hi all, I finally managed to bite the bullet and roll a pre-release. Its here: http://downloads.xiph.org/releases/flac/beta/ I have personally tested this code on: x86-linux x86_64-linux powerpc-linux armv7 little

Re: [flac-dev] 2GB limit patch

2013-03-04 Thread Cristian Rodríguez
On 03/04/2013 10:57 PM, nu774 wrote: This is an older issue reported in 2007: http://lists.xiph.org/pipermail/flac-dev/2007-September/002423.html The fix would be to use _ftelli64 instead of ftell with Visual Studio. http://msdn.microsoft.com/en-us/library/0ys3hc0b%28v=vs.110%29.aspx That's

Re: [flac-dev] flac 1.3.0pre1 prelease

2013-03-04 Thread Cristian Rodríguez
On 03/04/2013 07:36 PM, Erik de Castro Lopo wrote: Martijn van Beurden wrote: 'chown', declared with attribute warn_unused_result [-Wunused-result] metadata_iterators.c:3299:2: warning: ignoring return value of 'chown', declared with attribute warn_unused_result [-Wunused-result] In file

Re: [flac-dev] Fwd: flac 1.3.0pre1 prelease

2013-03-04 Thread Cristian Rodríguez
On 03/05/2013 03:32 AM, Erik de Castro Lopo wrote: May look at CMake after this current release. That will make the situation reverse, that is, better for windows, insane for the rest of the world. ___ flac-dev mailing list flac-dev@xiph.org

Re: [flac-dev] Real-world tests (commit 300d17c)

2013-03-13 Thread Cristian Rodríguez
El 13/03/13 10:50, Martijn van Beurden escribió: but decompression is about 15% faster. Cool, just wondering though.. it says The machine used for running the test has an Intel Core2Duo T9600 with 4GB of RAM and is using Kubuntu 12.10. .. is the OS in 64 bit mode ? which CFLAGS where used

[flac-dev] [PATCH] Ensure AM_LDFLAGS is used consistently

2013-04-18 Thread Cristian Rodríguez
--- src/libFLAC++/Makefile.am | 2 +- src/libFLAC/Makefile.am | 2 +- src/metaflac/Makefile.am | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libFLAC++/Makefile.am b/src/libFLAC++/Makefile.am index 6bd1657..12dfe69 100644 --- a/src/libFLAC++/Makefile.am +++

Re: [flac-dev] (no subject)

2013-05-01 Thread Cristian Rodríguez
On 05/01/2013 06:47 PM, Marcus Johnson wrote: One last thing, Xcode complains about the .nasm files when compiling for x64, I don't know too much about assembly, can x86 assembly be compiled on x64 at all? the assembly code in flac in x86_32 only.

[flac-dev] [PATCH] Add missing config.h includes

2013-05-31 Thread Cristian Rodríguez
All C and C++ files must include config.h --- src/libFLAC++/metadata.cpp | 4 src/libFLAC++/stream_decoder.cpp | 4 src/libFLAC++/stream_encoder.cpp | 4 src/plugin_xmms/charset.c | 4 src/plugin_xmms/configure.c| 4

[flac-dev] [PATCH] Link with -no-undefined regardless of the OS

2013-07-20 Thread Cristian Rodríguez
libFLAC* must never have undefined symbols no matter what is the target platform. --- configure.ac | 10 +- src/libFLAC++/Makefile.am | 2 +- src/libFLAC/Makefile.am | 2 +- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index