[flashrom] Re: [GSoC 2022] Restructure Shutdown Function

2022-04-13 Thread Anastasia Klimchuk
> Due to current circumstances, Google isn't accepting participants from > the country where I'm currently located. So, I can't take part in GSOC 2022. > But I am still interested in participating in flashrom and this project. > What should I do now? Send small patches and study the code until

[flashrom] Re: [GSoC 2022] Restructure Shutdown Function

2022-04-10 Thread Thomas Heijligen
Hi Joursoir, On Sun, 2022-04-10 at 14:41 +0300, Joursoir wrote: > Hello Thomas and Anastasia, > > Due to current circumstances, Google isn't accepting participants > from > the country where I'm currently located. So, I can't take part in > GSOC 2022. > But I am still interested in participating

[flashrom] Re: [GSoC 2022] Restructure Shutdown Function

2022-04-10 Thread Joursoir
Hello Thomas and Anastasia, Due to current circumstances, Google isn't accepting participants from the country where I'm currently located. So, I can't take part in GSOC 2022. But I am still interested in participating in flashrom and this project. What should I do now? Send small patches and

[flashrom] Re: [GSoC 2022] Restructure Shutdown Function

2022-04-09 Thread Anastasia Klimchuk
Hi Joursoir, Sorry for some delay, I wanted to respond more to the topic and finally found time :) > As I understood, they use the following approaches: > > 1. Register a callback by its own > > if (register_shutdown(serprog_shutdown, NULL)) > goto init_err_cleanup_exit; > > 2. Fill `struct

[flashrom] Re: [GSoC 2022] Restructure Shutdown Function

2022-04-05 Thread Thomas Heijligen
Hi Joursoir, On Mon, 2022-04-04 at 14:57 +0300, Joursoir wrote: > Hello Thomas, > > No problem, thanks for your reply. I have one more question. I have > noticed > that some programmers already have their own context (for example > pony_spi.c, > rayer_spi.c. serprog.c, dediprog.c and others). I

[flashrom] Re: [GSoC 2022] Restructure Shutdown Function

2022-04-05 Thread Thomas Heijligen
Hi Joursoir On Fri, 2022-04-01 at 22:43 +0300, Joursoir wrote: > Hello Thomas, > > I went ahead and started looking into shutdown functions.  Gread that you've already looked so deep into the problem. Over that, plese don't forget the other importent tasks at https://www.flashrom.org/GSoC to

[flashrom] Re: [GSoC 2022] Restructure Shutdown Function

2022-04-04 Thread Joursoir
Hello Thomas, No problem, thanks for your reply. I have one more question. I have noticed that some programmers already have their own context (for example pony_spi.c, rayer_spi.c. serprog.c, dediprog.c and others). I note that they are all SPI. As I understood, they use the following approaches:

[flashrom] Re: [GSoC 2022] Restructure Shutdown Function

2022-04-02 Thread Thomas Heijligen
Hi Joursoir, I'm going to reply to your questions on Monday. Sorry for the delay, I'm currently not in reach of my Computer and want to look a few things up before answering. -- Thomas On 1 April 2022 20:43:10 WEST, Joursoir wrote: >Hello Thomas, > >I went ahead and started looking into

[flashrom] Re: [GSoC 2022] Restructure Shutdown Function

2022-04-01 Thread Joursoir
Hello Thomas, I went ahead and started looking into shutdown functions. Almost of them use global variables, but I already have ideas on how to rewrite it. Now I start coding a prototype and want to implement struct example_data. But I have run into a problem with its initialization: 1) In

[flashrom] Re: [GSoC 2022] Restructure Shutdown Function

2022-03-19 Thread Thomas Heijligen
Hi Joursoir, Beside the internal programmer, most programmer manipulate only a few things, so it is not that much. A data struct for each programmer should be used to store the context of the programmer instead of setting global variables. This gives the programmer a defined lifecycle . The

[flashrom] Re: [GSoC 2022] Restructure Shutdown Function

2022-03-19 Thread Joursoir
Hello Thomas and Anastasia, Thank you for the quick answer. Now I understand the idea of the project more correctly. It really will be great if programmers have their own shutdown functions. In your example you have used pci_write_*(), but the real flashrom code uses only rpci_write_* (it

[flashrom] Re: [GSoC 2022] Restructure Shutdown Function

2022-03-18 Thread Anastasia Klimchuk
Hello Joursoir, Nice to have you very interested in flashrom! One thing I wanted to say: it would be great to include the mailing list if you have discussions about the project. That would mean the community can join and potentially help too, and this is really useful. Thomas, thank you so much

[flashrom] Re: [GSoC 2022] Restructure Shutdown Function

2022-03-18 Thread Thomas Heijligen
Hi Joursoir, The idea for the "Restructure Shutdown Functions" project is to extend the struct programmer_entry with a function to handle programmer related shutdowns. Currently, the init function of each programmer calls, mostly indirect, register_shutdown on each item separately to handle its