Hi Anastasia,
On 16.05.22 07:15, Anastasia Klimchuk wrote:
> I am also not a native English speaker, and need to always concentrate
> on the language. Sometimes I can't understand the person who has just
> spoken, in this case I am trying to clarify for example by asking "do
> I understand you
Hello,
I am also not a native English speaker, and need to always concentrate
on the language. Sometimes I can't understand the person who has just
spoken, in this case I am trying to clarify for example by asking "do
I understand you correctly, do you mean ABCXYZ?". Also I remember a
few times
Hello Everyone,
First of all let's summarize what has happened. Today is May 12.
Two months ago (Mar 6) Nico started this thread on the mailing list:
"Gatekeeping, ACLs and Review Rules". I recommend everyone [who is
interested] re-read the opening email in this thread. It is well
written,
I am not going to comment on most things of your email, because I think
the discussion would be going nowhere. Also, you should know my answer
for some things. So there is no point for me in replying.
Just one thing..
On Mon, 2022-05-09 at 14:19 +0200, Nico Huber wrote:
> > > I would prefer if
On 09.05.22 06:31, Felix Singer wrote:
> On Sat, 2022-05-07 at 14:39 +0200, Nico Huber wrote:
>> On 06.05.22 03:52, Anastasia Klimchuk wrote:
>>> There are several questions raised in this thread, but good news is
>>> that at the meeting yesterday one of the questions was decided on!
>>>
>>> We
On Sat, 2022-05-07 at 14:39 +0200, Nico Huber wrote:
> On 06.05.22 03:52, Anastasia Klimchuk wrote:
> > There are several questions raised in this thread, but good news is
> > that at the meeting yesterday one of the questions was decided on!
> >
> > We decided to have a Reviewers group for
On 06.05.22 03:52, Anastasia Klimchuk wrote:
> There are several questions raised in this thread, but good news is
> that at the meeting yesterday one of the questions was decided on!
>
> We decided to have a Reviewers group for flashrom.
Technically the attendees agreed on it. Which is a kind of
There are several questions raised in this thread, but good news is
that at the meeting yesterday one of the questions was decided on!
We decided to have a Reviewers group for flashrom.
Martin, can we ask you to help with creating a group? If you could
help that would be great!
Initial content
Hello!
> and I vote 100% against it. FWIW, this feature wakes our worst in-
> stincts. No matter how convinced we are that review is also for our
> own good, getting a commit merged always feels rewarding. And many
> people act like it's a necessity to set the resolved tick to gain
> that reward.
Hi Anastasia,
On 17.03.22 12:32, Anastasia Klimchuk wrote:
>> For example, the flashrom project doesn't require that all comments
>> be resolved before merge. That can be enabled if you'd like, but currently
>> it isn't.
>
> Oh this explains! I was wondering where those “patches merged with
>
“For example, the flashrom project doesn't require that all comments
be resolved before merge. That can be enabled if you'd like, but currently
it
isn't.”
Oh this explains! I was wondering where those “patches merged with
unresolved comments” are coming from. I am 100% voting for this setting to
> I've noticed something related in reviews over the years, though. Some-
> times when reviewers give a lot of comments on Gerrit, among them some
> critical ones about the overall patch and a lot of nits, the author
> tends to fix the nits and ignore the critical comments. Sure, when
> somebody
On 12.03.22 08:57, Anastasia Klimchuk wrote:
>> The big difference seems to be that at coreboot mergingpatches, i.e.
>> hitting the "Submit" button, is more or less consideredan administrative
>> task unrelated to one's opinion on the code. Whilefor us it was supposed to
>> replace the
Hi Anastasia, Martin,
many thanks for your thoughts on the matter. \o/
On 12.03.22 22:29, Martin L Roth wrote:
> On Sat, Mar 12, 2022 at 12:57 AM Anastasia Klimchuk wrote:
> ...
> On Sat, Mar 5, 2022 at 9:17 AM Nico Huber wrote:
> ...
>>> “The big difference seems to be that at coreboot
On Sat, Mar 12, 2022 at 12:57 AM Anastasia Klimchuk wrote:
...
On Sat, Mar 5, 2022 at 9:17 AM Nico Huber wrote:
...
>> “The big difference seems to be that at coreboot merging
>> patches, i.e. hitting the "Submit" button, is more or less considered
>> an administrative task unrelated to one's
Nico, and everyone,
Thanks for many details, and for historical information, always interesting
for me to read :)
*“The big difference seems to be that at coreboot mergingpatches, i.e.
hitting the "Submit" button, is more or less consideredan administrative
task unrelated to one's opinion
16 matches
Mail list logo
