Re: [Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-26 Thread Frederic Bouvier
Melchior FRANZ a écrit : > * Frederic Bouvier -- Sunday 26 February 2006 12:10: > >> Olaf Flebbe wrote : >> >>> 1) I do not understand lines like that >>> >>> #ifdef HAVE_CONFIG_H >>> # include >>> #endif >>> >>> in Simgear (math/sg_geometry.h) since the config file from Simgear is >>>

[Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-26 Thread Melchior FRANZ
* Frederic Bouvier -- Sunday 26 February 2006 12:10: > Olaf Flebbe wrote : > > 1) I do not understand lines like that > > > > #ifdef HAVE_CONFIG_H > > # include > > #endif > > > > in Simgear (math/sg_geometry.h) since the config file from Simgear is > > simgear_config.h > That's why putting th

Re: [Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-26 Thread Frederic Bouvier
Olaf Flebbe wrote : > Hi, > > Sorry about the late comment: > > 1) I do not understand lines like that > > #ifdef HAVE_CONFIG_H > # include > #endif > > in Simgear (math/sg_geometry.h) since the config file from Simgear is > simgear_config.h > > 2) The pthread-win32 library, needed for Windos d

Re: [Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-25 Thread Olaf Flebbe
Hi,Sorry about the late comment:1) I do not understand lines like that#ifdef HAVE_CONFIG_H  #  include  #endifin Simgear (math/sg_geometry.h) since the config file from Simgear is simgear_config.h 2) The pthread-win32 library, needed for Windos do contain the same thre lines of code.#ifdef HAVE_CO

[Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-18 Thread Ima Sudonim
What build system? Only the autotools do. The autotools are just a handy tool for the UNIX crowd. This isn't multiplatform (what FGFS tries to achieve). ..this does work on cygwin etc on Wintendo too??? I build on CygWin with autotools. I build on Mac OS X with autotools, others use the

Re: [Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-18 Thread Arnt Karlsen
On Sat, 18 Feb 2006 17:27:13 +0100, Christian wrote in message <[EMAIL PROTECTED]>: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Melchior FRANZ schrieb: > > * Frederic Bouvier -- Saturday 18 February 2006 17:05: > >> fgrun and fgadmin haven't any config.h under MSVC. And I don't know >

[Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-18 Thread Ima Sudonim
Frederic Bouvier wrote: > Melchior FRANZ wrote: > > Why the #ifdef? Is there a reasonable case where CONFIG_H is *not* > > available? > > It has always been the practice to enclose #include by > #ifdef HAVE_CONFIG_H from the beginning of autoconf/automake. That's not really an answer to the ques

Re: [Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-18 Thread Andy Ross
Christian Mayer wrote: > So to stay portable it's a must - you are including a file that does > not exist otherwise. Again: just stub out an empty config.h and check it in. Will this not work on MSVC for some reason? Note that all other platforms are Unix and use autotools, MSVC is the only one

Re: [Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-18 Thread Andy Ross
Mathias Frölich wrote: > Because that is the way automake is supposed to work. You can > either include all defines autoconf generates in the compilers > commandline, then HAVE_CONFIG_H is not defined or autoconf puts the > defines into config.h and defines HAVE_CONFIG_H ... What's wrong with jus

Re: [Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-18 Thread Frederic Bouvier
Andy Ross wrote : > Frederic Bouvier wrote: > >> Melchior FRANZ wrote: >> >>> Why the #ifdef? Is there a reasonable case where CONFIG_H is *not* >>> available? >>> >> It has always been the practice to enclose #include by >> #ifdef HAVE_CONFIG_H from the beginning of autoconf/automa

Re: [Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-18 Thread Andy Ross
Frederic Bouvier wrote: > Melchior FRANZ wrote: > > Why the #ifdef? Is there a reasonable case where CONFIG_H is *not* > > available? > > It has always been the practice to enclose #include by > #ifdef HAVE_CONFIG_H from the beginning of autoconf/automake. That's not really an answer to the quest

Re: [Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-18 Thread Christian Mayer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Melchior FRANZ schrieb: > * Frederic Bouvier -- Saturday 18 February 2006 17:05: >> fgrun and fgadmin haven't any config.h under MSVC. And I don't know >> about Mac or another potential, non unix, system. > > OK. But most likely because the build syst

[Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-18 Thread Melchior FRANZ
* Mathias Fröhlich -- Saturday 18 February 2006 17:18: > On Saturday 18 February 2006 17:13, Melchior FRANZ wrote: > > so why ask if it's there? > You can either include all defines autoconf generates in the compilers > commandline, then HAVE_CONFIG_H is not defined or autoconf puts the defines

Re: [Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-18 Thread Frederic Bouvier
Melchior FRANZ a écrit : > * Frederic Bouvier -- Saturday 18 February 2006 17:05: > >> fgrun and fgadmin haven't any config.h under MSVC. And I don't know >> about Mac or another potential, non unix, system. >> > > OK. But most likely because the build system doesn't generate > them. Flight

Re: [Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-18 Thread Mathias Fröhlich
On Saturday 18 February 2006 17:13, Melchior FRANZ wrote: > OK. But most likely because the build system doesn't generate > them. FlightGear's and SimGear's build system *does* generate them, > so why ask if it's there? Because that is the way automake is supposed to work. You can either include al

[Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-18 Thread Melchior FRANZ
* Frederic Bouvier -- Saturday 18 February 2006 17:05: > fgrun and fgadmin haven't any config.h under MSVC. And I don't know > about Mac or another potential, non unix, system. OK. But most likely because the build system doesn't generate them. FlightGear's and SimGear's build system *does* genera

Re: [Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-18 Thread Frederic Bouvier
Melchior FRANZ wrote : > * Frederic Bouvier -- Saturday 18 February 2006 16:53: > >> I don't mind which form it has, but this file that include system >> peculiarities should be included at first place in every compiled c++ >> file one way or another. >> > > Yes, sure. I don't doubt the imp

[Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-18 Thread Melchior FRANZ
* Frederic Bouvier -- Saturday 18 February 2006 16:53: > I don't mind which form it has, but this file that include system > peculiarities should be included at first place in every compiled c++ > file one way or another. Yes, sure. I don't doubt the importance of including config.h. I just can't

Re: [Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-18 Thread Frederic Bouvier
Melchior FRANZ a écrit : > * Frederic Bouvier -- Saturday 18 February 2006 16:29: > >> Modified Files: >> voice.cxx >> Log Message: >> Not missing but at the wrong place >> > > Ah, OK. (Normally, one should keep #includes away from header > files as much as possible, but as class defi

[Flightgear-devel] Re: CVS: FlightGear/src/Sound voice.cxx,1.3,1.4

2006-02-18 Thread Melchior FRANZ
* Frederic Bouvier -- Saturday 18 February 2006 16:29: > Modified Files: > voice.cxx > Log Message: > Not missing but at the wrong place Ah, OK. (Normally, one should keep #includes away from header files as much as possible, but as class definitions contain short code parts, this CONFIG_H