Re: [Flightgear-devel] configuration info (svn part)

2010-02-07 Thread Jari Häkkinen
Wow, what a debate. This is a reply to an early post in this thread.


On 2/5/10 6:21 PM, Martin Spott wrote:
 Jari Häkkinen wrote:

 Actually I think subversion support in terrasync should be removed
 altogether or fixed. If removed then all svn checks could be removed.

 Oh my, could you _please_ stop this litany ? One posting of this sort
 per day should really be enough, two or more are a nuisance. According
 to my experience you're trying to make people throw the baby out with
 the bath water, which is not appropriate here.

Well, I am only trying to suggest improvements to the code/build 
environment. I think this is the first time I actually suggest a feature 
to be thrown out. I remember trying to convince developers to remove 
dependencies on PLIB parts that are implicitly stated to not being used 
according to the fg build instructions. I have suggested that some code 
should be conditionally built (i.e. by doing make check). I had a few 
more posts but my hope and intent is that my postings actually improves fg.

Nae, sorry Martin I have something more to say about terragear and 
subversion. I posted my previous message with a few things in mind

1) Document for other newcomers (I been around for one year soon but 
still consider me a fg code beginner since I only look at the code 
occasionally) that there are some strange features wrt subversion and 
terragear. They might catch this thread through their favourite search 
engine.

2) I wanted to report the bug (oups there I used the nasty word) in 
terrasync ... it locks directories. I gave a reference to another 
posting where I think it was clear that the issue was not being fixed by 
the father of the baby.

3) Also, on my machine with subversion development libs the 
configuration script fails out of the box. Therefore I attached a patch 
for others to use or ignore.

4) I also acknowledged the fact that Geoffs was right but I wanted to 
highlight that the terragear flaw is still valid. Geoffs response to my 
posting explains why he is not experiencing the issues I see.


 If we were to drop every feature which _might_ occasionally have a
 malfunction here or there, then we would end up with having no
 FlightGear at all,

The problem is that the terrasync issue happens almost every time I run 
fg but then of course terragear is started each time I run fg (even for 
short tests). There are many directories to sync each time terrasync stars.

I don't want to drop features and I am crazy enough to run terragear 
with the current subversion flaw ... hoping it will be fixed some day. 
Am I the only one using subversion built-in terragear?


Cheers,

Jari


--
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] configuration info (svn part)

2010-02-05 Thread Jari Häkkinen

On 2/5/10 4:04 PM, Geoff McLane wrote:

But I have had more time to write, and test a
BETTER patch attached that :-
(a) does NOT change the svn_client.h lines ;=((,


(a) should be changed, I agree with your original proposal.

Actually I think subversion support in terrasync should be removed 
altogether or fixed. If removed then all svn checks could be removed.




And I hope your other 'svn' changes also make it
into CVS...


I attach my suggested svn related changes to configure.ac for reference 
for other new builders of fg. Note, apply the patch cautiously since 
having svn calls in terrasync may lock the terrasync-WC directories in 
some cases (with fairly high probability).


Maybe there should be a check for APR but I suppose that if svn-devel 
package are installed then also apr will be available.



Geoff, how do you make it through the svn check in configure.ac or 
really building terrasync?



Jari
Index: configure.ac
===
RCS file: /var/cvs/FlightGear-0.9/source/configure.ac,v
retrieving revision 1.166
diff -u -p -r1.166 configure.ac
--- configure.ac5 Feb 2010 05:40:15 -   1.166
+++ configure.ac5 Feb 2010 16:40:26 -
@@ -787,10 +803,9 @@ fi
 dnl Check for Subversion library support
 save_LIBS=$LIBS
 save_CPPFLAGS=$CPPFLAGS
-LIBS=
+LIBS=`apr-1-config --link-ld`
 CPPFLAGS=-I/usr/include/subversion-1 `apr-1-config --includes`
-AC_CHECK_LIB(svn_client-1, svn_client_checkout3)
-AC_CHECK_HEADERS([svn_client.h glut.h])
+AC_CHECK_HEADERS([svn_client.h])
 if test x$ac_cv_header_svn_client_h != xyes; then
   echo TerraSync will shell out for command line subversion
   svn_LIBS=
@@ -798,6 +813,11 @@ if test x$ac_cv_header_svn_client_h !=
 else
   echo TerraSync will use integrated subversion library
   AC_SEARCH_LIBS(svn_client_checkout, svn_client-1)
+  AC_SEARCH_LIBS(svn_delta_version, svn_delta-1)
+  AC_SEARCH_LIBS(svn_diff_version, svn_diff-1)
+  AC_SEARCH_LIBS(svn_ra_initialize, svn_ra-1)
+  AC_SEARCH_LIBS(svn_pool_create_ex, svn_subr-1)
+  AC_SEARCH_LIBS(svn_wc_version, svn_wc-1)
   svn_LIBS=$LIBS
   svn_CPPFLAGS=$CPPFLAGS
   AC_SUBST(svn_LIBS)
--
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] configuration info (svn part)

2010-02-05 Thread Martin Spott
Jari Häkkinen wrote:

 Actually I think subversion support in terrasync should be removed 
 altogether or fixed. If removed then all svn checks could be removed.

Oh my, could you _please_ stop this litany ? One posting of this sort
per day should really be enough, two or more are a nuisance. According
to my experience you're trying to make people throw the baby out with
the bath water, which is not appropriate here.

If we were to drop every feature which _might_ occasionally have a
malfunction here or there, then we would end up with having no
FlightGear at all,

Martin.
-- 
 Unix _IS_ user friendly - it's just selective about who its friends are !
--

--
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] configuration info (svn part)

2010-02-05 Thread Martin Spott
Martin Spott wrote:

 Oh my, could you _please_ stop this litany ? One posting of this sort
 per day should really be enough, two or more are a nuisance. According
 to my experience you're trying to make people throw the baby out with
 the bath water, which is not appropriate here.

  which, BTW, doesn't mean that I'm against having a fix to clean
up open connections and/or pending SVN locks,

Martin.
-- 
 Unix _IS_ user friendly - it's just selective about who its friends are !
--

--
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] configuration info (svn part)

2010-02-05 Thread Geoff McLane
Hi Jari,

 Geoff, how do you make it through the svn check in 
 configure.ac or really building terrasync?

I don't have any problems ;=)) utils/TerraSync/
terrasync builds without ANY problems in my
64-bit Ubuntu 8.04...

I do _NOT_ have the svn library, nor svn_client.h installed,
but of course do have runtime svn version 1.5.1 (r32289),
and rsync version 3.0.4, protocol version 30, so assume 
fgfs would shell out, IF NEED BE...

But I _NEVER_ use TerraSync! It is abhorrent to me that fgfs
should need to download 'scenery' to my machine, on the
fly, as it is, putting it somewhere... UGH!

But to be sure, the concept of 'terrasyncing' is good,
for those who want to use it, and should be continued,
and fixed if there are problems, but for me, like 'real'
piloting, I prefer to make sure I have all the
maps, oops I mean scenery, BEFORE I go there ;=))

I have downloaded, and installed 100% of the current 
scenery 1.0.1, and will do the same as each new build
is done... HDD space is really cheap these days...

Or I could burn my own DVDs, or better still toss a
few bucks to Curt and get the DVD set by mail...

As simple as that ;=))

Regards,

Geoff.

PS: I hope this post is NOT classified as part
of any 'litany' ;=()



--
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel