Re: [PATCH] abandoning code-generated Property.Maker

2004-01-17 Thread Finn Bock
On bugzilla, Glen wrote: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25873 [PATCH] abandoning code-generated Property.Maker Please give me a couple of days to comment--say 48 hours. My initial thoughts are I like what I see, esp. since appeared to you appeared to unnest the

Re: DO NOT REPLY [Bug 25873] - [PATCH] abandoning code-generated Property.Maker

2004-01-17 Thread Jeremias Maerki
Code-completion works for me today as I simply run ant codegen and include the build/gensrc directory in the list of source directories in my IDE. That was one of the reasons why I changed the build to generate the gensrc directory and why I moved the sources from src to src/java for HEAD: To make

RE: DO NOT REPLY [Bug 25873] - [PATCH] abandoning code-generated Property.Maker

2004-01-17 Thread Andreas L. Delmelle
-Original Message- From: Jeremias Maerki [mailto:[EMAIL PROTECTED] snip / I'm indifferent whether you go forward with this or not. I personally think it's unnecessary. Unnecessary, yes, for those who are familiar enough with the code. I think however, this proposal would make the

Re: DO NOT REPLY [Bug 25873] - [PATCH] abandoning code-generated Property.Maker

2004-01-17 Thread Jeremias Maerki
From that perspective, yes, of course. On 17.01.2004 14:55:03 Andreas L. Delmelle wrote: -Original Message- From: Jeremias Maerki [mailto:[EMAIL PROTECTED] snip / I'm indifferent whether you go forward with this or not. I personally think it's unnecessary. Unnecessary,

Re: [PATCH] abandoning code-generated Property.Maker

2004-01-17 Thread Glen Mazza
--- Finn Bock [EMAIL PROTECTED] wrote: The patch does not unnest the Property.Maker class. It doesn't matter all that much to me, but if it is considered a good idea it is easy to do. Ooops...I think I had misread the code there. Actually, hold off on this then. Should the values of

cvs commit: xml-fop/src/codegen prop-val-enum-interfaces.xsl

2004-01-17 Thread gmazza
gmazza 2004/01/17 07:37:27 Modified:src/codegen prop-val-enum-interfaces.xsl Log: (Property Interface consolidation) Removed a redundancy in interface definitions: from here (for several of the interfaces): public interface KeepWithNext { public interface

cvs commit: xml-fop/src/codegen prop-val-enum-interfaces.xsl

2004-01-17 Thread gmazza
gmazza 2004/01/17 08:05:40 Modified:src/codegen prop-val-enum-interfaces.xsl Log: Further simplifications to file. Revision ChangesPath 1.3 +1 -94 xml-fop/src/codegen/prop-val-enum-interfaces.xsl Index: prop-val-enum-interfaces.xsl

RE: HashMap

2004-01-17 Thread Andreas L. Delmelle
-Original Message- From: Peter B. West [mailto:[EMAIL PROTECTED] snip / I assume this problem is with the iframes? Well, not my eye-frames... but if that's what these charming windows on the sources are called, then, yes. Anyway, this could well be added as a feature to the other

cvs commit: xml-fop/src/java/org/apache/fop/tools AreaTreeBuilder.java

2004-01-17 Thread gmazza
gmazza 2004/01/17 11:29:46 Modified:.build.xml src/codegen constants.xsl properties.xsl src/java/org/apache/fop/area CTM.java PageViewport.java src/java/org/apache/fop/area/inline Leader.java src/java/org/apache/fop/fo

Servlet Examples in HEAD v.s. 0.20.5

2004-01-17 Thread John Austin
After the last week's thread about running FOP in a servlet, I thought I'd review the examples with a view to improving the end-user experience and flattening the learning. Some notes: The current sample: org.apache.fop.servlet.FopServlet has been improved in HEAD but the packaging seems (IMHO)

cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr AddLMVisitor.java

2004-01-17 Thread gmazza
gmazza 2004/01/17 14:02:03 Modified:src/java/org/apache/fop/datatypes Keep.java LengthPair.java src/java/org/apache/fop/fo/flow Leader.java src/java/org/apache/fop/layoutmgr AddLMVisitor.java Log: Bug 25873 (from Finn Bock): Minor code cleanup issues.

Re: Servlet Examples in HEAD v.s. 0.20.5

2004-01-17 Thread Jeremias Maerki
Discussion on this can be found here: http://marc.theaimsgroup.com/?t=10383153256r=1w=2 http://marc.theaimsgroup.com/?t=10172302692r=1w=2 There were pros and cons about the move from examples into the main source tree. I think the triggering point was that the servlet sees real use and

Re: Servlet Examples in HEAD v.s. 0.20.5

2004-01-17 Thread John Austin
On Sat, 2004-01-17 at 19:18, Jeremias Maerki wrote: Discussion on this can be found here: http://marc.theaimsgroup.com/?t=10383153256r=1w=2 http://marc.theaimsgroup.com/?t=10172302692r=1w=2 There were pros and cons about the move from examples into the main source tree. I think the