Re: [Bug 27901] - [PATCH] TextCharIterator.remove() does not work properly

2004-04-20 Thread J.Pietschmann
Glen Mazza wrote: If you replace "whitespace handling" with "replacing every occurrence of the letter 'A' with 'B'", a similar idea, you can see what I'm getting at--the fo:block should be able to clean itself up (if there is such a property defined for the fo mandating that cleanup) prior to pr

Re: [Bug 27901] - [PATCH] TextCharIterator.remove() does not work properly

2004-04-19 Thread Glen Mazza
J.Pietschmann wrote: Hmmm...not that big a deal to me, but I would be inclined to keep the whitespace removal out of the LayoutManagers, because it is fo:block specific I don't quite understand this argument. Handling space-before is also fo:block specific. Where should this logic be put, then?

Re: [Bug 27901] - [PATCH] TextCharIterator.remove() does not work properly

2004-04-18 Thread J.Pietschmann
Glen Mazza wrote: proper TR14 line breaking needs a precious character LB property and a whitespace status Darn, should be "previous". I'm not sure what you're referring to here--the TR at http://www.unicode.org/unicode/reports/tr14/, doesn't appear to mention a "whitepace status" or LB "propert

Re: [Bug 27901] - [PATCH] TextCharIterator.remove() does not work properly

2004-04-17 Thread Glen Mazza
Hello Joerg, welcome back. J.Pietschmann wrote: Glen Mazza wrote: A further optimization might be to do all this before the Block is even parsed into FOText and Inline objects, as many spaces-only objects would end up not even needing to be created. This will not account for spaces to be remov

Re: [Bug 27901] - [PATCH] TextCharIterator.remove() does not work properly

2004-04-17 Thread J.Pietschmann
Glen Mazza wrote: A further optimization might be to do all this before the Block is even parsed into FOText and Inline objects, as many spaces-only objects would end up not even needing to be created. This will not account for spaces to be removed around line breaks. My preferred solution is to co

Re: [Bug 27901] - [PATCH] TextCharIterator.remove() does not work properly

2004-04-07 Thread Simon Pepping
On Tue, Apr 06, 2004 at 03:47:53PM -0700, Glen Mazza wrote: > I'm not sure exactly what you mean--are you indicating > it might be best to pull out the interators from > FOText and flow.Inline and have everything done within > flow.Block? That could work well. Frankly, I do not mean much. It is j

Re: [Bug 27901] - [PATCH] TextCharIterator.remove() does not work properly

2004-04-06 Thread Glen Mazza
I'm not sure exactly what you mean--are you indicating it might be best to pull out the interators from FOText and flow.Inline and have everything done within flow.Block? That could work well. A further optimization might be to do all this before the Block is even parsed into FOText and Inline ob

Re: DO NOT REPLY [Bug 27901] - [PATCH] TextCharIterator.remove() does not work properly

2004-04-06 Thread Glen Mazza
Thanks for looking through the code, Simon. --- Simon Pepping <[EMAIL PROTECTED]> wrote: > > I have a remark on the logic of nextCharCalled. It > is equal to > curIndex - startIndex. Also, in remove() you should > separately > consider the case nextCharCalled == 0: it should not > happen. > "ne

Re: [Bug 27901] - [PATCH] TextCharIterator.remove() does not work properly

2004-04-06 Thread Simon Pepping
I should add that I have realized that the rules of whitespace handling in the FO spec are quite complicated, and that it is unwise to handle whitespace outside of the Block.handleWhiteSpace method. Regards, Simon -- Simon Pepping home page: http://www.leverkruid.nl

Re: DO NOT REPLY [Bug 27901] - [PATCH] TextCharIterator.remove() does not work properly

2004-04-06 Thread Simon Pepping
On Sun, Apr 04, 2004 at 06:41:41AM -, [EMAIL PROTECTED] wrote: > --- Additional Comments From [EMAIL PROTECTED] 2004-04-04 06:41 --- > Anyway, please check the latest solution applied. Here I brought in the old > solution to solve the extra spaces problem, while keeping the new soluti

Re: [Fwd: DO NOT REPLY [Bug 27901] - [PATCH] TextCharIterator.remove() does not work properly]

2004-04-05 Thread Glen Mazza
Yes, this needs more work then. I did not consider fo:inlines when starting. Still, I'm surprised that are within the same FOText object (the fo:block is already parsed into several FOText objects, roughly FOText object per line in the source document)--the appearance of an should precipitate

[Fwd: DO NOT REPLY [Bug 27901] - [PATCH] TextCharIterator.remove() does not work properly]

2004-04-05 Thread Chris Bowditch
Comments most welcome. Glen, In general I like your solution. However, I did a bit of testing with inlines and the effects are very serious. Valid non-whitespace characters from the enclosing block are simply deleted if there is whitespace at the start of the fo:inline. Chris

DO NOT REPLY [Bug 27901] - [PATCH] TextCharIterator.remove() does not work properly

2004-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 27901] - [PATCH] TextCharIterator.remove() does not work properly

2004-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 27901] - [PATCH] TextCharIterator.remove() does not work properly

2004-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 27901] - [PATCH] TextCharIterator.remove() does not work properly

2004-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 27901] - [PATCH] TextCharIterator.remove() does not work properly

2004-04-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 27901] - [PATCH] TextCharIterator.remove() does not work properly

2004-04-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu