Re: Just do it (was: Re: Borders on Blocks)
Jeremias Maerki <[EMAIL PROTECTED]> schrieb am 19.05.2004 20:38:37: > You guys block yourselves with this strategy and Arnd gets > even more of a head-start. :-) 8-) -- Arnd Beißner Cappelino Informationstechnologie GmbH
Just do it (was: Re: Borders on Blocks)
Guys, my comment on this is: Commit it if you think it's an improvement. It may be a bit different if it concerned design questions, but with small fixed and improvements I'd rather you guys "just did it". If it turns out to be a mistake it can easily be corrected. That's why we have peer review here. You guys block yourselves with this strategy and Arnd gets even more of a head-start. :-) On 18.05.2004 12:40:07 Chris Bowditch wrote: > It fixes my problem, but I'll wait for any comments before committing this change. Jeremias Maerki (shutting up again)
Re: Borders on Blocks
Chris Bowditch wrote: FOP Devs, I would appreciate some advice. I have noticed that top/bottom borders dont work on regular blocks. This is because the PDF Renderer uses block.getWidth() to determine the length of the border lines. Here is a sinnper of Area Tree output: Home Insurance Notice how ipd=0 for the top level (static content) block and then width and ipd swap around for regular fo:blocks. Question is, is this wrong, or should the PDF Renderer be changed to consider either IPD or width properties of block? I think I have solved this mystery. The second level block shown above was a BC with the optional width property not specified. The assigning of width/ipd for a block is done in Block.getParentArea where IPD is always copied and width is based on either IPD or parent width. I have modified this logic a bit so that if the parent width is used, it will fall back to IPD if it is zero. It fixes my problem, but I'll wait for any comments before committing this change. Chris
Borders on Blocks
FOP Devs, I would appreciate some advice. I have noticed that top/bottom borders dont work on regular blocks. This is because the PDF Renderer uses block.getWidth() to determine the length of the border lines. Here is a sinnper of Area Tree output: Home Insurance Notice how ipd=0 for the top level (static content) block and then width and ipd swap around for regular fo:blocks. Question is, is this wrong, or should the PDF Renderer be changed to consider either IPD or width properties of block? Thoughts will be appreciated. Chris
