.
More below:
Alexander Kiel wrote:
Hi Max,
you are right. It's always better to have small patches focused on one
thing. I don't get my MinOptMax patch focused only on the refactoring of
making MinOptMax immutable.
In the last half-an-hour I walked myself through all the diffs,
file
Hi *,
Vincent Hennebert schrieb:
Hi,
Looks like Max is busy with more urgent things :-)
Yes, work keeps me occupied most of the time. I was actually just
looking at the patch again, and decided that I am unable to apply it,
because I do cannot verify if the renames are correct, as it affects
Hi Max,
One more thing I noticed: Alex, you are introducing deprecated methods
and then using them. Please either
- don't mark the methods as deprecated, if they are valid helper methods or
- don't use the deprecated methods, but rather use whatever you inted to
replace it with.
I marked
Hi Alex,
Hi *,
if you do not yet have FOP developer access, and you are working on a
larger set of problems, please do not submit one large patch - current
committers will not have the time to go through every single change.
Instead, it is much nicer to have a series of small patches.
One option
Hi Max,
you are right. It's always better to have small patches focused on one
thing. I don't get my MinOptMax patch focused only on the refactoring of
making MinOptMax immutable.
In the last half-an-hour I walked myself through all the diffs,
file-by-file. I must say - except from
Hi,
a issued a patch for MinOptMax:
https://issues.apache.org/bugzilla/show_bug.cgi?id=48071
Please read my first comment there and consider my patch :-)
Best Regards
Alex
On Sun, 2009-10-25 at 23:45 +0100, Alexander Kiel wrote:
Hi,
the class MinOptMax has some 800 usages in FOP. It holds
Hi,
the class MinOptMax has some 800 usages in FOP. It holds a triple of
values (min, opt, max) of length quantities.
It's heavily used during local computations and passing around. It's
fields are public (whereas the class comment says they are only package
visible). The public fields (and
