Re: svn commit: r367395 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/XMLWhiteSpaceHandler.java
Andreas L Delmelle wrote:
On Jan 11, 2006, at 17:56, Andreas L Delmelle wrote:
snip/
OK. So apparently, this has nothing to do with refinement white-space-
handling, IIC.
snip/
If I remove the border-* and padding-* properties, the trailing space
area for the latter disappears...?
Of course, the expected result could simply be modified, but it would
be much better if this were fixed in the related code. No idea where
precisely.
= Q: Disable it FTM, or alter the expectation to make it pass?
I don't like the sound of this at all. May I suggest an alternative
approach to finding the cause of the problem? Could you create a diff of
all changed files and post it up here, so others may aid in the
investigation?
snip/
I changed the related code in BreakingAlgorithm from:
while(alignment != EN_CENTER
! ((KnuthElement) par.get(firstBoxIndex)).isBox()) {
firstBoxIndex++;
...
to:
if(alignment != EN_CENTER
while(par.size() firstBoxIndex
! ((KnuthElement) par.get(firstBoxIndex)).isBox()) {
firstBoxIndex++;
...
That solved this particular little problem, but it is more of a quick
fix, I guess.
I think we need to understand the root cause of this before making this
change. Unfortunately Jeremias isn't around for the next 2/3 days, so
may I suggest holding off making this change until he returns. He has a
very good understand of this bit of code ;)
Chris
DO NOT REPLY [Bug 38098] - [patch] allow some xsl-function calls with omitted args
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38098. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38098 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #17306|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2006-01-12 11:14 --- Created an attachment (id=17399) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=17399action=view) testcase -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 38243] - [patch] gaps in table-columns crash fop
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38243. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38243 --- Additional Comments From [EMAIL PROTECTED] 2006-01-12 18:47 --- Created an attachment (id=17400) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=17400action=view) Solves problems with gaps in table-columns -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 38244] New: - table-column and number-columns-spanned (prepatch)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38244. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38244 Summary: table-column and number-columns-spanned (prepatch) Product: Fop Version: 1.0dev Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: fo tree AssignedTo: fop-dev@xmlgraphics.apache.org ReportedBy: [EMAIL PROTECTED] Only to have a first sign to discuss. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
Off line for a week
Hi all! I apologize for having been not very active for the last weeks, but at long last things should change: next week I will be in San Jose (California) attending a conference about digital publishing, and after that I should have some time to spend working on FOP (and I really can't wait to!). Regards Luca
table-columns and number-columns-spanned
Hello AFAICS number-columns-spanned are not recognized for table-columns. A) Specification: The first question for me is of overlapping is allowed here? I did not find an explicit comment on this - maybe I looked not hard enough. At a first glance (when reading the spec to from-table-column) it looks like it was allowed and that only the pair of column-number + number-columns-spanned has to be unique to handle something like that: fo:table-column text-align=left/ fo:table-column text-align=right/ fo:table-column column-number=1 number-columns-spanned=2 text-align=center/ But I think it is not true. B) Implementation: Currently it is ignored and this fragment fo:table-column column-number=1 number-columns-spanned=2/ fo:table-column column-number=3/ throws a gap-error, but should not. B1) I filed a bug (38244) of a possible including of number-columns-spanned into the addColumn (in a early state i have to confess) that only changes two things: B1a) Incorporate the number-columns-spanned for the calculation of the following cell for number-columns-repeated according to spec 7.26.12. B1b) Using the same rule even if no number-culumns-repeated is given. If no overlapping is allowed there is no other chance for implicit column-number to work with number-columns-spanned. B1c) Mark all columns spanned with the used-flag. B1d) The TableColumn will be cloned (commented out for now) The main con is that in the columns list of the table object the positions that are spanned (except the first) are empty (null) and all layoutmanagers that need information from the table-column have to handle it by their own to get the value from the initial column of the spanned range. C) An alternative idea is to implement number-columns-spanned in a kind of number-columns-repeated fake, so that a fo:table-column column-number=1 number-columns-spanned=3/ would end up in three TableColumn objects fo:table-column column-number=1 number-columns-spanned=3/ fo:table-column column-number=2 number-columns-spanned=2/ fo:table-column column-number=3 number-columns-spanned=1/ For my goal (from-table-column) both are equal but i want to do it in that way that fits best (or does not break) the layoutmanagers. gerhard -- .''`. gerhard oettl on Debian/Gnu Linux : :' : `. `'` gpg key: 1024D/D59131AA 2002-06-18 `-
DO NOT REPLY [Bug 38098] - [patch] allow some xsl-function calls with omitted args
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38098. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38098 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2006-01-12 21:41 --- Patch and test file committed. Thanks. Simon -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
Re: table-column and number-columns-spanned (prepatch)
Gerhard, Thanks for your continued patches. Would you consider submitting an 'Individual Contributor License Agreement (ICLA)'? That would allow us to commit a larger amount of code from you. See http://www.apache.org/licenses/. You may in addition submit a 'Corporate Contributor License Agreement' (CCLA), but that serves more to define your position w.r.t. your employer, if he would have Intellectual Property rights to the code. Regards, Simon On Thu, Jan 12, 2006 at 07:30:58PM +0100, [EMAIL PROTECTED] wrote: http://issues.apache.org/bugzilla/show_bug.cgi?id=38244 Summary: table-column and number-columns-spanned (prepatch) ReportedBy: [EMAIL PROTECTED] Only to have a first sign to discuss. -- Simon Pepping home page: http://www.leverkruid.nl
Re: table-columns and number-columns-spanned
On Thu, Jan 12, 2006 at 09:55:57PM +0100, gerhard oettl wrote: fo:table-column number-columns-spanned=2 number-columns-repeated=2/ [ initial colnum = default = 1 ] would be expanded according to b) to: fo:table-column number-columns-spanned=2/ [ colnum = 1 ] fo:table-column number-columns-spanned=2/ [ colnum = 3 ] fo:table-column number-columns-spanned=2/ [ colnum = 5 ] The above represents number-columns-repeated=3. fo:table-column number-columns-spanned=2/ is equivalent to fo:table-column number-columns-spanned=2 number-columns-repeated=1/ (initial value). Simon -- Simon Pepping home page: http://www.leverkruid.nl
Re: svn commit: r368462 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/fo/expr/ test/fotree/testcases/
On Fri, 13 Jan 2006 04:40 am, [EMAIL PROTECTED] wrote: Author: spepping Date: Thu Jan 12 12:40:08 2006 New Revision: 368462 xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/expr/FromParentFunct ion.java (original) +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/expr/FromParentFunct ion.java Thu Jan 12 12:40:08 2006 @@ -1,5 +1,5 @@ /* - * Copyright 1999-2004 The Apache Software Foundation. + * Copyright 1999-2006 The Apache Software Foundation. * I know this is very picky but shouldn't this be written as: Copyright 1999-2004, 2006 The Apache Software Foundation. Unless there was a change to the file in 2005 (see http://www.apache.org/dev/apply-license.html)? Manuel
Re: svn commit: r367395 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/XMLWhiteSpaceHandler.java
On Fri, 13 Jan 2006 12:49 am, Andreas L Delmelle wrote: On Jan 12, 2006, at 01:14, Manuel Mall wrote: On Thu, 12 Jan 2006 05:34 am, Andreas L Delmelle wrote: snip / without your patch I cannot really replicate this. When I run through the debugger now I can see the space being given from the FO to the TextLayoutManager (look at the textarray in the TextLM constructor) therefore to me its still a refinement issue. But if your latest modifications fixes that then I would need that patch to further investigate. Try the diff in attach (modifications to XMLWhiteSpaceHandler and LineLayoutManager) Applied the diff but it didn't change my observation in the debugger. The extra space you noticed is coming from the FO. Therefore IMO the patch is not quite doing what you would like it to do. I haven't looked at your code yet. Manuel
