DO NOT REPLY [Bug 46980] [PATCH]internal named destinations

2009-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46980





--- Comment #1 from Andreas L. Delmelle adelme...@apache.org  2009-04-08 
11:26:28 PST ---

Thanks for the patch! Seems like a good starting point.
Only some very minor details (code-style) I'd change:

if (namedDestination == true) ... 

No idea if it's just me, but boolean comparisons almost always seems a bit
silly, as you can just write:
if (namedDestination) ...

Consequently, I'd also rename that member to something like 'isInternal' or
'hasInternalDestination', yielding the self-explanatory:
if (this.isInternal) ...

For the rest, the small piece of added code in PDFFactory can probably better
be added to getGoToPDFAction(), to be executed in case the parameter 'filename'
is null. (opportunity to avoid code-duplication)

Anyone with further suggestions before I commit this one, including the above
modifications?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 46980] [PATCH]internal named destinations

2009-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46980





--- Comment #2 from Andreas L. Delmelle adelme...@apache.org  2009-04-08 
11:33:50 PST ---
(In reply to comment #1)
 Consequently, I'd also rename that member to something like 'isInternal' or
 'hasInternalDestination', yielding the self-explanatory:
 if (this.isInternal) ...

Just noticed that 'hasNamedDestination' is probably better, since PDFGoTos are
always internal... :-/

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 24804] SVG Text to PS Output generates incorrect outlines

2009-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=24804


Jeremias Maerki jerem...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Comment #4 from Jeremias Maerki jerem...@apache.org  2009-04-08 12:23:36 
PST ---
This has been fixed long ago.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 47000] New: [PATCH] Full-featured TextPainter for PS output

2009-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47000

   Summary: [PATCH] Full-featured TextPainter for PS output
   Product: Fop
   Version: 1.0dev
  Platform: All
OS/Version: All
Status: NEW
  Keywords: PatchAvailable
  Severity: enhancement
  Priority: P2
 Component: ps
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: jerem...@apache.org


Created an attachment (id=23467)
 -- (https://issues.apache.org/bugzilla/attachment.cgi?id=23467)
PSTextPainter patch

This patch adds a full-featured Batik TextPainter for PostScript/EPS output, so
text is no longer painted as shapes but using PostScript text operators. All
SVG text variants including flow text are supported. The old, incomplete
PSTextPainter is completely replaced. The old one was inactive anyway due to a
bug.

As with the PDFTextPainter, the PSTextPainter relies on Batik font subsystem
(which uses Java2D/AWT fonts) for font availability and tries to map those to
internally configured fonts. Since PS output currently only supports Type 1
fonts, there might be difficulties matching the fonts as not all JVMs properly
support and report Type 1 fonts installed in the operating systems.
Furthermore, not all glyphs in the Type 1 font may be available as a result.

Some numbers to illustrate the improvement (size of EPS files generated by
EPSTranscoder):
W3C SVG test suite, text-path-01-b.svg, old: 103KB, new 17KB
W3C SVG test suite, text-deco-01-b.svg, old: 123KB, new 20KB
batik/samples/extensions/flowText.svg, old: 413KB, new 24KB

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 47000] [PATCH] Full-featured TextPainter for PS output

2009-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47000


Jeremias Maerki jerem...@apache.org changed:

   What|Removed |Added

 Blocks||40529




-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 40529] [PATCH] Possible bug in PSTextRenderer

2009-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=40529


Jeremias Maerki jerem...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Depends on||47000
 Resolution||WONTFIX




--- Comment #2 from Jeremias Maerki jerem...@apache.org  2009-04-08 12:43:33 
PST ---
This should be obsoleted by bug #47000. Sorry that this patch seems to have
slipped through the cracks.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 47000] [PATCH] Full-featured TextPainter for PS output

2009-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47000





--- Comment #1 from Jeremias Maerki jerem...@apache.org  2009-04-08 12:53:15 
PST ---
Please don't review just yet. I've forgotten to create the patch necessary for
XGC so this actually compiles. Will do that tomorrow morning.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 46980] [PATCH]internal named destinations

2009-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46980





--- Comment #3 from michaelrichardso...@gmail.com  2009-04-08 15:25:24 PST ---
I'm glad my changes will be commited so others can benifit from my (small)
contribution. :D

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.