Bug report for Fop [2009/08/02]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 1063|New|Nor|2001-03-21|fop does not handle large fo files| | 3824|New|Blk|2001-09-25|MIF option with tables| | 5010|New|Enh|2001-11-21|Better error reporting needed | | 6305|New|Nor|2002-02-07|Using fo:table-and-caption results in empty output| | 6427|New|Enh|2002-02-13|Type 1 CID fonts are not supported| | 8003|New|Maj|2002-04-12|FopImageFactory never releases cached images | | 8463|New|Nor|2002-04-24|SVG clipping in external.fo example doc when rende| | 9379|New|Nor|2002-05-24|MIF Renderer generates incorrect MIF code | |12610|New|Enh|2002-09-13|[PATCH] onLoad Action for PDF documents or how to | |14356|New|Nor|2002-11-07|*NOT* embedding TrueTypeFont in PDF causes Acrobat| |16713|New|Nor|2003-02-03|Hyphenation error in tables | |17369|New|Nor|2003-02-25|Footnote duplication | |17380|New|Nor|2003-02-25|Batik Component will not recognize fe SVG elem| |17921|New|Nor|2003-03-12|Kerning is broken for standard fonts | |18292|New|Nor|2003-03-24|24 bit PNG not displayed correctly| |18801|New|Nor|2003-04-08|visibility property is not implemented | |19228|New|Blk|2003-04-22|[PATCH] Child LayoutContext is null in certain cir| |19341|Ver|Nor|2003-04-26|leader doesn't work since 0.20.5.rc2 | |19695|New|Enh|2003-05-06|[PATCH] Allow fox:destination as child of fox:outl| |19717|New|Enh|2003-05-07|Lets add support for JimiClassesPro.zip to build.x| |19769|Ass|Enh|2003-05-08|Indefinite page size is not implemented | |20280|Ass|Enh|2003-05-27|text-align and text-align-last only partially impl| |20407|New|Enh|2003-06-02|[PATCH] Configure image caching using the configur| |20827|New|Enh|2003-06-17|Derive other font styles and weights from normal T| |21265|Opn|Nor|2003-07-02|referencing a custom font (TTF or Adobe Type 1) fo| |21905|New|Nor|2003-07-26|large list-item-label bleeds into following block | |21982|New|Maj|2003-07-30|NullPointer Exception in LazyFont with embedded fo| |22450|New|Maj|2003-08-15|Unterminated iteration in JPEGReader class| |22627|Opn|Nor|2003-08-21|Update mirror/download page HEADER README (was [| |24148|New|Nor|2003-10-27|Kerning upsets text-align=end | |24171|New|Nor|2003-10-28|[PATCH] 1st Attempt at Whole Site PDF | |24378|New|Nor|2003-11-04|Minor problem in sample code for embedding| |24663|New|Nor|2003-11-12|fo:block space-after property needs fixing| |25022|New|Nor|2003-11-26|XSL-FO to PCL : images not included | |25341|New|Nor|2003-12-08|percentage resolution not being recalculated on di| |25411|New|Nor|2003-12-10|[WARNING] Error while constructing image from XML | |25432|Ass|Maj|2003-12-11|Cannot embed the User Defined Characters into the | |26047|New|Nor|2004-01-11|Space-after value remembered and used on second do| |26590|New|Nor|2004-02-02|last character width in winansi font is missed| |26848|New|Nor|2004-02-11|PNG images using JIMI instead JAI | |27107|New|Maj|2004-02-20|TTF Reader fails | |27727|New|Maj|2004-03-17|problem displaying Japanese fonts in PDF. | |27890|New|Min|2004-03-24|fop.sh doesn't set exit status| |29632|New|Maj|2004-06-17|Rendered reads fonts from disk everytime it render| |30006|New|Nor|2004-07-09|eps doesn't show up in recent GhostScript versions| |30214|New|Nor|2004-07-20|PSGraphics2D.drawImage incorrect matrix generated | |31039|New|Nor|2004-09-03|URL in basic-link is scrambled by encryption | |31225|New|Nor|2004-09-14|Need embedded page sequence functionality | |31301|New|Nor|2004-09-19|FOP limitation-Summary of columns value at Table F| |31674|New|Enh|2004-10-12|Allow Print Renderer to select Printer and Tray. | |31796|New|Cri|2004-10-20|Fop: Pdf generation dowsn`t work with j2sdk 1.5 |
Re: svn commit: r800217 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf: PDFFactory.java PDFPage.java
The reason for the Gump failure was my forgetting an svn up before
committing the prepress patch. But rather than adjust my changes against
the original patch, I've decided to revert Vincent's change to increase
accuracy. While testing I noticed that my bleeding backgrounds didn't
match the rectangle that Acrobat displayed. When switching to doubles,
those boundaries match, so I'd rather we operate on the internal
resolution of FOP for specifying page sizes.
On 03.08.2009 08:43:46 jeremias wrote:
Author: jeremias
Date: Mon Aug 3 06:43:45 2009
New Revision: 800217
URL: http://svn.apache.org/viewvc?rev=800217view=rev
Log:
Reverted rev 798521.
Reason: Loss of accuracy. PDF is operating at points rather than millipoints.
Especially when it comes to prepress features people will want exact sizes in
the target PDFs.
Modified:
xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFFactory.java
xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFPage.java
Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFFactory.java
URL:
http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFFactory.java?rev=800217r1=800216r2=800217view=diff
==
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFFactory.java
(original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFFactory.java Mon Aug
3 06:43:45 2009
@@ -20,7 +20,6 @@
package org.apache.fop.pdf;
// Java
-import java.awt.Rectangle;
import java.awt.geom.Point2D;
import java.awt.geom.Rectangle2D;
import java.io.FileNotFoundException;
@@ -184,8 +183,8 @@
* @return the created /Page object
*/
public PDFPage makePage(PDFResources resources, int pageIndex,
-Rectangle mediaBox, Rectangle cropBox,
-Rectangle bleedBox, Rectangle trimBox) {
+Rectangle2D mediaBox, Rectangle2D cropBox,
+Rectangle2D bleedBox, Rectangle2D trimBox) {
PDFPage page = new PDFPage(resources, pageIndex, mediaBox, cropBox,
bleedBox, trimBox);
getDocument().assignObjectNumber(page);
@@ -207,7 +206,7 @@
*/
public PDFPage makePage(PDFResources resources,
int pageWidth, int pageHeight, int pageIndex) {
-Rectangle mediaBox = new Rectangle(0, 0, pageWidth, pageHeight);
+Rectangle2D mediaBox = new Rectangle2D.Double(0, 0, pageWidth,
pageHeight);
return makePage(resources, pageIndex, mediaBox, mediaBox, mediaBox,
mediaBox);
}
Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFPage.java
URL:
http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFPage.java?rev=800217r1=800216r2=800217view=diff
==
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFPage.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFPage.java Mon Aug 3
06:43:45 2009
@@ -19,7 +19,7 @@
package org.apache.fop.pdf;
-import java.awt.Rectangle;
+import java.awt.geom.Rectangle2D;
/**
* Class representing a /Page object.
@@ -45,8 +45,8 @@
* @param trimBox the TrimBox. If null, bleedBox is used.
*/
public PDFPage(PDFResources resources, int pageIndex,
- Rectangle mediaBox, Rectangle cropBox,
- Rectangle bleedBox, Rectangle trimBox) {
+ Rectangle2D mediaBox, Rectangle2D cropBox,
+ Rectangle2D bleedBox, Rectangle2D trimBox) {
/* generic creation of object */
super(resources);
@@ -56,8 +56,8 @@
this.pageIndex = pageIndex;
}
-private void setSimplePageSize(Rectangle mediaBox, Rectangle cropBox,
- Rectangle bleedBox, Rectangle trimBox) {
+private void setSimplePageSize(Rectangle2D mediaBox, Rectangle2D cropBox,
+ Rectangle2D bleedBox, Rectangle2D
trimBox) {
setMediaBox(mediaBox);
if (cropBox == null) {
@@ -76,16 +76,16 @@
setTrimBox(trimBox); //Needed for PDF/X
}
-private PDFArray toPDFArray(Rectangle box) {
-return new PDFArray(this, new int[] {
-box.x, box.y, box.x + box.width, box.y + box.height});
+private PDFArray toPDFArray(Rectangle2D box) {
+return new PDFArray(this, new double[] {
+box.getX(), box.getY(), box.getMaxX(), box.getMaxY()});
}
/**
* Sets the MediaBox entry
* @param box the media rectangle
*/
-public void setMediaBox(Rectangle box) {
+public void setMediaBox(Rectangle2D box) {
put(MediaBox, toPDFArray(box));
}
@@ -93,7 +93,7 @@
* Sets the CropBox entry
* @param
DO NOT REPLY [Bug 47311] [PATCH] Support for bleed, trim and crop box and scaling
https://issues.apache.org/bugzilla/show_bug.cgi?id=47311 Vincent Hennebert vhenneb...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #38 from Vincent Hennebert vhenneb...@gmail.com 2009-08-03 04:13:09 PST --- (In reply to comment #37) Applied the patch with the changes already mentioned. Thanks a lot for your patch Peter, and thanks also for your patience with my late involvement. http://svn.apache.org/viewvc?rev=800142view=rev I hope we will have a chance some day to improve the property subsystem so we can also handle extension like this more elegantly. This is not quite finished I'm afraid: - I thought we agreed to set the default value of crop-offset to bleed - errors in the specification of extension properties are not redirected through the event mechanism - there are typos in the PageBoundariesAttributes and PageScaleAttributes classes - there is an encapsulation problem: the fall back boxes used when one of the properties has not been defined are controlled by the client code, instead of being handled inside the extension class itself (PageBoundariesAttributes). This can easily lead to inconsistencies (one default value used in the PDF renderer, another one in the Java2D renderer). Re-opening the bug as a reminder, as I don't have the time to handle that right now. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 47311] [PATCH] Support for bleed, trim and crop box and scaling
https://issues.apache.org/bugzilla/show_bug.cgi?id=47311 --- Comment #39 from Jeremias Maerki jerem...@apache.org 2009-08-03 07:34:06 PST --- 3 of the 4 latest comments have been hopefully satisfyingly taken care of: http://svn.apache.org/viewvc?rev=800401view=rev -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 45097] Questionable white-space-treatment behavior
https://issues.apache.org/bugzilla/show_bug.cgi?id=45097 --- Comment #19 from Sean Griffin sgrif...@cerner.com 2009-08-03 11:03:00 PST --- I know it's been a long time, but I was just wondering if anyone was able to get anywhere on the last remaining issue described in this bug. The last discussion centered around whether the Knuth sequence for preserved whitespace was more complicated than it needed to be and that, possibly, by moving the penalty=0 after the glue instead of before the issue would be fixed...assuming it doesn't then cause problems with alignment/justification. As predicted, one of my clients is finally complaining about the behavior and is asking when it will be fixed. Obviously I can jump in and try to fix myself to help in the effort, but I'm guessing that in the time it takes me to learn the layout algorithm and Knuth concepts someone with more experience in this stuff could have already resolved the issue. Plus, it sounds like Andreas might have already started working on a fix? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
