DO NOT REPLY [Bug 50626] O(n^2) algorithm for adding nodes

2011-01-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50626

--- Comment #2 from e9925248 mkoeg...@auto.tuwien.ac.at 2011-01-22 12:29:33 
EST ---
Created an attachment (id=26534)
 -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26534)
New version

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 50626] O(n^2) algorithm for adding nodes

2011-01-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50626

--- Comment #3 from e9925248 mkoeg...@auto.tuwien.ac.at 2011-01-22 12:39:07 
EST ---
Here is a new version: 

It fixes an NullPointerException, when removing from an nearly empty child
list.
Additionally, this time only spaces.

I hope, that I have caught all regressions: 

The ant output is clobered with known failures, so its difficult to see
regressions there (eg. compared to the GCC testsuite).

Maybe there is a better method to find regression, but I only found:
$ diff -urN previous test-result-directory new test-result-directory

The test infrastructure includes variable data in its output (time, when the
test was run, run time in ms and so on), so that this means check over 15.000
lines for important changes. I hope, that I have not missed anything.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 50635] New: Incorrect pagesequence passed to renderer

2011-01-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50635

   Summary: Incorrect pagesequence passed to renderer
   Product: Fop
   Version: 1.1dev
  Platform: All
OS/Version: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: general
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: mkoeg...@auto.tuwien.ac.at


The current code passes the current pagesequence to the renderer, but there can
be more than one pagesequence in processing.

So, when a page from an older page sequence is resolved, the current instead of
the old page sequnece is started.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 50626] O(n^2) algorithm for adding nodes

2011-01-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50626

Andreas L. Delmelle adelme...@apache.org changed:

   What|Removed |Added

  Attachment #26526|0   |1
is obsolete||

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 50635] Incorrect pagesequence passed to renderer

2011-01-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50635

--- Comment #1 from e9925248 mkoeg...@auto.tuwien.ac.at 2011-01-22 13:31:51 
EST ---
Created an attachment (id=26535)
 -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26535)
Patch

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 50626] O(n^2) algorithm for adding nodes

2011-01-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50626

Andreas L. Delmelle adelme...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #4 from Andreas L. Delmelle adelme...@apache.org 2011-01-22 
13:34:10 EST ---
(In reply to comment #3)
 Here is a new version: 
 
 It fixes an NullPointerException, when removing from an nearly empty child
 list. Additionally, this time only spaces.

Looks OK now, so is applied in r1062225
(http://svn.apache.org/viewvc?rev=1062225view=rev) with a very minor style
change (= we use braces around conditionals even if it's only a single
statement)

Thanks for reporting, and again, for the patch!

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 50636] New: O(n^2) code for adding new pages

2011-01-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50636

   Summary: O(n^2) code for adding  new pages
   Product: Fop
   Version: 1.1dev
  Platform: All
OS/Version: All
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: fo tree
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: mkoeg...@auto.tuwien.ac.at


Adding a new page causes to iterate over all existing page sequnces and count
their number of pages.

If there is a large number of page sequences, this can take a significant
percentage of the fop running time.

I have the attached workaround in my tree for some time:
It caches the number of pages in the page sequences, so that adding a new page
is only O(1).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 50636] O(n^2) code for adding new pages

2011-01-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50636

--- Comment #1 from e9925248 mkoeg...@auto.tuwien.ac.at 2011-01-22 13:41:02 
EST ---
Created an attachment (id=26536)
 -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26536)
Cache number of pages

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 48334] [PATCH] xml:base

2011-01-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48334

--- Comment #5 from Andreas L. Delmelle adelme...@apache.org 2011-01-22 
13:54:04 EST ---
(In reply to comment #4)
 The idea and your implementation look good. Some code is missing: xml:base
 should be listed as a valid property in PropertyList.addAttributesToList.

Oops! Forgot to add that one... :-(

 The backward compatibility case causes some complexity, but it seems to work
 well. I think that the class requires a better explanation of this case: when
 it applies and how it is handled. Having that explanation in this bug report
 does not suffice.

OK, makes sense. I will post a slightly revised patch for final review. Unless
anyone objects, this will find its way into FOP Trunk beginning of next week.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.