DO NOT REPLY [Bug 52257] New: [PATCH]Add events to the font package
https://issues.apache.org/bugzilla/show_bug.cgi?id=52257 Bug #: 52257 Summary: [PATCH]Add events to the font package Product: Fop Version: 1.1dev Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: fonts AssignedTo: fop-dev@xmlgraphics.apache.org ReportedBy: med1...@gmail.com Classification: Unclassified Created attachment 27994 -- https://issues.apache.org/bugzilla/attachment.cgi?id=27994 patch adding event listener to fonts package Hi All, The purpose of this patch was to add an event to handle the case of when the Unicode cmap table is missing from a TrueType font. Previously a the message went to the logger. However, in so doing, it forces a dependency on o.a.f.events* and o.a.f.util.DefaultErrorListener in the fop-transcoder.jar (and obviously fop-transcoder-allinone.jar). Adding these dependencies to the transcoder package is easily done, though the ramifications are less obvious to me. I have no experience using the transcoder and I just wanted to make sure everyone was happy with this and there aren't any issues that I'm missing. Thanks for your help Mehdi -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 52257] [PATCH]Add events to the font package
https://issues.apache.org/bugzilla/show_bug.cgi?id=52257 --- Comment #1 from Vincent Hennebert vhenneb...@gmail.com 2011-11-28 18:31:54 UTC --- IIC those transcoder jars are used by Batik to convert standalone SVG files into PDF. I suppose there's no harm in adding those dependencies to the jars, although it would need to be figured out how events are being processed (output on the command line? Logged? Just swallowed (which would be bad)?). However, there are changes in the patch that are almost certainly problematic: • a new DefaultEventBroadcaster instance is being created in the following classes: o/a/f/render/intermediate/IFUtil.java o/a/f/render/ps/NativeTextHandler.java o/a/f/svg/PDFGraphics2D.java o/a/f/pdf/PDFFactory.java The consequence is that at runtime it will be likely that several EventBroadcaster instances will exist in the same time and be handled inconsistently. For example, only the events from one instance may be caught and displayed in some dialog box. • the message added to the new fontNotSupported event will not be localizable, which defeats one of the purposes of the Event handling sub-system. It's probably best to create a more specific event. Vincent -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
