DO NOT REPLY [Bug 44658] Incorrect table-unit computation if proportional-column-width() is used as a subexpression

2012-04-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44658

Glenn Adams gl...@skynav.com changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--- Comment #9 from Glenn Adams gl...@skynav.com 2012-04-01 07:06:31 UTC ---
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 44658] Incorrect table-unit computation if proportional-column-width() is used as a subexpression

2008-04-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44658


Simon Pepping [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED




--- Comment #8 from Simon Pepping [EMAIL PROTECTED]  2008-04-24 10:44:07 PST 
---
Fixed in revision 651323.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


Re: DO NOT REPLY [Bug 44658] Incorrect table-unit computation if proportional-column-width() is used as a subexpression

2008-04-11 Thread Simon Pepping
On Tue, Apr 08, 2008 at 01:05:12PM -0700, [EMAIL PROTECTED] wrote:
 --- Comment #7 from Andreas L. Delmelle [EMAIL PROTECTED]  2008-04-08 
 13:05:11 PST ---
 
 Cool. Simon's patch indeed looks better than my own attempt.
 
 I'll see if I can apply it to the trunk (if Simon does not beat me to it)

Feel free to commit it. Do not forget a test case :-)

Simon

-- 
Simon Pepping
home page: http://www.leverkruid.eu


DO NOT REPLY [Bug 44658] Incorrect table-unit computation if proportional-column-width() is used as a subexpression

2008-04-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44658





--- Comment #4 from Simon Pepping [EMAIL PROTECTED]  2008-04-07 07:08:17 PST 
---
Andreas,

Your fix is high up the tree, in the Length interface. I attach a patch which
limits the getTableUnits method to RelativeNumericProperty. The method only
plays a role in TableColLength and in RelativeNumericProperty, which may
contain TableColLength in its tree.

Note that the method getTableUnits had apparently earlier been implemented in
Length. Traces of that are still present in the code.

Simon


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 44658] Incorrect table-unit computation if proportional-column-width() is used as a subexpression

2008-03-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44658





--- Comment #2 from Andreas L. Delmelle [EMAIL PROTECTED]  2008-03-24 
05:11:28 PST ---
Thinking of a fix, this seems to be all but trivial...

ColumnSetup can only detect if the specified width is a relative numeric, but
does not have access to the operands, so their type cannot be determined from
there.

One option being investigated:
- push getTableUnits() up in the hierarchy, and make it part of the Length
interface
- as such, RelativeNumericProperty and NumericProperty *must* also implement it
- NumericProperty can simply return 0
- RelativeNumericProperty can check its operands, and if there is a
TableColLength, call its getTableUnits() (possible tough nut: deeper nesting,
more complex expression tree?)
- ColumnSetup then only needs to know the column-width is a Length to know that
the call to getTableUnits() will succeed; if it is backed by an expression
(RelativeNumericProperty) the above should make sure that we also get a correct
number of units in that case


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 44658] Incorrect table-unit computation if proportional-column-width() is used as a subexpression

2008-03-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44658





--- Comment #3 from Andreas L. Delmelle [EMAIL PROTECTED]  2008-03-24 
13:04:33 PST ---
Created an attachment (id=21706)
 -- (https://issues.apache.org/bugzilla/attachment.cgi?id=21706)
Initial patch correcting the problem


Initial patch addresses the issue, and at the same time caters for expressions
like:

proportional-column-width(1) + proportional-column-width(0.5) - 1.5
table-units
max(proportional-column-width(1), proportional-column-width(1.5)) - 1.5
table-units

Strange as they may seem, they are definitely legal:
proportional-column-width() yields a numeric.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 44658] Incorrect table-unit computation if proportional-column-width() is used as a subexpression

2008-03-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44658





--- Comment #1 from Andreas L. Delmelle [EMAIL PROTECTED]  2008-03-23 
03:47:01 PST ---
Created an attachment (id=21701)
 -- (https://issues.apache.org/bugzilla/attachment.cgi?id=21701)
FO demonstrating the issue


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.