Re: Assertions in junit tests [was: Re: Solving FindBugs issue]

2011-02-22 Thread Andreas Delmelle
On 22 Feb 2011, at 08:50, Simon Pepping wrote: On Mon, Feb 21, 2011 at 08:28:33PM +0100, Andreas Delmelle wrote: I saw one exclusion --unconfirmed cast-- that would seem to stem from my recent refactoring in the BlockStackingLMs. Not sure why an exclusion was chosen here, but adding an

Re: Assertions in junit tests [was: Re: Solving FindBugs issue]

2011-02-22 Thread Andreas Delmelle
On 22 Feb 2011, at 19:04, Andreas Delmelle wrote: On 22 Feb 2011, at 08:50, Simon Pepping wrote: It would be nice if assertions were checked during the junit tests. However, when I set: junit ... jvm=java -ea/, I get junit.framework.AssertionFailedError errors. How can this be done?

Re: Assertions in junit tests [was: Re: Solving FindBugs issue]

2011-02-22 Thread Andreas Delmelle
On 22 Feb 2011, at 19:25, Andreas Delmelle wrote: One way to enable assertions I found so far, and that seems to work: - use fork=true on the junit target - insert: assertionsenabled //assertions in that target That seems to yield the expected behavior at first glance. Our junit targets

Re: Assertions in junit tests [was: Re: Solving FindBugs issue]

2011-02-22 Thread Glenn Adams
I support enabling assertions by default on junit tests. More testing is a good thing. G. On Tue, Feb 22, 2011 at 3:40 PM, Andreas Delmelle andreas.delme...@telenet.be wrote: On 22 Feb 2011, at 19:25, Andreas Delmelle wrote: One way to enable assertions I found so far, and that seems to

Re: Assertions in junit tests [was: Re: Solving FindBugs issue]

2011-02-21 Thread Simon Pepping
On Mon, Feb 21, 2011 at 08:28:33PM +0100, Andreas Delmelle wrote: I saw one exclusion --unconfirmed cast-- that would seem to stem from my recent refactoring in the BlockStackingLMs. Not sure why an exclusion was chosen here, but adding an assert statement in the code avoids the warning as