Re: [VOTE] merge branches/Temp_BasicSideFloats to trunk
Thank you to all that voted. Since there are no objections or bugs reported I will proceed with the merge. On 11/25/14, 2:41 PM, Luis Bernardo wrote: I would like to merge the branch branches/Temp_BasicSideFloats to trunk. The branch has a implementation of side floats that uses the same approach used when handling change in IPD across pages. These are the known limitations: -- the clear fo:float attribute is ignored; only the float attribute (left or right) is used -- overlapping of floats in the Y is not handled (even in the case there would not be overlap in the X direction) -- floats that extend beyond the body region are not properly handled and will overflow past the edge of the region -- if a float extends to bottom of the body region and there are footnotes in the page the float may overlap with the footnote region -- floats next to a table are not supported unless the start and end of the table happens in between the start and end of the float Examples can be found in the thread with subject RFC: basic side floats in this mailing list. To follow due process and since this will be a new major feature I am launching a vote. Please vote or report a bug before the end of Monday UTC, December 1st.
Re: [VOTE] merge branches/Temp_BasicSideFloats to trunk
Hi Luis, Great work. +1 from me. Thanks, Chris On 25/11/2014 14:41, Luis Bernardo wrote: I would like to merge the branch branches/Temp_BasicSideFloats to trunk. The branch has a implementation of side floats that uses the same approach used when handling change in IPD across pages. These are the known limitations: -- the clear fo:float attribute is ignored; only the float attribute (left or right) is used -- overlapping of floats in the Y is not handled (even in the case there would not be overlap in the X direction) -- floats that extend beyond the body region are not properly handled and will overflow past the edge of the region -- if a float extends to bottom of the body region and there are footnotes in the page the float may overlap with the footnote region -- floats next to a table are not supported unless the start and end of the table happens in between the start and end of the float Examples can be found in the thread with subject RFC: basic side floats in this mailing list. To follow due process and since this will be a new major feature I am launching a vote. Please vote or report a bug before the end of Monday UTC, December 1st.
RE: [VOTE] merge branches/Temp_BasicSideFloats to trunk
Really nice work Luis. I think this feature has been asked for quite a few times so it's excellent to have this and from your examples seems to work really well. +1 Robert Date: Thu, 27 Nov 2014 12:22:15 + From: bowditch_ch...@hotmail.com To: fop-dev@xmlgraphics.apache.org Subject: Re: [VOTE] merge branches/Temp_BasicSideFloats to trunk Hi Luis, Great work. +1 from me. Thanks, Chris On 25/11/2014 14:41, Luis Bernardo wrote: I would like to merge the branch branches/Temp_BasicSideFloats to trunk. The branch has a implementation of side floats that uses the same approach used when handling change in IPD across pages. These are the known limitations: -- the clear fo:float attribute is ignored; only the float attribute (left or right) is used -- overlapping of floats in the Y is not handled (even in the case there would not be overlap in the X direction) -- floats that extend beyond the body region are not properly handled and will overflow past the edge of the region -- if a float extends to bottom of the body region and there are footnotes in the page the float may overlap with the footnote region -- floats next to a table are not supported unless the start and end of the table happens in between the start and end of the float Examples can be found in the thread with subject RFC: basic side floats in this mailing list. To follow due process and since this will be a new major feature I am launching a vote. Please vote or report a bug before the end of Monday UTC, December 1st.
Re: [VOTE] merge branches/Temp_BasicSideFloats to trunk
Hi Luis, great job! +1 2014-11-25 15:41 GMT+01:00 Luis Bernardo lmpmberna...@gmail.com: I would like to merge the branch branches/Temp_BasicSideFloats to trunk. The branch has a implementation of side floats that uses the same approach used when handling change in IPD across pages. These are the known limitations: -- the clear fo:float attribute is ignored; only the float attribute (left or right) is used -- overlapping of floats in the Y is not handled (even in the case there would not be overlap in the X direction) -- floats that extend beyond the body region are not properly handled and will overflow past the edge of the region -- if a float extends to bottom of the body region and there are footnotes in the page the float may overlap with the footnote region -- floats next to a table are not supported unless the start and end of the table happens in between the start and end of the float Examples can be found in the thread with subject RFC: basic side floats in this mailing list. To follow due process and since this will be a new major feature I am launching a vote. Please vote or report a bug before the end of Monday UTC, December 1st. -- pascal
Re: [VOTE] merge branches/Temp_BasicSideFloats to trunk
Looks like a great addition, Luis! +1 from me! Cheers! Clay -- My religion is simple. My religion is kindness. - HH The Dalai Lama of Tibet On Nov 25, 2014, at 3:05 PM, Luis Bernardo lmpmberna...@gmail.com wrote: Includes layout tests. On 11/25/14, 5:14 PM, Glenn Adams wrote: What are your plans for testing? I haven't looked, but does your branch include new unit tests for this feature? On Tue, Nov 25, 2014 at 7:41 AM, Luis Bernardo lmpmberna...@gmail.com wrote: I would like to merge the branch branches/Temp_BasicSideFloats to trunk. The branch has a implementation of side floats that uses the same approach used when handling change in IPD across pages. These are the known limitations: -- the clear fo:float attribute is ignored; only the float attribute (left or right) is used -- overlapping of floats in the Y is not handled (even in the case there would not be overlap in the X direction) -- floats that extend beyond the body region are not properly handled and will overflow past the edge of the region -- if a float extends to bottom of the body region and there are footnotes in the page the float may overlap with the footnote region -- floats next to a table are not supported unless the start and end of the table happens in between the start and end of the float Examples can be found in the thread with subject RFC: basic side floats in this mailing list. To follow due process and since this will be a new major feature I am launching a vote. Please vote or report a bug before the end of Monday UTC, December 1st.
Re: [VOTE] merge branches/Temp_BasicSideFloats to trunk
What are your plans for testing? I haven't looked, but does your branch include new unit tests for this feature? On Tue, Nov 25, 2014 at 7:41 AM, Luis Bernardo lmpmberna...@gmail.com wrote: I would like to merge the branch branches/Temp_BasicSideFloats to trunk. The branch has a implementation of side floats that uses the same approach used when handling change in IPD across pages. These are the known limitations: -- the clear fo:float attribute is ignored; only the float attribute (left or right) is used -- overlapping of floats in the Y is not handled (even in the case there would not be overlap in the X direction) -- floats that extend beyond the body region are not properly handled and will overflow past the edge of the region -- if a float extends to bottom of the body region and there are footnotes in the page the float may overlap with the footnote region -- floats next to a table are not supported unless the start and end of the table happens in between the start and end of the float Examples can be found in the thread with subject RFC: basic side floats in this mailing list. To follow due process and since this will be a new major feature I am launching a vote. Please vote or report a bug before the end of Monday UTC, December 1st.
Re: [VOTE] merge branches/Temp_BasicSideFloats to trunk
in that case, +1 from me On Tue, Nov 25, 2014 at 4:05 PM, Luis Bernardo lmpmberna...@gmail.com wrote: Includes layout tests. On 11/25/14, 5:14 PM, Glenn Adams wrote: What are your plans for testing? I haven't looked, but does your branch include new unit tests for this feature? On Tue, Nov 25, 2014 at 7:41 AM, Luis Bernardo lmpmberna...@gmail.com wrote: I would like to merge the branch branches/Temp_BasicSideFloats to trunk. The branch has a implementation of side floats that uses the same approach used when handling change in IPD across pages. These are the known limitations: -- the clear fo:float attribute is ignored; only the float attribute (left or right) is used -- overlapping of floats in the Y is not handled (even in the case there would not be overlap in the X direction) -- floats that extend beyond the body region are not properly handled and will overflow past the edge of the region -- if a float extends to bottom of the body region and there are footnotes in the page the float may overlap with the footnote region -- floats next to a table are not supported unless the start and end of the table happens in between the start and end of the float Examples can be found in the thread with subject RFC: basic side floats in this mailing list. To follow due process and since this will be a new major feature I am launching a vote. Please vote or report a bug before the end of Monday UTC, December 1st.
