Re: hyphenation-present and junit-layout
On Sat, Oct 15, 2005 at 10:04:37AM +0200, Andreas L Delmelle wrote: I'm not following here... You will have regression tested code with certain parts not being tested because the optional feature necessary for running those tests smoothly isn't present. If presence of support for hyphenation (the respective patterns) is left to the potential developer, then the testing cycle should take into account that there is the possibility that hyphenation won't be present, and thus skip those hyph-dependent tests with a big warning. The tests won't *fail*. There just isn't enough info/resources available to even perform them. (Failure only becomes applicable if hyphenation is present, and the test can be run in a meaningful way.) That is true indeed. The tests will not fail. My focus is on the Ant target. I want an Ant target to run a predefined set of tests. And if this set includes hyphenation dependent tests, and the required hyphenation support is not available, the Ant target has failed. Simon -- Simon Pepping home page: http://www.leverkruid.nl
Re: hyphenation-present and junit-layout
On Oct 17, 2005, at 20:12, Simon Pepping wrote: On Sat, Oct 15, 2005 at 10:04:37AM +0200, Andreas L Delmelle wrote: The tests won't *fail*. There just isn't enough info/resources available to even perform them. (Failure only becomes applicable if hyphenation is present, and the test can be run in a meaningful way.) That is true indeed. The tests will not fail. Ah OK, now I'm following. My focus is on the Ant target. I want an Ant target to run a predefined set of tests. And if this set includes hyphenation dependent tests, and the required hyphenation support is not available, the Ant target has failed. I guess my thinking was along the lines of: - hyphenation is a feature which needs to be explicitly activated by the user (default value for hyphenate=false) - presence of the patterns is also optional (moved to OFFO) So, these two combined seem to clearly outline hyphenation as one aspect of the formatting process, with a right of its own, which can be tested separately/independently from other basic features. This only to further clarify my view in this matter. Cheers, Andreas
Re: hyphenation-present and junit-layout
On Fri, Oct 14, 2005 at 12:07:13AM +0200, Andreas L Delmelle wrote: On Oct 13, 2005, at 21:50, Simon Pepping wrote: But basically, why would anyone want to run regression tests without hyphenation present? Good point. I guess if there weren't any tests that don't require hyphenation support, we wouldn't be having this conversation... Anyway, since we don't distribute any patterns with FOP anymore, enforcing hyphenation to be present would mean that running the basic layout regression test suite straight off the trunk code would always result in failure of the whole target --which sounds a bit drastic. We are talking about regression tests by developers. You cannot say you have regression tested code if you have skipped a number of tests. Regards, Simon -- Simon Pepping home page: http://www.leverkruid.nl
Re: hyphenation-present and junit-layout
On Oct 13, 2005, at 21:50, Simon Pepping wrote: But basically, why would anyone want to run regression tests without hyphenation present? Good point. I guess if there weren't any tests that don't require hyphenation support, we wouldn't be having this conversation... Anyway, since we don't distribute any patterns with FOP anymore, enforcing hyphenation to be present would mean that running the basic layout regression test suite straight off the trunk code would always result in failure of the whole target --which sounds a bit drastic. Cheers, Andreas
hyphenation-present and junit-layout
I think junit-layout should fail if hyphenation-present is not true. Now the layoutengine tests are silently skipped when hyphenation is not present. Simon -- Simon Pepping home page: http://www.leverkruid.nl
Re: hyphenation-present and junit-layout
On Thu, 13 Oct 2005 04:26 am, Simon Pepping wrote: I think junit-layout should fail if hyphenation-present is not true. Now the layoutengine tests are silently skipped when hyphenation is not present. Fair enough - we could a) Just fail the whole layout test target b) Still run the layout and then only the hyphenation dependent tests will fail - not good as it will not continue after the first test failure c) Don't run the layout tests but give a prominent message that the tests have been skipped because of missing hyph support d) Factor out the hyph dependent tests into a separate test target and skip that with a warning Personally I tend towards c) Simon Manuel
