DO NOT REPLY [Bug 37236] [PATCH] Fix gradients and patterns

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=37236

taffy-tyler6...@hotmail.co.uk changed:

   What|Removed |Added

 CC||taffy-tyler6...@hotmail.co.
   ||uk

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 37236] [PATCH] Fix gradients and patterns

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=37236

Glenn Adams  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

--- Comment #16 from Glenn Adams  2012-04-11 06:15:59 UTC ---
change status from ASSIGNED to NEW for consistency

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 37236] [PATCH] Fix gradients and patterns

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=37236

Glenn Adams  changed:

   What|Removed |Added

   Priority|P3  |P2

--- Comment #15 from Glenn Adams  2012-04-11 03:21:04 UTC ---
increase priority for bugs with a patch

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 37236] [PATCH] Fix gradients and patterns

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=37236

Glenn Adams  changed:

   What|Removed |Added

   Priority|P2  |P3

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 37236] [PATCH] Fix gradients and patterns

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=37236

--- Comment #14 from Glenn Adams  2012-04-07 01:42:45 UTC ---
resetting P2 open bugs to P3 pending further review

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

DO NOT REPLY [Bug 37236] - [PATCH] Fix gradients and patterns

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37236





--- Additional Comments From [EMAIL PROTECTED]  2005-11-14 17:07 ---
(In reply to comment #12)

> > Is there anything outstanding concerning this bug or can we close it? 
> 
>As I see it there are two outstanding issues:
>   1) 'Complex' patterns on Text - While it is probably a 5% case it's 
>  bad that things won't work.
>   2) The overflow for pattern case being commented out.
> 
>I would lean towards saying this is still broken enough to leave the
> bug open, but it's not my bug DB (so to speak).  Having it open makes
> it at least possible that someone will have an answer to their question.

Ok.


> > I assume you'll also help track the currently commented part that 
> > we'll have to uncomment as soon as we can rely on a later Batik version.
> 
>I'll try and make sure of it.  What do you think of a Batik 1.6.1
> release?  There are a number of small but significant improvements
> in Batik since 1.6.1.  The real hurdle would be straightening out
> the XML lib lincensing (which really needs to be fixed anyways).

It's on my list to help you with the XML libs as soon as the FOP release is off
my desk. Anyway, I think a Batik 1.6.1 is a good idea. A lot of things have been
done since the last release.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 37236] - [PATCH] Fix gradients and patterns

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37236





--- Additional Comments From [EMAIL PROTECTED]  2005-11-14 14:29 ---
(In reply to comment #11)
> Patch #10 applied. Thanks.

> I'm looking forward to moving the Transcoders out after the FOP release. :-)

   It will likely make this stuff easier to track.

> Is there anything outstanding concerning this bug or can we close it? 

   As I see it there are two outstanding issues:
  1) 'Complex' patterns on Text - While it is probably a 5% case it's 
 bad that things won't work.
  2) The overflow for pattern case being commented out.

   I would lean towards saying this is still broken enough to leave the
bug open, but it's not my bug DB (so to speak).  Having it open makes
it at least possible that someone will have an answer to their question.

> It starts to get confusing which patches are to be applied and 
> so on. 

   Yes, I strongly considered going to a single PDFTranscoder patch instead
of trying to track everything seperately.

> I assume you'll also help track the currently commented part that 
> we'll have to uncomment as soon as we can rely on a later Batik version.

   I'll try and make sure of it.  What do you think of a Batik 1.6.1
release?  There are a number of small but significant improvements
in Batik since 1.6.1.  The real hurdle would be straightening out
the XML lib lincensing (which really needs to be fixed anyways).


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 37236] - [PATCH] Fix gradients and patterns

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37236





--- Additional Comments From [EMAIL PROTECTED]  2005-11-09 15:51 ---
Patch #10 applied. Thanks.
http://svn.apache.org/viewcvs?rev=332046&view=rev

I'm looking forward to moving the Transcoders out after the FOP release. :-)

Is there anything outstanding concerning this bug or can we close it? It starts
to get confusing which patches are to be applied and so on. I assume you'll also
help track the currently commented part that we'll have to uncomment as soon as
we can rely on a later Batik version.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 37236] - [PATCH] Fix gradients and patterns

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37236


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #16837|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2005-11-02 12:56 ---
Created an attachment (id=16853)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=16853&action=view)
Update to gradient repeat, fixed createGraphics problem.

This patch is an update to 16837.  It indirects the
access to jpegCount so all the PDFGraphics2D share
a common count.  This prevents inadvertant reuse of
the wrong image.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 37236] - [PATCH] Fix gradients and patterns

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37236





--- Additional Comments From [EMAIL PROTECTED]  2005-10-30 21:54 ---
Created an attachment (id=16837)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=16837&action=view)
Adds support for gradient repeat and transparency through rasterization

This patch adds the ability to rasterize 'unknown' paints
or paints that can't be mapped natively to PDF.  This
includes gradients with repeats, and or transparent stops.

This patch covers fill and stroke, however it does not
handle text.  This is because currently it works by treating
the paint as an image which it clips with the path to be
filled (it strokes the path using the JDK and the just 'fills'
it).  For text this would require turning the text into outlines.

A better way to do this would be to turn the image into a tile
pattern (which would be expected to be used only once), but
the transforms to pull this off are non-trivial, also I'm not
sure I know quite enough PDF to get this right.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 37236] - [PATCH] Fix gradients and patterns

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37236


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Keywords||PatchAvailable
Summary|Fix gradients and patterns  |[PATCH] Fix gradients and
   ||patterns




--- Additional Comments From [EMAIL PROTECTED]  2005-10-26 23:17 ---
(In reply to comment #7)
> Created an attachment (id=16810)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=16810&action=view) 
[edit]
> Update to gradient transform fix, passes all junit tests.

Patch applied. Thanks.

> This replaces the first patch (it has the imporant bits of the
> second patch commented out as well).
> 
> This eliminates the concatenations list, but resets the Data
> transform after each push.  When the PDFRenderer want's to
> rebuild state it just uses the transforms from the individual
> data elements (rather than all of the concatenations).

Looks good to me.

> This appears to pass all of the JUnit tests but since this
> is the first time I've tried to run them it's a bit hard to
> know what this really means (is the PDF output checked for 
> example? Is there PDF output?).

The JUnit test can currently only check the FO tree and the layout engine, not
the renderers. We have a special renderer, the area tree renderer, which writes
out the area tree to an XML file and we use XPath statements to check against
this XML file. The area tree is the thing that the renderers convert to the
final output format, so we're only checking the input for the renderers, not
their output.

I've written a small tool (BatchDiffer) which can create diff images from
PDF/PS/Java2D output, but it's not integrated into JUnit, yet, and rather
designed for manual visual checking. I've actually stolen a few lines of code
from Batik for that. :-) The problem with checking PDF and PS is that you need
an external tool like GhostScript to convert PDF/PS to PNG so we could do
automated diff testing. We used to do checksum testing on the PDF files but
that's not really useful. Some way to go, one step at a time

I'm leaving the issue open so we can look at the overflow thing ASAP.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.