DO NOT REPLY [Bug 38264] Hyphenation does not play well with preserved linefeed-treatment or white-space-treatment
https://issues.apache.org/bugzilla/show_bug.cgi?id=38264 Glenn Adams gl...@skynav.com changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #14 from Glenn Adams gl...@skynav.com 2012-04-01 06:18:48 UTC --- batch transition to closed; if someone wishes to restore one of these to resolved in order to perform a verification step, then feel free to do so -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 38264] Hyphenation does not play well with preserved linefeed-treatment or white-space-treatment
https://issues.apache.org/bugzilla/show_bug.cgi?id=38264 Andreas L. Delmelle adelme...@apache.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #13 from Andreas L. Delmelle adelme...@apache.org 2010-11-25 16:31:26 EST --- Both issues fixed in r1039188: - combination of linefeed-preserve and hyphenation failed for the reasons described in earlier comments. After having inverted the main loop in LineLM.createLineBreaks() (see r956271), the fix was to modify TextLM.applyChanges() and TextLM.getChangedKnuthElements() to account for the fact that they can be called multiple times for the same instance. Additionally, needed to make sure LineLM.hyphenationPerformed is only set if the last paragraph has been hyphenated. Otherwise, hyphenation would be bypassed for all paragraphs following the first preserved linefeed in a block. After modification, hyphenation is only bypassed in case of a re-entry due to changing page-ipd. - combination of white-space-treatment=preserve and hyphenation failed due to an oversight that has probably been present for a while. See LineLM.addInlineArea(), around line 1515: lastLM was only set in case white-space-treatment is not preserve. If white-space was preserved, this caused the call to LayoutContext.setFlags() some 70-75 lines further down to set LAST_AREA to false (childLM == lastLM), which in turn caused TextLM to ignore the hyphenation character when building the area. Fix was to make sure that lastLM always points to the LM of the last KnuthElement in the sequence to be processed. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 38264] Hyphenation does not play well with preserved linefeed-treatment or white-space-treatment
https://issues.apache.org/bugzilla/show_bug.cgi?id=38264 Andreas L. Delmelle adelme...@apache.org changed: What|Removed |Added CC||ar...@pinguins.dyndns.org --- Comment #12 from Andreas L. Delmelle adelme...@apache.org 2010-06-16 14:20:08 EDT --- *** Bug 49411 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 38264] Hyphenation does not play well with preserved linefeed-treatment or white-space-treatment
https://issues.apache.org/bugzilla/show_bug.cgi?id=38264 Andreas L. Delmelle adelme...@apache.org changed: What|Removed |Added CC||wzieg...@t-online.de --- Comment #11 from Andreas L. Delmelle adelme...@apache.org 2009-01-29 13:28:15 PST --- *** Bug 10374 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 38264] Hyphenation does not play well with preserved linefeed-treatment or white-space-treatment
https://issues.apache.org/bugzilla/show_bug.cgi?id=38264 Johans Marvin Taboada Villca [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 38264] Hyphenation does not play well with preserved linefeed-treatment or white-space-treatment
https://issues.apache.org/bugzilla/show_bug.cgi?id=38264 --- Comment #10 from Andreas L. Delmelle [EMAIL PROTECTED] 2008-05-06 08:06:37 PST --- Status update: The main difficulty seems to be that the principal iteration in LineLM.createLineBreaks() iterates in reverse order. As a result, applyChanges() is called first for the last Paragraph if the TextLM generates multiple paragraphs. Now, while we can keep track of the changed position indices and limit both applyChanges() and getChangedKnuthElements() to operate only on the portion corresponding to oldList, by the time the next-to-last paragraph is processed, the changed positions for the last one should again be modified to take into account added/removed areas for the changes to the preceding one. I made such changes locally, and this does avoid the duplication, however, keeping track of the bounding indices is turning out to be quite a pain. As soon as the first paragraph has hyphenation points, the positions pointing into the later paragraphs will be wrong... -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 38264] Hyphenation does not play well with preserved linefeed-treatment or white-space-treatment
https://issues.apache.org/bugzilla/show_bug.cgi?id=38264 --- Comment #9 from Andreas L. Delmelle [EMAIL PROTECTED] 2008-05-05 07:27:25 PST --- Trying to gain more understanding of this issue, and as I see it, the full story wrt linefeed-treatment='preserve' and hyphenate='true' is: 1) for blocks of text containing preserved linefeeds, the TextLayoutManager actually generates multiple Paragraphs (see TextLM.getNextKnuthElements() - in case of an explicit break, the 'current' sequence is ended, and a new one is added to the returnList) 2) the optimal line-breaks are determined by the LineLayoutManager per Paragraph ( see LineLM.createLineBreaks() ) 3) the hyphenation-points are determined for each Paragraph in the same loop ( see LineLM.findOptimalBreakingPoints() ) 4) BUT: the integration of hyphenation-points (applyChanges() and getChangedKnuthElements()) operate on the TextLayoutManager instance as a whole. = the entire content generated by the TextLM in question is copied as many times as there are paragraphs/preserved linefeeds in the source Mainly TextLM.getChangedKnuthElements() is a bit problematic in this regard: every time this is called, it generates an element-list based on the complete set of AreaInfos for the LM. In LineLM.findHyphenationPoints(), each of the original paragraphs is replaced by that list. I already tried to change that method to take into account the position-indices of the first and last element in the parameter oldList. This already gets me somewhat further, but still far from committable... -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 38264] Hyphenation does not play well with preserved linefeed-treatment or white-space-treatment
https://issues.apache.org/bugzilla/show_bug.cgi?id=38264 Andreas L. Delmelle [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #8 from Andreas L. Delmelle [EMAIL PROTECTED] 2008-05-04 10:54:00 PST --- In the meantime, managed to track down the source of the problem with linefeed-treatment=preserve. Nothing inherently wrong with the hyphenation loop itself. After the hyphenation-points have been determined, and the updates are processed is where it goes wrong. See LineLayoutManager.findHyphenationPoints(), second main loop. For each Paragraph, the corresponding TextLayoutManager.applyChanges() and .getChangedKnuthElements() are used. Checking the implementations for those latter two methods reveals that they do not take into account that they can be called multiple times for the same instance. The former always sets the 'returnedIndex' member to 0, which leads to the duplication if the latter is called twice. Each subparagraph in the main paragraph is replaced by a copy of the main paragraph... Now still looking for a solution :/ -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 38264] - Hyphenation does not play well with preserved linefeed-treatment or white-space-treatment
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38264. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38264 [EMAIL PROTECTED] changed: What|Removed |Added Summary|linefeed- |Hyphenation does not play |treatment=preserve|well with preserved |hyphenate=true : INCORRECT|linefeed-treatment or white- |+ Duplicates the text!!!|space-treatment --- Additional Comments From [EMAIL PROTECTED] 2007-12-13 08:41 --- Another problem related to hyphenation and preserved white-space: when white-space-treatment is set to preserve, words are hyphenated correctly but the hyphen does not show up. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 38264] - Hyphenation does not play well with preserved linefeed-treatment or white-space-treatment
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38264. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38264 --- Additional Comments From [EMAIL PROTECTED] 2007-12-13 08:43 --- Created an attachment (id=21274) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=21274action=view) Hyphens do not show up when white-space-treatment=preserve -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
