DO NOT REPLY [Bug 48548] [PATCH] FOP doesn't support change bar generation
https://issues.apache.org/bugzilla/show_bug.cgi?id=48548 Glenn Adams changed: What|Removed |Added Priority|P3 |P2 --- Comment #17 from Glenn Adams 2012-04-11 03:22:08 UTC --- increase priority for bugs with a patch -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48548] [PATCH] FOP doesn't support change bar generation
https://issues.apache.org/bugzilla/show_bug.cgi?id=48548 Glenn Adams changed: What|Removed |Added Priority|P2 |P3 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48548] [PATCH] FOP doesn't support change bar generation
https://issues.apache.org/bugzilla/show_bug.cgi?id=48548 --- Comment #16 from Glenn Adams 2012-04-07 01:45:06 UTC --- resetting P2 open bugs to P3 pending further review -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48548] [PATCH] FOP doesn't support change bar generation
https://issues.apache.org/bugzilla/show_bug.cgi?id=48548 Stephan Thesing changed: What|Removed |Added Attachment #26745|0 |1 is obsolete|| --- Comment #15 from Stephan Thesing 2011-05-12 17:41:57 UTC --- Created attachment 26991 --> https://issues.apache.org/bugzilla/attachment.cgi?id=26991 Updated patch for trunk as of 12.5.2011 Patch for change bar generation updated for trunk as of 12.5.2011 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48548] [PATCH] FOP doesn't support change bar generation
https://issues.apache.org/bugzilla/show_bug.cgi?id=48548 Stephan Thesing changed: What|Removed |Added Attachment #25098|0 |1 is obsolete|| Attachment #26741|0 |1 is obsolete|| --- Comment #14 from Stephan Thesing 2011-03-08 15:50:58 EST --- Created an attachment (id=26745) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26745) Patch against /trunk 20110308 An updated patch, last patch did not include changes to AbstractPathOrientedRenderer.java -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48548] [PATCH] FOP doesn't support change bar generation
https://issues.apache.org/bugzilla/show_bug.cgi?id=48548 --- Comment #13 from Stephan Thesing 2011-03-07 16:28:00 EST --- Created an attachment (id=26741) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26741) New change bar patch against /trunk Attached is a new patch that adds change bar output and change-bar-begin/end processing. The output is done in AbstractRenderer.java by drawing change bar areas if an area to be drawn is affected by change bars. As such, it is not very efficient, i.e., it is not checked, if change bars areas overlap. Also, when drawing change bars for consecutive lines, the change bars are drawn with the same height as the line area, causing gaps between the change bars (as lines are offset). This has been run through checkstyle. The remaining functionality is very much the same as the first patch presented one year (sic) ago. Although 46 files are touched, most changes are quite trivial (adding recording of change bars at areas or layout managers). The test case attached to this PR is now handled correctly. Missing: Unit tests extensive testing. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48548] [PATCH] FOP doesn't support change bar generation
https://issues.apache.org/bugzilla/show_bug.cgi?id=48548 --- Comment #12 from Stephan Thesing 2010-12-20 16:21:52 EST --- (In reply to comment #11) > (In reply to comment #9) > > Created an attachment (id=25114) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25114) [details] [details] > > Simple document to test change bars > > > > I created a simple document to test the change-bar feature and it doesn't > > seem > > to work. The change bar starts and finishes too early. > > yes, the logic for which elements are under change-bar influence were wrong. > > A fop element should only be displayed with a a change bar, if it is _totally_ > between a change-bar-begin and change-bar-end. > > I have a new implementation and will try to update the patch against trunk > some time this or next week. > > With that new version, the example is displayed OK. Oh, forgot to mention: the issue with wrong placement of change bars in e.g. tables is also resolved with the new patch. Reason was, that for area that are reference-areas, the (absolute) position of the margins (where cb are to be placed) has to be tracked too, as the reference system is shifted inside the area. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48548] [PATCH] FOP doesn't support change bar generation
https://issues.apache.org/bugzilla/show_bug.cgi?id=48548 --- Comment #11 from Stephan Thesing 2010-12-20 16:18:45 EST --- (In reply to comment #9) > Created an attachment (id=25114) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25114) [details] > Simple document to test change bars > > I created a simple document to test the change-bar feature and it doesn't seem > to work. The change bar starts and finishes too early. yes, the logic for which elements are under change-bar influence were wrong. A fop element should only be displayed with a a change bar, if it is _totally_ between a change-bar-begin and change-bar-end. I have a new implementation and will try to update the patch against trunk some time this or next week. With that new version, the example is displayed OK. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48548] [PATCH] FOP doesn't support change bar generation
https://issues.apache.org/bugzilla/show_bug.cgi?id=48548 --- Comment #10 from Vincent Hennebert 2010-03-18 11:43:24 UTC --- I've just created a temporary branch for the implementation of change bars: http://svn.eu.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_ChangeBars Stephan, please create your patches against that branch from now on. You don't need to check out the branch, you can just switch your local copy by running the following at the root: svn switch http://svn.eu.apache.org/repos/asf/xmlgraphics/fop/branches/Temp_ChangeBars I'm going to apply the patch bits by bits, as issues are being resolved. I've concentrated on the FO part so far. More later. Vincent -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48548] [PATCH] FOP doesn't support change bar generation
https://issues.apache.org/bugzilla/show_bug.cgi?id=48548 --- Comment #9 from Vincent Hennebert 2010-03-11 11:55:48 UTC --- Created an attachment (id=25114) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25114) Simple document to test change bars I created a simple document to test the change-bar feature and it doesn't seem to work. The change bar starts and finishes too early. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 48548] [PATCH] FOP doesn't support change bar generation
https://issues.apache.org/bugzilla/show_bug.cgi?id=48548 Vincent Hennebert changed: What|Removed |Added Summary|FOP doesn't support change |[PATCH] FOP doesn't support |bar generation |change bar generation -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
