Re: More style issues

2005-10-03 Thread J.Pietschmann
Jeremias Maerki wrote: But I'll never define a variable called blockProgressionDimension! I was after weirder stuff. Some random picks: - availIPD (but availableBPD used elsewhere) - avgWidth (but averageLineLength used elsewhere) - bHyph (but hyphen/hyphenate/hyphenation used lesewhere) - bInW

Re: More style issues

2005-09-10 Thread Simon Pepping
On Fri, Sep 09, 2005 at 08:38:18AM +0800, Manuel Mall wrote: > On Fri, 9 Sep 2005 07:55 am, J.Pietschmann wrote: > > Hi devs, > > while examining the Checkstyle and JavaDoc complaints I > > got a few more questions about the FOP style: > > 1. There is still quite a bit of hungarian notation here an

Re: More style issues

2005-09-10 Thread Andreas L Delmelle
On Sep 9, 2005, at 01:55, J.Pietschmann wrote: while examining the Checkstyle and JavaDoc complaints I got a few more questions about the FOP style: +1 from me on all three points. Cheers, Andreas

Re: More style issues

2005-09-09 Thread Peter B. West
Jeremias Maerki wrote: +1 to all three points. But I'll never define a variable called blockProgressionDimension! That's always going to be bpd for me, but then ipd and bpd are so omnipresent so it shouldn't be a problem. blockProgressionDimension or blockProgressionDirection? Exceptions prov

Re: More style issues

2005-09-09 Thread Jeremias Maerki
+1 to all three points. But I'll never define a variable called blockProgressionDimension! That's always going to be bpd for me, but then ipd and bpd are so omnipresent so it shouldn't be a problem. Exceptions prove the rule, don't they? :-) On 09.09.2005 01:55:06 J.Pietschmann wrote: > Hi devs, >

Re: More style issues

2005-09-08 Thread Manuel Mall
Joerg, thank you for looking into this - fixing typos and style issues in other peoples code is really quite a gruelling task. And trying to get agreement on style issues in a community of developers is virtually impossible, isn't it :-), as we all have our own likes and dislikes. On Fri, 9 S

More style issues

2005-09-08 Thread J.Pietschmann
Hi devs, while examining the Checkstyle and JavaDoc complaints I got a few more questions about the FOP style: 1. There is still quite a bit of hungarian notation here and there. Hungarian notation generally sucks unless it is consistently applied. Furthermore, it is systems hungarian (see http