Re: junit-layout-standard test broken

2007-07-12 Thread Vincent Hennebert
Adrian Cumiskey a écrit :
 The junit-layout-standard target seems to broken on trunk...

My bad, sorry. I didn't think of table cells with content of zero
length, which was the root of the problem... I've committed a temporary
hack as I'm in the process of heavily changing this part of the code.
Lazily I ran only the table-related tests before committing. *Always*
run the entire testsuite...

Sorry again, and many thanks for spotting this, Adrian.

Vincent



Re: junit-layout-standard test broken

2007-07-12 Thread Andreas L Delmelle

On Jul 12, 2007, at 15:49, Vincent Hennebert wrote:


Adrian Cumiskey a écrit :

The junit-layout-standard target seems to broken on trunk...


My bad, sorry. I didn't think of table cells with content of zero
length, which was the root of the problem... I've committed a  
temporary

hack as I'm in the process of heavily changing this part of the code.
Lazily I ran only the table-related tests before committing. *Always*
run the entire testsuite...

Sorry again, and many thanks for spotting this, Adrian.


Cool! I thought these errors were caused by some local changes I  
made. So it wasn't me after all. :)



Later

Andreas



Re: junit-layout-standard test broken

2007-07-12 Thread Adrian Cumiskey
I thought for a moment it was my font detection patch until I sanity 
checked myself and built a fresh trunk :-)


Adrian.

Andreas L Delmelle wrote:

On Jul 12, 2007, at 15:49, Vincent Hennebert wrote:


Adrian Cumiskey a écrit :

The junit-layout-standard target seems to broken on trunk...


My bad, sorry. I didn't think of table cells with content of zero
length, which was the root of the problem... I've committed a temporary
hack as I'm in the process of heavily changing this part of the code.
Lazily I ran only the table-related tests before committing. *Always*
run the entire testsuite...

Sorry again, and many thanks for spotting this, Adrian.


Cool! I thought these errors were caused by some local changes I made. 
So it wasn't me after all. :)



Later

Andreas