Re: svn commit: r1338605 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/afp/fonts/ src/java/org/apache/fop/afp/ptoca/ src/java/org/apache/fop/render/afp/ test/java/org/apache/fop/afp/fonts/

2012-05-15 Thread Glenn Adams
thanks!

On Tue, May 15, 2012 at 8:53 AM, mehdi houshmand  wrote:

> Yeah fair play on this one, in all honesty I was being lazy this time.


Re: svn commit: r1338605 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/afp/fonts/ src/java/org/apache/fop/afp/ptoca/ src/java/org/apache/fop/render/afp/ test/java/org/apache/fop/afp/fonts/

2012-05-15 Thread mehdi houshmand
Yeah fair play on this one, in all honesty I was being lazy this time.

On 15 May 2012 15:42, Glenn Adams  wrote:

> Could you file a bug and reference it against this commit? Most commits
> that change code, except perhaps one that is a trivial fix to a immediately
> prior checkin or a cleanup fix, should have a bug filed that corresponds to
> the commit. That allows us to have a better document trail for the commit,
> one purpose of which is to summarize the commit at the time of next
> release. From the commit message below, I have no idea what this commit
> does specifically. So when it comes time for a release, I expect it will
> not be summarized, or the summary will be equally non-descript.
>
>
> On Tue, May 15, 2012 at 3:07 AM,  wrote:
>
>> Author: mehdi
>> Date: Tue May 15 09:07:02 2012
>> New Revision: 1338605
>>
>> URL: http://svn.apache.org/viewvc?rev=1338605&view=rev
>> Log:
>> Improved handling of AFP double-byte character sets
>>
>
>


Re: svn commit: r1338605 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/afp/fonts/ src/java/org/apache/fop/afp/ptoca/ src/java/org/apache/fop/render/afp/ test/java/org/apache/fop/afp/fonts/

2012-05-15 Thread Glenn Adams
Could you file a bug and reference it against this commit? Most commits
that change code, except perhaps one that is a trivial fix to a immediately
prior checkin or a cleanup fix, should have a bug filed that corresponds to
the commit. That allows us to have a better document trail for the commit,
one purpose of which is to summarize the commit at the time of next
release. From the commit message below, I have no idea what this commit
does specifically. So when it comes time for a release, I expect it will
not be summarized, or the summary will be equally non-descript.

On Tue, May 15, 2012 at 3:07 AM,  wrote:

> Author: mehdi
> Date: Tue May 15 09:07:02 2012
> New Revision: 1338605
>
> URL: http://svn.apache.org/viewvc?rev=1338605&view=rev
> Log:
> Improved handling of AFP double-byte character sets
>