Findbugs Warnings Outstanding
*Dodgy Warnings* *Code* *Warning* *BC* Unchecked/unconfirmed cast from org.apache.fop.accessibility.StructureTreeElement to org.apache.fop.pdf.PDFStructElem in org.apache.fop.render.pdf.PDFStructureTreeBuilder.startNode(String, Attributes, StructureTreeElement)
findbugs warnings
I see someone hasn't been running findbugs: Dodgy Warnings CodeWarningBC Unchecked/unconfirmed cast from org.apache.fop.accessibility.StructureTreeElement to org.apache.fop.pdf.PDFStructElem in org.apache.fop.render.pdf.PDFStructureTreeBuilder.startNode(String, Attributes, StructureTreeElement) DLSDead store to logFactory in new org.apache.fop.cli.CommandLineOptions() DLSDead store to logFactory in org.apache.fop.fonts.apps.PFMReader.main(String[]) DLSDead store to logFactory in org.apache.fop.fonts.apps.TTFReader.main(String[]) Could the responsible party please fix? Thanks.
[jira] [Resolved] (FOP-2192) checkstyle and findbugs warnings
[ https://issues.apache.org/jira/browse/FOP-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Glenn Adams resolved FOP-2192. -- Resolution: Fixed Fix Version/s: trunk http://svn.apache.org/viewvc?view=revision&revision=1435269 http://svn.apache.org/viewvc?view=revision&revision=1435270 > checkstyle and findbugs warnings > > > Key: FOP-2192 > URL: https://issues.apache.org/jira/browse/FOP-2192 > Project: Fop > Issue Type: Bug > Components: general >Affects Versions: trunk >Reporter: Glenn Adams >Assignee: Glenn Adams > Fix For: trunk > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (FOP-2192) checkstyle and findbugs warnings
Glenn Adams created FOP-2192: Summary: checkstyle and findbugs warnings Key: FOP-2192 URL: https://issues.apache.org/jira/browse/FOP-2192 Project: Fop Issue Type: Bug Components: general Affects Versions: trunk Reporter: Glenn Adams Assignee: Glenn Adams -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: new checkstyle/findbugs warnings
Thanks. I've applied the patch. On Mon, Dec 31, 2012 at 5:26 AM, Robert Meyer wrote: > Hi Glenn, > > Apologies for introducing those issues. I'll make sure to double check > before posting a patch in future. I have created the following Jira issue > for this: > > https://issues.apache.org/jira/browse/FOP-2179 > > I have updated it with a patch to resolve the issues, so if someone gets a > chance to take a look that would be great. > > Regards, > > Robert Meyer > > -- > From: gl...@skynav.com > Date: Sat, 29 Dec 2012 10:49:03 -0600 > Subject: new checkstyle/findbugs warnings > To: phanc...@apache.org > CC: fop-dev@xmlgraphics.apache.org > > > peter, your recent commit (below) introduced 7 new checkstyle warnings and > 1 findbugs error; please fix and try to remember to check in future before > committing, thanks, glenn > > commit c32a1a7eca7607b0570d5e3f68e81a5a768f5e10 > Author: Peter Hancock > Date: Thu Dec 13 11:41:49 2012 + > > Bugzilla 37114: Implementation of changes necessary to warn of invalid > property values. > Contributed by Robert Meyer. > > > git-svn-id: > https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@142123813f79535-47bb-0310-9956-ffa450edef68 > >
RE: new checkstyle/findbugs warnings
Hi Glenn, Apologies for introducing those issues. I'll make sure to double check before posting a patch in future. I have created the following Jira issue for this: https://issues.apache.org/jira/browse/FOP-2179 I have updated it with a patch to resolve the issues, so if someone gets a chance to take a look that would be great. Regards, Robert Meyer From: gl...@skynav.com Date: Sat, 29 Dec 2012 10:49:03 -0600 Subject: new checkstyle/findbugs warnings To: phanc...@apache.org CC: fop-dev@xmlgraphics.apache.org peter, your recent commit (below) introduced 7 new checkstyle warnings and 1 findbugs error; please fix and try to remember to check in future before committing, thanks, glenn commit c32a1a7eca7607b0570d5e3f68e81a5a768f5e10 Author: Peter Hancock Date: Thu Dec 13 11:41:49 2012 + Bugzilla 37114: Implementation of changes necessary to warn of invalid property values. Contributed by Robert Meyer. git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1421238 13f79535-47bb-0310-9956-ffa450edef68
new checkstyle/findbugs warnings
peter, your recent commit (below) introduced 7 new checkstyle warnings and 1 findbugs error; please fix and try to remember to check in future before committing, thanks, glenn commit c32a1a7eca7607b0570d5e3f68e81a5a768f5e10 Author: Peter Hancock Date: Thu Dec 13 11:41:49 2012 + Bugzilla 37114: Implementation of changes necessary to warn of invalid property values. Contributed by Robert Meyer. git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@142123813f79535-47bb-0310-9956-ffa450edef68
zero checkstyle/findbugs warnings!!
i just fast forwarded 31 checkins into my copy of trunk and built, tested, checked styles and ran findbugs, and ZERO style errors or findbugs warnings are reported!! i'm very happy to see that we are now paying attention to code quality testing in a real way, so congratulations dev team! best regards, glenn
