I don't think it causes any problems. I don't see the reason why the whole
commit should be reverted. If something then perhaps deprecation warning
could be removed. I'd still prefer communuty-templates using macros instead
of internal objects.
--
Marek
Odesláno pomocí AquaMail pro Android
ht
Maybe the best thing to do for now it to revert it and send a PR to the RFC
repo for a proper discussion?
On Fri, Jan 13, 2017 at 2:26 PM, Daniel Lobato Garcia
wrote:
> On 01/12, Marek Hulán wrote:
> > >
> > > > I strongly disagree that this does not have big benefits. Using
> internal
> > > >
If this will help with getting reviews or directing reviews then sounds all
good. The bot could handle this afaik as long as they are predictable which
is which.
On Jan 12, 2017 6:26 AM, "Ewoud Kohl van Wijngaarden" <
ew...@kohlvanwijngaarden.nl> wrote:
> Hello all,
>
> Since there are multiple t
Thanks all, and sorry for the delay. Some inline comments and the final
draft attached separately :P
Ori Rabin wrote:
Maybe the question: How would you rate our user support? can have links
instead of bringing back the do you know our IRC question?
I like that, added.
Tomas Strachota wrote:
On 01/11, Timo Goebel wrote:
> Hi devs,
>
> I'm usually not very easily annoyed. What get's me started though
> eventually is when things don't work properly.
> HoundCI is one of those things.
>
> My main concern is, that I get an e-mail and/or Github notification for
> every single comment. These
On 01/12, Daniel Kuffner wrote:
> Hi All,
>
> Does anybody know how to fix the issue?
I also saw it - https://github.com/Katello/katello/pull/6541
>
> The template seems to exist:
>
> /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.2.1.1/app/views/katello/api/v2/content_facet/base_with_ro
On 01/12, Marek Hulán wrote:
> >
> > > I strongly disagree that this does not have big benefits. Using internal
> > > Foreman objects in templates is a bad practice. It blocks us from
> > > improving
> > > our code. Therefore it's very important to build a DSL that users can use
> > > in templates
+1 from me - image deployment for hardware makes sense IMO. It's
definitely something others have been thinking about - I'll leave Lukas
to go into more detail, but here's something you could go take a look at
:)
https://github.com/theforeman/foreman-discovery-image/pull/44
Greg
--
You recei
