Hello,
In general, I agree with what Marek said. Since I was part of the original
discussion that started this whole thread, I feel obliged to put in my 2¢.
Obviously we all want test to be all green before merging any PR. Still,
there are certain cases where tests are red in which I believe usin
On Fri, Sep 1, 2017 at 8:56 AM, Marek Hulán wrote:
> Thanks Timo for your input. Please see my comment below in the text.
>
> On čtvrtek 31. srpna 2017 23:08:34 CEST Timo Goebel wrote:
>> Am 28.08.17 um 17:12 schrieb Marek Hulán:
>> > 1) codeclimate is red
>> >
>> > This can be ignored, we never a
On Tue, Aug 29, 2017 at 11:25 AM, Daniel Lobato Garcia
wrote:
> On 08/28, Marek Hulán wrote:
>> Hello devs,
>>
>> since there was a discussion on foreman-dev IRC channel recently about
>> merging
>> PRs in Foreman core even if there's some build failed, I talked to few people
>> and decided to de
Thanks Timo for your input. Please see my comment below in the text.
On čtvrtek 31. srpna 2017 23:08:34 CEST Timo Goebel wrote:
> Am 28.08.17 um 17:12 schrieb Marek Hulán:
> > 1) codeclimate is red
> >
> > This can be ignored, we never agreed on using this as a hard metric for
> > the
> > PR. The
On Thu, Aug 31, 2017 at 5:08 PM, Timo Goebel wrote:
> Am 28.08.17 um 17:12 schrieb Marek Hulán:
>
>> 1) codeclimate is red
>>
>> This can be ignored, we never agreed on using this as a hard metric for
>> the
>> PR. The motivation to introduce it was mainly to save some time to
>> reviewer.
>> We
Am 28.08.17 um 17:12 schrieb Marek Hulán:
1) codeclimate is red
This can be ignored, we never agreed on using this as a hard metric for the
PR. The motivation to introduce it was mainly to save some time to reviewer.
We don't have to run it manually to get indications whether there's something
i
On 08/28, Marek Hulán wrote:
> Hello devs,
>
> since there was a discussion on foreman-dev IRC channel recently about merging
> PRs in Foreman core even if there's some build failed, I talked to few people
> and decided to describe here what I think is current way of how it works. I'm
> also attach
Hello devs,
since there was a discussion on foreman-dev IRC channel recently about merging
PRs in Foreman core even if there's some build failed, I talked to few people
and decided to describe here what I think is current way of how it works. I'm
also attaching one suggestion at the end that ca
