Re: Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

2017-12-07 Thread Andrew Kofink
> > notification updates (they're cached) are only a hassle because they're > logged Agreed. In development, the extra logs make debugging more difficult; performance is not the motivation. On Thu, Dec 7, 2017 at 10:08 AM, Daniel Lobato Garcia wrote: > On 12/06, Ohad Levy wrote: > > On Wed, De

Re: Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

2017-12-07 Thread Daniel Lobato Garcia
On 12/06, Ohad Levy wrote: > On Wed, Dec 6, 2017 at 9:10 PM, Walden Raines wrote: > > > > Oh yeah, especially notifications. Why can't they just update when the > > page updates? > > > > I think it would be good to move the notifications to a websocket approach > > instead of polling. I know, I k

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

2017-12-06 Thread Ohad Levy
On Wed, Dec 6, 2017 at 9:10 PM, Walden Raines wrote: > > Oh yeah, especially notifications. Why can't they just update when the > page updates? > > I think it would be good to move the notifications to a websocket approach > instead of polling. I know, I know, PRs welcome :) > We can consider u

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

2017-12-06 Thread Walden Raines
> Oh yeah, especially notifications. Why can't they just update when the page updates? I think it would be good to move the notifications to a websocket approach instead of polling. I know, I know, PRs welcome :) On Wed, Dec 6, 2017 at 1:23 PM, Ohad Levy wrote: > > > On Dec 6, 2017 12:19 PM, "

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

2017-12-06 Thread Ohad Levy
On Dec 6, 2017 12:19 PM, "Ivan Necas" wrote: The only concern, as the users are used to the auto-refresh, once we turn that off, they can start thinking the thing got stuck. In that case let's keep updating the talk progress without replacing the entire tab? -- Ivan On Wed, 6 Dec 2017 at 17:

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

2017-12-06 Thread Ivan Necas
The only concern, as the users are used to the auto-refresh, once we turn that off, they can start thinking the thing got stuck. -- Ivan On Wed, 6 Dec 2017 at 17:50, Ohad Levy wrote: > On Wed, Dec 6, 2017 at 6:48 PM, Andrew Kofink wrote: > >> As part of this I would love to see *all* auto relo

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

2017-12-06 Thread Ohad Levy
On Wed, Dec 6, 2017 at 6:48 PM, Andrew Kofink wrote: > As part of this I would love to see *all* auto reloads default to off >> > +1 - PR are welcomes ;) > Oh yeah, especially notifications. Why can't they just update when the > page updates? > > On Wed, Dec 6, 2017 at 11:27 AM, Walden Raines

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

2017-12-06 Thread Andrew Kofink
> > As part of this I would love to see *all* auto reloads default to off Oh yeah, especially notifications. Why can't they just update when the page updates? On Wed, Dec 6, 2017 at 11:27 AM, Walden Raines wrote: > > I think the refresh should still be off by default. > > As part of this I wou

Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

2017-12-06 Thread Walden Raines
> I think the refresh should still be off by default. As part of this I would love to see *all* auto reloads default to off. The dashboard, for example, constantly reloading by default is annoying to me. Cheers, Walden On Wed, Dec 6, 2017 at 11:16 AM, Andrew Kofink wrote: > Hello, > > We have