Re: [foreman-dev] Merge foreman-bats into Forklift

[Stephen Benjamin]

- Original Message -
> From: "Dominic Cleal" <domi...@cleal.org>
> To: foreman-dev@googlegroups.com
> Sent: Thursday, May 26, 2016 5:42:33 AM
> Subject: Re: [foreman-dev] Merge foreman-bats into Forklift
> 
> On 25/05/16 17:25, Ewoud Kohl van Wijngaarden wrote:
> > On Wed, May 25, 2016 at 10:38:04AM -0400, Stephen Benjamin wrote:
> >> I can understand separating it from development tools, so what about
> >> moving
> >> Katello's bats to foreman-bats?
> > 
> > What would then be the primary way of getting the latest bats tests? A
> > script to clone the foreman-bats repository?
> 
> Assuming you just want to get foreman-bats to use its helpers then yes,
> just clone the repo and they should be usable. Freight does something
> similar to use another library of BATS helpers
> (https://github.com/freight-team/freight/blob/master/Makefile#L88).
> 
> Else you could use a submodule/tree to stay with a particular version.
> The helpers could always be moved into their own repo if necessary.

I don't "just" want foreman-bats helpers, that's just one reason to merge
the projects. I think they should be in the same repo together, wherever
that is, and work with Forklift's Vagrant setup.

One of the benefits of how Forklift does things is that you can easily
`vagrant up centos7-bats` and run katello bats locally. Why should
foreman-bats stay in its own repo and maintain an entirely separate
and different vagrant configuration?


- Stephen


> --
> Dominic Cleal
> domi...@cleal.org
> 
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
> 

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Merge foreman-bats into Forklift

[Dominic Cleal]

On 25/05/16 17:25, Ewoud Kohl van Wijngaarden wrote:
> On Wed, May 25, 2016 at 10:38:04AM -0400, Stephen Benjamin wrote:
>> I can understand separating it from development tools, so what about moving
>> Katello's bats to foreman-bats?
> 
> What would then be the primary way of getting the latest bats tests? A
> script to clone the foreman-bats repository?

Assuming you just want to get foreman-bats to use its helpers then yes,
just clone the repo and they should be usable. Freight does something
similar to use another library of BATS helpers
(https://github.com/freight-team/freight/blob/master/Makefile#L88).

Else you could use a submodule/tree to stay with a particular version.
The helpers could always be moved into their own repo if necessary.

-- 
Dominic Cleal
domi...@cleal.org

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Merge foreman-bats into Forklift

[Ewoud Kohl van Wijngaarden]

On Wed, May 25, 2016 at 10:38:04AM -0400, Stephen Benjamin wrote:
> 
> 
> - Original Message -
> > From: "Dominic Cleal" <domi...@cleal.org>
> > To: foreman-dev@googlegroups.com
> > Sent: Wednesday, May 25, 2016 10:29:41 AM
> > Subject: Re: [foreman-dev] Merge foreman-bats into Forklift
> > 
> > On 23/05/16 21:48, Ewoud Kohl van Wijngaarden wrote:
> > > Hello all,
> > > 
> > > With katello-deploy being renamed to Forklift[1], I was wondering if we
> > > should merge foreman-bats into it. The benefit would be that it already
> > > contains some bats tests for Katello and if it's going to be the tool to
> > > deploy a development env or test env, it's a logical fit for all our
> > > system tests.
> > > 
> > > Thoughts?
> > 
> > I'd prefer to keep foreman-bats where it is, I don't want to mix
> > it with development tools or plugins. foreman-bats serves a limited
> > purpose well right now.
> 
> Well, Katello hosts its bats tests in Forklift, and we share a lot of common
> code.  Katello misses out on new features and changes to bats helpers.

This was my primary motivation for the proposal.

> I can understand separating it from development tools, so what about moving
> Katello's bats to foreman-bats?

What would then be the primary way of getting the latest bats tests? A
script to clone the foreman-bats repository?

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Merge foreman-bats into Forklift

[Stephen Benjamin]

- Original Message -
> From: "Dominic Cleal" <domi...@cleal.org>
> To: foreman-dev@googlegroups.com
> Sent: Wednesday, May 25, 2016 10:29:41 AM
> Subject: Re: [foreman-dev] Merge foreman-bats into Forklift
> 
> On 23/05/16 21:48, Ewoud Kohl van Wijngaarden wrote:
> > Hello all,
> > 
> > With katello-deploy being renamed to Forklift[1], I was wondering if we
> > should merge foreman-bats into it. The benefit would be that it already
> > contains some bats tests for Katello and if it's going to be the tool to
> > deploy a development env or test env, it's a logical fit for all our
> > system tests.
> > 
> > Thoughts?
> 
> I'd prefer to keep foreman-bats where it is, I don't want to mix
> it with development tools or plugins. foreman-bats serves a limited
> purpose well right now.

Well, Katello hosts its bats tests in Forklift, and we share a lot of common
code.  Katello misses out on new features and changes to bats helpers.

I can understand separating it from development tools, so what about moving
Katello's bats to foreman-bats?


> --
> Dominic Cleal
> domi...@cleal.org
> 
> 
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
> 

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Merge foreman-bats into Forklift

[Dominic Cleal]

On 23/05/16 21:48, Ewoud Kohl van Wijngaarden wrote:
> Hello all,
> 
> With katello-deploy being renamed to Forklift[1], I was wondering if we
> should merge foreman-bats into it. The benefit would be that it already
> contains some bats tests for Katello and if it's going to be the tool to
> deploy a development env or test env, it's a logical fit for all our
> system tests.
> 
> Thoughts?

I'd prefer to keep foreman-bats where it is, I don't want to mix
it with development tools or plugins. foreman-bats serves a limited
purpose well right now.

-- 
Dominic Cleal
domi...@cleal.org


-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Merge foreman-bats into Forklift

[David Davis]

Yes, Forklift can deploy just foreman: https://git.io/vroKn


David

On Tue, May 24, 2016 at 9:51 AM, Lukas Zapletal  wrote:

> > Thoughts?
>
> Is it possible to use katello-deploy for deployment of plain Foreman? If
> not, are there plans to do so? If not, it does not make much sense to me
> other than having the tests under one roof.
>
> Personally, I am not against the change, I can change my daily beaker
> test URL easily.
>
> --
> Later,
>  Lukas #lzap Zapletal
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.