Re: [fossil-users] Directory symlinks...

2017-02-14 Thread Martin Gagnon
On Tue, Feb 14, 2017 at 10:06:34AM -0800, Joe Mistachkin wrote: > > Martin Gagnon wrote: > > > > I'm not sure if this protection is necessary, but if it is, it doesn't > > get triggered if the symlink point directly to "../../dir3/other_ckout" > > since the "top of a checkout" check only happens

Re: [fossil-users] Directory symlinks...

2017-02-14 Thread Joe Mistachkin
Martin Gagnon wrote: > > I'm not sure if this protection is necessary, but if it is, it doesn't > get triggered if the symlink point directly to "../../dir3/other_ckout" > since the "top of a checkout" check only happens for the recursive call. > I believe this may be to protect against file

Re: [fossil-users] Directory symlinks...

2017-02-14 Thread Martin Gagnon
On Mon, Feb 13, 2017 at 07:10:52PM -0800, Joe Mistachkin wrote: > > Martin Gagnon wrote: > > > > Strange, "fossil add a_dir_symlink" doesn't works for the case #2 on my > > actual repository, but if I try to reproduce the problem on a brand new > > repo, everything works.. Probably I hit a

Re: [fossil-users] Directory symlinks...

2017-02-13 Thread Joe Mistachkin
Martin Gagnon wrote: > > Strange, "fossil add a_dir_symlink" doesn't works for the case #2 on my > actual repository, but if I try to reproduce the problem on a brand new > repo, everything works.. Probably I hit a strange corner case. I will > try to investigate a bit more.. > I've added the

Re: [fossil-users] Directory symlinks...

2017-02-13 Thread Martin Gagnon
On Mon, Feb 13, 2017 at 02:29:58PM -0800, Joe Mistachkin wrote: > > Martin Gagnon wrote: > > > > But if I do: > > $ fossil add a_dir_symlink/* > > > > It add the content. > > > > Actually, may be it was intended ? > > > > The way it should work (on the branch) is: > > 1. With

Re: [fossil-users] Directory symlinks...

2017-02-13 Thread Joe Mistachkin
Martin Gagnon wrote: > > But if I do: > $ fossil add a_dir_symlink/* > > It add the content. > > Actually, may be it was intended ? > The way it should work (on the branch) is: 1. With allowSymlinks ON, symlinks to both files and directories are always treated as "normal"

Re: [fossil-users] Directory symlinks...

2017-02-13 Thread Martin Gagnon
On Mon, Feb 13, 2017 at 01:11:39PM -0800, Joe Mistachkin wrote: > > Martin Gagnon wrote: > > > > $ fossil add a_dir_symlink > > > > Nothing happens... > > > > It was a bit more complex than I thought, made a couple more changes. > > Hopefully, it will work better now. Same result with

Re: [fossil-users] Directory symlinks...

2017-02-13 Thread Joe Mistachkin
Martin Gagnon wrote: > > $ fossil add a_dir_symlink > > Nothing happens... > It was a bit more complex than I thought, made a couple more changes. Hopefully, it will work better now. -- Joe Mistachkin @ https://urn.to/r/mistachkin ___

Re: [fossil-users] Directory symlinks...

2017-02-13 Thread Martin Gagnon
On Mon, Feb 13, 2017 at 12:37:10PM -0800, Joe Mistachkin wrote: > > Changes on the "symlinks" branch prevent directory symlinks > from being traversed into if the "allow-symlinks" setting is > enabled or the "--no-dir-symlinks" flag is specified. > > Making this change work correctly also

Re: [fossil-users] Directory symlinks...

2017-02-13 Thread Joe Mistachkin
Changes on the "symlinks" branch prevent directory symlinks from being traversed into if the "allow-symlinks" setting is enabled or the "--no-dir-symlinks" flag is specified. Making this change work correctly also required removing the forced override of the cached "allow-symlinks" setting from

Re: [fossil-users] Directory symlinks...

2017-02-13 Thread Martin Gagnon
On Fri, Sep 30, 2016 at 09:25:01PM -0700, Joe Mistachkin wrote: > > Warren Young wrote: > > > > Well, that's a tricky one, innit? Fossil manages files, not directories, > > but Fossil's view of symlinks is file-like. So is it an apple or an > > orange? > > > > I've checked in a fix on the

Re: [fossil-users] Directory symlinks...

2016-10-28 Thread Warren Young
On Oct 28, 2016, at 3:29 PM, Steven Gawroriski wrote: > > On Fri, 30 Sep 2016 21:25:01 -0700 > "Joe Mistachkin" wrote: > >> I've checked in a fix on the dirSymlinks branch that appears to >> completely fix the issue I personally encountered.

Re: [fossil-users] Directory symlinks...

2016-10-28 Thread Steven Gawroriski
On Fri, 30 Sep 2016 21:25:01 -0700 "Joe Mistachkin" wrote: > > Warren Young wrote: > > > > Well, that's a tricky one, innit? Fossil manages files, not > > directories, but Fossil's view of symlinks is file-like. So is it > > an apple or an orange? > > > > I've checked

Re: [fossil-users] Directory symlinks...

2016-09-30 Thread Joe Mistachkin
Warren Young wrote: > > Well, that's a tricky one, innit? Fossil manages files, not directories, > but Fossil's view of symlinks is file-like. So is it an apple or an > orange? > I've checked in a fix on the dirSymlinks branch that appears to completely fix the issue I personally encountered.

Re: [fossil-users] Directory symlinks...

2016-09-30 Thread Steven Gawroriski
On Fri, 30 Sep 2016 16:41:11 -0600 Warren Young wrote: > On Sep 30, 2016, at 4:37 PM, Joe Mistachkin > wrote: > > > > Are having directory symlinks (on Unix) supposed to be supported? > > If not, is anybody willing to help me add support for them? > >

Re: [fossil-users] Directory symlinks...

2016-09-30 Thread Warren Young
On Sep 30, 2016, at 4:37 PM, Joe Mistachkin wrote: > > Are having directory symlinks (on Unix) supposed to be supported? > If not, is anybody willing to help me add support for them? Well, that’s a tricky one, innit? Fossil manages files, not directories, but Fossil’s

[fossil-users] Directory symlinks...

2016-09-30 Thread Joe Mistachkin
Are having directory symlinks (on Unix) supposed to be supported? If not, is anybody willing to help me add support for them? -- Joe Mistachkin @ https://urn.to/r/mistachkin ___ fossil-users mailing list fossil-users@lists.fossil-scm.org