[fossil-users] memory leak using fossil_getenv and fossil_mbcs_to_utf8

2012-02-16 Thread Leo Razoumov
Very recently fossil_getenv function was introduced as a wrapper
around standard getenv to get Unicode right.
In file.c:

/*
** Return the value of an environment variable as UTF8.
*/
char *fossil_getenv(const char *zName){
  char *zValue = getenv(zName);
#ifdef _WIN32
  if( zValue ) zValue = fossil_mbcs_to_utf8(zValue);
#endif
  return zValue;
}

In Unix it returns pointer pointing into actual environment (should
not be modified or deallocated). In Windows, on the other hand,
fossil_mbcs_to_utf8 allocates memory via sqlite3_malloc. This memory
is not and cannot not be freed because of UNIX behavior.
It results in memory leak on Windows. Should one care?

--Leo--
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] memory leak using fossil_getenv and fossil_mbcs_to_utf8

2012-02-16 Thread Lluís Batlle i Rossell
On Thu, Feb 16, 2012 at 06:37:49AM -0500, Leo Razoumov wrote:
 In Unix it returns pointer pointing into actual environment (should
 not be modified or deallocated). In Windows, on the other hand,
 fossil_mbcs_to_utf8 allocates memory via sqlite3_malloc. This memory
 is not and cannot not be freed because of UNIX behavior.
 It results in memory leak on Windows. Should one care?

I think the general approach in fossil is to have short-lived processes, where
those kind of leaks that don't represent relevant memory usage be freed together
with the process end.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] memory leak using fossil_getenv and fossil_mbcs_to_utf8

2012-02-16 Thread Leo Razoumov
2012/2/16 Lluís Batlle i Rossell vi...@viric.name:
 On Thu, Feb 16, 2012 at 06:37:49AM -0500, Leo Razoumov wrote:
 In Unix it returns pointer pointing into actual environment (should
 not be modified or deallocated). In Windows, on the other hand,
 fossil_mbcs_to_utf8 allocates memory via sqlite3_malloc. This memory
 is not and cannot not be freed because of UNIX behavior.
 It results in memory leak on Windows. Should one care?

 I think the general approach in fossil is to have short-lived processes, where
 those kind of leaks that don't represent relevant memory usage be freed 
 together
 with the process end.

Not really. Fossil is often run as a web-server fossil ui or fossil
server and can live for months at a time. And preventing memory leaks
is a good software practice regardless.

--Leo--
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] memory leak using fossil_getenv and fossil_mbcs_to_utf8

2012-02-16 Thread Lluís Batlle i Rossell
On Thu, Feb 16, 2012 at 07:09:22AM -0500, Leo Razoumov wrote:
 2012/2/16 Lluís Batlle i Rossell vi...@viric.name:
  On Thu, Feb 16, 2012 at 06:37:49AM -0500, Leo Razoumov wrote:
  In Unix it returns pointer pointing into actual environment (should
  not be modified or deallocated). In Windows, on the other hand,
  fossil_mbcs_to_utf8 allocates memory via sqlite3_malloc. This memory
  is not and cannot not be freed because of UNIX behavior.
  It results in memory leak on Windows. Should one care?
 
  I think the general approach in fossil is to have short-lived processes, 
  where
  those kind of leaks that don't represent relevant memory usage be freed 
  together
  with the process end.
 
 Not really. Fossil is often run as a web-server fossil ui or fossil
 server and can live for months at a time. And preventing memory leaks
 is a good software practice regardless.

It forks for every request.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] memory leak using fossil_getenv and fossil_mbcs_to_utf8

2012-02-16 Thread Leo Razoumov
2012/2/16 Lluís Batlle i Rossell vi...@viric.name:
 On Thu, Feb 16, 2012 at 07:09:22AM -0500, Leo Razoumov wrote:
 2012/2/16 Lluís Batlle i Rossell vi...@viric.name:
  On Thu, Feb 16, 2012 at 06:37:49AM -0500, Leo Razoumov wrote:
  In Unix it returns pointer pointing into actual environment (should
  not be modified or deallocated). In Windows, on the other hand,
  fossil_mbcs_to_utf8 allocates memory via sqlite3_malloc. This memory
  is not and cannot not be freed because of UNIX behavior.
  It results in memory leak on Windows. Should one care?
 
  I think the general approach in fossil is to have short-lived processes, 
  where
  those kind of leaks that don't represent relevant memory usage be freed 
  together
  with the process end.

 Not really. Fossil is often run as a web-server fossil ui or fossil
 server and can live for months at a time. And preventing memory leaks
 is a good software practice regardless.

 It forks for every request.

True. In any case, in the end of the day it is Richard's call.

--Leo--
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] memory leak using fossil_getenv and fossil_mbcs_to_utf8

2012-02-16 Thread Richard Hipp
On Thu, Feb 16, 2012 at 6:37 AM, Leo Razoumov slonik...@gmail.com wrote:

 Very recently fossil_getenv function was introduced as a wrapper
 around standard getenv to get Unicode right.
 In file.c:

 /*
 ** Return the value of an environment variable as UTF8.
 */
 char *fossil_getenv(const char *zName){
  char *zValue = getenv(zName);
 #ifdef _WIN32
  if( zValue ) zValue = fossil_mbcs_to_utf8(zValue);
 #endif
  return zValue;
 }

 In Unix it returns pointer pointing into actual environment (should
 not be modified or deallocated). In Windows, on the other hand,
 fossil_mbcs_to_utf8 allocates memory via sqlite3_malloc. This memory
 is not and cannot not be freed because of UNIX behavior.
 It results in memory leak on Windows. Should one care?


No, one should not care.

Recall that the processing model for Fossil is that each invocation does
one operation then quits, allowing the operating system to clean up
afterwards.  (The OS is your garbage collector.)  It is important to free
memory that is allocated in a loop or that might be allocated multiple
times based on the size of your repository or the nature of your request.
However, for things like getenv() which are only called a small number of
times, a finite number of times, and which don't use much memory to begin
with, trying to keep track of when to free things merely increases the code
complexity and risks introducing new bugs.




 --Leo--
 ___
 fossil-users mailing list
 fossil-users@lists.fossil-scm.org
 http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users




-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] With jimtcl available can we have hooks that trigger tcl scripts stored in the db?

2012-02-16 Thread Richard Hipp
On Wed, Feb 15, 2012 at 11:15 PM, Nolan Darilek no...@thewordnerd.infowrote:

  So is it currently possible to use TH1 to generate dynamic webpages?
 Could I use it to, say, select the last 5 events and display them on the
 main page? Or is that still out of reach?

 Just curious, since it seems like there are lots of scripting
 possibilities coming down the pipeline.
 Thanks!


I was once open to this kind of thing.  But since the security risks have
been pointed out to me, I'm now very reluctant to do anything like this.





 On 02/14/2012 06:58 AM, Richard Hipp wrote:

 On Tue, Feb 14, 2012 at 7:53 AM, Richard Hipp d...@sqlite.org wrote:


  On Mon, Feb 13, 2012 at 9:26 PM, Leo Razoumov slonik...@gmail.comwrote:


  Are TH1 and Tcl interpreters properly sand-boxed? Otherwise,
 downloading and running random scripts found in some random repos does
 not strike me as a sound security.


 The only actions TH1 can take are to output text or HTML into designated
 areas of a webpage.  TH1 cannot change the repository, cannot write to the
 disk, cannot open network connections, cannot read content from external
 sources, cannot consume large amounts of memory, cannot loop, and cannot
 call external programs or software.  TH1 is not a serious threat for
 malware.

 TCL can do more mischief, but it is only enabled if you compile with
 FOSSIL_ENABLE_TCL, which is off by default, and if you either set the tcl
 property on your repository or have the TH1_ENABLE_TCL environment variable
 set.

 Moving forward, I think I'll make further security enhancements along the
 following lines:

 (1) Disable the TH1_ENABLE_TCL environment variable.  TCL script
 capability is only available if you enable it using the tcl property of
 the repository.

 (2) Default the tcl property to off on a clone, even if it is on in the
 parent repo.

 (3) Provide extra setup screens that make it easier to audit scripts for
 malware prior to enabling the tcl property.  At the place where the tcl
 property is enabled, include text warning users of the potential dangers
 and provide buttons or links to places where the TCL script can be audited
 for security.

 (4) Scripts are only exchanged between repositories on a fossil clone
 or fossil configuration pull/sync.  For the latter, detailed warnings
 about changes to scripts and recommendations to redo audits might be in
 order.


 (5) If any script changes as a result of fossil config pull then the
 tcl property is automatically moved to off and the operator is
 notified.  The tcl property must be turned back on by a separate manual
 step, that includes a warning to make sure the modified scripts are secure.




 --
 D. Richard Hipp
 d...@sqlite.org




 --
 D. Richard Hipp
 d...@sqlite.org


 ___
 fossil-users mailing 
 listfossil-users@lists.fossil-scm.orghttp://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users




 ___
 fossil-users mailing list
 fossil-users@lists.fossil-scm.org
 http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users




-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] With jimtcl available can we have hooks that trigger tcl scripts stored in the db?

2012-02-16 Thread Nolan Darilek

On 02/16/2012 06:55 AM, Richard Hipp wrote:



On Wed, Feb 15, 2012 at 11:15 PM, Nolan Darilek 
no...@thewordnerd.info mailto:no...@thewordnerd.info wrote:


So is it currently possible to use TH1 to generate dynamic
webpages? Could I use it to, say, select the last 5 events and
display them on the main page? Or is that still out of reach?

Just curious, since it seems like there are lots of scripting
possibilities coming down the pipeline.
Thanks!


I was once open to this kind of thing.  But since the security risks 
have been pointed out to me, I'm now very reluctant to do anything 
like this.




I thought the point of TH1 was that it prevented this type of thing, 
that's why it's used in reporting. If TH1 isn't a secure, minimal TCL 
that can generate reports and, presumably, might be expanded a bit to 
pull and display information on artifacts, then what is it?
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] memory leak using fossil_getenv and fossil_mbcs_to_utf8

2012-02-16 Thread altufaltu
In ui or server commands, I guess atleast 1 instance of fossil keeps running, 
listening to the port. If that functionality has memory leak, it needs a fix.


 - Original Message -
 From: Richard Hipp
 Sent: 02/16/12 06:04 PM
 To: slonik...@gmail.com, Fossil SCM user's discussion
 Subject: Re: [fossil-users] memory leak using fossil_getenv and   
 fossil_mbcs_to_utf8
 
 On Thu, Feb 16, 2012 at 6:37 AM, Leo Razoumov slonik...@gmail.com wrote:
 
  Very recently fossil_getenv function was introduced as a wrapper
  around standard getenv to get Unicode right.
  In file.c:
 
  /*
  ** Return the value of an environment variable as UTF8.
  */
  char *fossil_getenv(const char *zName){
   char *zValue = getenv(zName);
  #ifdef _WIN32
   if( zValue ) zValue = fossil_mbcs_to_utf8(zValue);
  #endif
   return zValue;
  }
 
  In Unix it returns pointer pointing into actual environment (should
  not be modified or deallocated). In Windows, on the other hand,
  fossil_mbcs_to_utf8 allocates memory via sqlite3_malloc. This memory
  is not and cannot not be freed because of UNIX behavior.
  It results in memory leak on Windows. Should one care?
 
 
 No, one should not care.
 
 Recall that the processing model for Fossil is that each invocation does
 one operation then quits, allowing the operating system to clean up
 afterwards.  (The OS is your garbage collector.)  It is important to free
 memory that is allocated in a loop or that might be allocated multiple
 times based on the size of your repository or the nature of your request.
 However, for things like getenv() which are only called a small number of
 times, a finite number of times, and which don't use much memory to begin
 with, trying to keep track of when to free things merely increases the code
 complexity and risks introducing new bugs.
 
 
 
 
  --Leo--
  ___
  fossil-users mailing list
  fossil-users@lists.fossil-scm.org
  http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
 
 
 
 
 -- 
 D. Richard Hipp
 d...@sqlite.org
 

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] memory leak using fossil_getenv and fossil_mbcs_to_utf8

2012-02-16 Thread Richard Hipp
On Thu, Feb 16, 2012 at 9:33 AM, altufa...@mail.com wrote:

 In ui or server commands, I guess atleast 1 instance of fossil keeps
 running, listening to the port. If that functionality has memory leak, it
 needs a fix.


Fossil launches a separate process to handle each HTTP request.  Always.
Even using the ui and server commands.




  - Original Message -
  From: Richard Hipp
  Sent: 02/16/12 06:04 PM
  To: slonik...@gmail.com, Fossil SCM user's discussion
  Subject: Re: [fossil-users] memory leak using fossil_getenv and
 fossil_mbcs_to_utf8
 
  On Thu, Feb 16, 2012 at 6:37 AM, Leo Razoumov slonik...@gmail.com
 wrote:
 
   Very recently fossil_getenv function was introduced as a wrapper
   around standard getenv to get Unicode right.
   In file.c:
  
   /*
   ** Return the value of an environment variable as UTF8.
   */
   char *fossil_getenv(const char *zName){
char *zValue = getenv(zName);
   #ifdef _WIN32
if( zValue ) zValue = fossil_mbcs_to_utf8(zValue);
   #endif
return zValue;
   }
  
   In Unix it returns pointer pointing into actual environment (should
   not be modified or deallocated). In Windows, on the other hand,
   fossil_mbcs_to_utf8 allocates memory via sqlite3_malloc. This memory
   is not and cannot not be freed because of UNIX behavior.
   It results in memory leak on Windows. Should one care?
  
 
  No, one should not care.
 
  Recall that the processing model for Fossil is that each invocation does
  one operation then quits, allowing the operating system to clean up
  afterwards.  (The OS is your garbage collector.)  It is important to free
  memory that is allocated in a loop or that might be allocated multiple
  times based on the size of your repository or the nature of your request.
  However, for things like getenv() which are only called a small number of
  times, a finite number of times, and which don't use much memory to begin
  with, trying to keep track of when to free things merely increases the
 code
  complexity and risks introducing new bugs.
 
 
 
  
   --Leo--
   ___
   fossil-users mailing list
   fossil-users@lists.fossil-scm.org
   http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
  
 
 
 
  --
  D. Richard Hipp
  d...@sqlite.org
 

 ___
 fossil-users mailing list
 fossil-users@lists.fossil-scm.org
 http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users




-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


[fossil-users] Last changed date on wiki pages

2012-02-16 Thread Thomas Stover
Anyway to make a place on a wiki page say something like this was last
updated on x/x/x?
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Last changed date on wiki pages

2012-02-16 Thread Stephan Beal
Hi!

The adventurous can get that via the json api:

fossil json wiki get PageName
Or:
http://... /json/wiki/get/PageName

Should do the trick.

- stephan beal
http://wanderinghorse.net/home/stephan/
http://gplus.to/sgbeal
On Feb 16, 2012 4:24 PM, Thomas Stover c...@thomasstover.com wrote:

 Anyway to make a place on a wiki page say something like this was last
 updated on x/x/x?
 ___
 fossil-users mailing list
 fossil-users@lists.fossil-scm.org
 http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] With jimtcl available can we have hooks that trigger tcl scripts stored in the db?

2012-02-16 Thread Nolan Darilek

Cool, I'd like to at least have the discussion about that, though.

What I'd like to see, if possible, is read-only access to the 
repository--access to the SELECT statement, for instance, and a way to 
iterate over the results and output them into the pages.


To anyone afraid that I'll be calling for full-blown CMS features next, 
I'll note that hooks and the ability to display arbitrary repository 
content are the only features I've missed after nearly two years of 
Fossil use. I'm using it quite happily for the http://spielproject.info 
pages, but I'd love to display the last 5-10 events on the front page to 
liven it up a bit. Events are how I announce releases. I could also see 
displaying timeline entries and such to show the X most recent commits 
on certain pages, etc.


Yeah, I know I can do this with Javascript, but that doesn't make the 
content searchable.


Thanks.


On 02/16/2012 08:00 AM, Richard Hipp wrote:



On Thu, Feb 16, 2012 at 8:49 AM, Nolan Darilek no...@thewordnerd.info 
mailto:no...@thewordnerd.info wrote:


On 02/16/2012 06:55 AM, Richard Hipp wrote:



On Wed, Feb 15, 2012 at 11:15 PM, Nolan Darilek
no...@thewordnerd.info mailto:no...@thewordnerd.info wrote:

So is it currently possible to use TH1 to generate dynamic
webpages? Could I use it to, say, select the last 5 events
and display them on the main page? Or is that still out of reach?

Just curious, since it seems like there are lots of scripting
possibilities coming down the pipeline.
Thanks!


I was once open to this kind of thing.  But since the security
risks have been pointed out to me, I'm now very reluctant to do
anything like this.




I thought the point of TH1 was that it prevented this type of
thing, that's why it's used in reporting. If TH1 isn't a secure,
minimal TCL that can generate reports and, presumably, might be
expanded a bit to pull and display information on artifacts, then
what is it?


TH1 is secure by virtual of being minimalist.  It really doesn't do 
much beyond simple variable substitution and if-then-else.  The point 
is, I want to keep it that way so that it does not evolve into a 
security threat.  We want to keep the attack surface as small as 
possible.



___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
mailto:fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users




--
D. Richard Hipp
d...@sqlite.org mailto:d...@sqlite.org


___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


[fossil-users] Seeing SBS between any checkins

2012-02-16 Thread Lluís Batlle i Rossell
Hello,

the /ci pages show a list of files changed between a checkin and its primary
parent. Including the possibility of SBS diffs, or unified diffs.

Can that be done between any checkins, following the kind of 'shortest path'
that a merge operation uses?

With SBS diffs, it would be great to see diffs between branches using the web 
UI.

Thank you,
Lluís.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Seeing SBS between any checkins

2012-02-16 Thread Richard Hipp
2012/2/16 Lluís Batlle i Rossell vi...@viric.name

 Hello,

 the /ci pages show a list of files changed between a checkin and its
 primary
 parent. Including the possibility of SBS diffs, or unified diffs.

 Can that be done between any checkins, following the kind of 'shortest
 path'
 that a merge operation uses?

 With SBS diffs, it would be great to see diffs between branches using the
 web UI.



http://yourdomain/fossil/vdiff?from=VERSION1to=VERSION2sbs=1

example:

http://www.fossil-scm.org/fossil/vdiff?from=releaseto=trunksbs=1



 Thank you,
 Lluís.
 ___
 fossil-users mailing list
 fossil-users@lists.fossil-scm.org
 http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users




-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] With jimtcl available can we have hooks that trigger tcl scripts stored in the db?

2012-02-16 Thread Leo Razoumov
On Thu, Feb 16, 2012 at 09:00, Richard Hipp d...@sqlite.org wrote:


 I was once open to this kind of thing.  But since the security risks have
 been pointed out to me, I'm now very reluctant to do anything like this.


 TH1 is secure by virtual of being minimalist.  It really doesn't do much
 beyond simple variable substitution and if-then-else.  The point is, I want
 to keep it that way so that it does not evolve into a security threat.  We
 want to keep the attack surface as small as possible.


I appreciate the security above all attitude. But if at some point in
the future scripting will be back on discussion table I would like to
introduce embedded language Lua  [1], [2]. It has some really unique
features that are greatly appreciated in embedded scripting world.
Here just few of them:

(1) Implemented in ANSI C-89 with no external dependencies, highly
portable. Small code base (15 KLOC)

(2) Designed as embedded language from get go. Great configurable  sand-boxing

(3) Very easy to interface to existing C-code. Lua can call
C-functions and can be called from C-functions.

(4) Very fast (faster than TCL, python, ruby, perl). For real CPU
addicts there is Just-In-Time compiler LuaJIT which delivers Java-6
like performance on average and sometimes comes close to C.

(5) Simple syntax, powerful semantics.


[1]  http://www.lua.org
[2]  http://en.wikipedia.org/wiki/Lua_%28programming_language%29

--Leo--
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Seeing SBS between any checkins

2012-02-16 Thread Lluís Batlle i Rossell
On Thu, Feb 16, 2012 at 11:25:32AM -0500, Richard Hipp wrote:
 2012/2/16 Lluís Batlle i Rossell vi...@viric.name
  With SBS diffs, it would be great to see diffs between branches using the
  web UI.
 http://yourdomain/fossil/vdiff?from=VERSION1to=VERSION2sbs=1
 
 example:
 
 http://www.fossil-scm.org/fossil/vdiff?from=releaseto=trunksbs=1

Ah great.

It does not work in our 1.21 though. It only shows the files modified, without
diff. I'll either wait the next release or try trunk.

Thank you!
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Seeing SBS between any checkins

2012-02-16 Thread Richard Hipp
2012/2/16 Lluís Batlle i Rossell vi...@viric.name

 On Thu, Feb 16, 2012 at 11:25:32AM -0500, Richard Hipp wrote:
  2012/2/16 Lluís Batlle i Rossell vi...@viric.name
   With SBS diffs, it would be great to see diffs between branches using
 the
   web UI.
  http://yourdomain/fossil/vdiff?from=VERSION1to=VERSION2sbs=1
 
  example:
 
  http://www.fossil-scm.org/fossil/vdiff?from=releaseto=trunksbs=1

 Ah great.

 It does not work in our 1.21 though. It only shows the files modified,
 without
 diff. I'll either wait the next release or try trunk.


I think on version 1.21 you can substitute detail=1 in place of sbs=1
and see in-line diffs.



 Thank you!
 ___
 fossil-users mailing list
 fossil-users@lists.fossil-scm.org
 http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users




-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Bug: non-ASCII user names are corrupted

2012-02-16 Thread Роман Донченко
Richard Hipp d...@sqlite.org писал в своём  
письме Thu, 16 Feb 2012 05:09:34 +0400:



2012/2/15 Richard Hipp d...@sqlite.org



2012/2/15 Роман Донченко  
dxdra...@yandex.ru



Hello,

I'm using (well, trying to) Fossil on Windows. My username is Роман.
This happens:

F:\Sourcefossil init test.sqlite
project-id: c162b4ff218ffca0d4f3fe26f20a34**fd5c7cf892
server-id:  01814b880714e63786ef5af7b403f5**bb4fbee016
admin-user: ? (initial password is 5c1309)

Note the five question marks.

I've examined the DB, and it seems that the actual value recorded is  
just

five of U+FFFD REPLACEMENT CHARACTER.



Are you able to compile Fossil from sources?  Can you try out the
following patch and let me know if it clears your problem?



I'm reasonably confident that the patch below will work, so I went ahead
and implemented it for every use of getenv() in Fossil.  The checkin is
here:  http://www.fossil-scm.org/fossil/ci/57152086b8?sbs=1

Users of Fossil with non-latin character sets on Windows:  Please check  
out

this change for me and let me know if it is working for you.  Thanks.


This does seem to fix it. Thanks for the prompt response.

Roman.

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


[fossil-users] web page icon propagation

2012-02-16 Thread Thomas Stover
At first it appeared that push/pull was propagating the project icon. Then it 
looked like it was not, so I started adding it manually. Then I realized that 
was just browser silliness. Now I'm back to not seeing it working. Would 
someone tell me if this is suppose to work, since I have confused my self 
senseless.



___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Derived code, not to be pushed public

2012-02-16 Thread Ron Wilson
On Mon, Feb 6, 2012 at 1:53 PM, Lluís Batlle i Rossell vi...@viric.name wrote:
 On Mon, Feb 06, 2012 at 01:07:30PM -0500, Ron Wilson wrote:

 Mark your branch private.

 Anything you want to push can then be merged into a non-private branch.

 Ah, well, that's fine for personal work. I meant a bit how to do private
 collaborative work over a public fossil base. Sorry that I did not state all I
 had in mind clear enough.

So you want to have a restricted branch that is shared between a
subset of the developers?

You could setup a second shared repository and only allow access to
the select group, Then have a script that sets your group branch
private, pushes to the public repository, then unsets the private
attribute on the group branch.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] web page icon propagation

2012-02-16 Thread Richard Hipp
The skin (including the project icon) is not versioned.  It is consider
server-specific metadata.  The skin is copied when you clone.  You can all
move move it using:

 fossil configure pull
 fossil configure push skin

It is often necessary to press Reload on your browser after changing the
icon, especially on Chrome, before you will see the change.

On Thu, Feb 16, 2012 at 12:14 PM, Thomas Stover c...@thomasstover.comwrote:

 At first it appeared that push/pull was propagating the project icon. Then
 it looked like it was not, so I started adding it manually. Then I realized
 that was just browser silliness. Now I'm back to not seeing it working.
 Would someone tell me if this is suppose to work, since I have confused my
 self senseless.



 ___
 fossil-users mailing list
 fossil-users@lists.fossil-scm.org
 http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users




-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


[fossil-users] On vdiff

2012-02-16 Thread Lluís Batlle i Rossell
On Thu, Feb 16, 2012 at 12:11:36PM -0500, Richard Hipp wrote:
 2012/2/16 Lluís Batlle i Rossell vi...@viric.name
 
  On Thu, Feb 16, 2012 at 11:25:32AM -0500, Richard Hipp wrote:
   2012/2/16 Lluís Batlle i Rossell vi...@viric.name
With SBS diffs, it would be great to see diffs between branches using
  the
web UI.
   http://yourdomain/fossil/vdiff?from=VERSION1to=VERSION2sbs=1
  
   example:
  
   http://www.fossil-scm.org/fossil/vdiff?from=releaseto=trunksbs=1
 
  Ah great.
 
  It does not work in our 1.21 though. It only shows the files modified,
  without
  diff. I'll either wait the next release or try trunk.
 
 
 I think on version 1.21 you can substitute detail=1 in place of sbs=1
 and see in-line diffs.


Ah ok - nevertheless I updated to the trunk tip already!

So some comments (or requests) on vdiff at trunk:
Now there is no detail=0, right? Seeing only the list of files is also
interesting.

I tried to=tai (a branch we have, not closed), and it says Artifact tai is
not a checkin.. Other branches we tried work fine.

Could it be made so vdiff understood 'to=ckout'? :)

And... what do you suggest to see the amount of changes done in a branch since
the last merge? I'm still always using fossil test-find-pivot trunk branch,
and then displaying the diff between the pivot and the branch. I'd welcome some
easy interface for these kind of diffs I'm doing often.

For example, I'd appreciate something similar to from=trunkto=annotate_links,
but showing what does annotate_links have related to trunk.
But as annotate_links is not up to date with trunk, I have to run:
$ fossil test-find-pivot trunk annotate_links
pivot=c80ee413ab77fb46b01c68ea82e2ad9a9446cc76
http://www.fossil-scm.org/fossil/vdiff?from=c80ee413ab77fb46b01c68ea82e2ad9a9446cc76to=annotate_links

(I've been very surprised on the horizontal diff, btw! Very nice)

Thank you,
Lluís.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] web page icon propagation

2012-02-16 Thread Thomas Stover
On Thursday, February 16, 2012 11:23am, Richard Hipp d...@sqlite.org said:
 
  fossil configure pull
  fossil configure push skin

ok. I think one time I did do a configure pull, and another time just pull. 
The user accounts are not by chance part of this configuration?


___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Last changed date on wiki pages

2012-02-16 Thread Thomas Stover


On Thursday, February 16, 2012 9:33am, Stephan Beal sgb...@googlemail.com 
said:
 
 The adventurous can get that via the json api:
 
 fossil json wiki get PageName
 Or:
 http://... /json/wiki/get/PageName
 
 Should do the trick.
 

Interesting. Once I figured out I needed to rebuild with --enable-json it 
worked. I wonder if it could be crafted to just return the the timestamp. Or is 
the idea to render then wiki page in-browser with java script once pulled over 
from that call?

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] web page icon propagation

2012-02-16 Thread Thomas Stover
I spoke too soon. I get fossil: unknown command: configure on all my 
installations. Do I need another build flag?

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] web page icon propagation

2012-02-16 Thread Lluís Batlle i Rossell
On Thu, Feb 16, 2012 at 11:41:53AM -0600, Thomas Stover wrote:
 I spoke too soon. I get fossil: unknown command: configure on all my 
 installations. Do I need another build flag?

No json. 'fossil configuration'

:)

Regards,
Lluís
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] web page icon propagation

2012-02-16 Thread Thomas Stover


On Thursday, February 16, 2012 11:47am, Lluís Batlle i Rossell 
vi...@viric.name said:

 On Thu, Feb 16, 2012 at 11:41:53AM -0600, Thomas Stover wrote:
 I spoke too soon. I get fossil: unknown command: configure on all my
 installations. Do I need another build flag?
 
 No json. 'fossil configuration'

I don't follow you. I rebuilt without the --enable-json, which didn't change 
anything. Maybe you meant something else?



___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] web page icon propagation

2012-02-16 Thread Richard Hipp
On Thu, Feb 16, 2012 at 12:28 PM, Thomas Stover c...@thomasstover.comwrote:

 On Thursday, February 16, 2012 11:23am, Richard Hipp d...@sqlite.org
 said:
 
   fossil configure pull
   fossil configure push skin

 ok. I think one time I did do a configure pull, and another time just
 pull. The user accounts are not by chance part of this configuration?


User accounts are part of metadata.  If you edit user accounts locally and
then do a config pull it keeps the most recent change.

Other metadata that config pull might sync (assuming you have appropriate
permissions) include:

*  The ticket configuration (what fields are on tickets, and the ticket
entry and editing screens)
*  The list of shunned artifacts
*  Ticket report formats
*  Concealed user names.

Concealed usernames are typically email addresses that you do not want to
be available for harvesting by spammers, and so are stored in the tickets
themselves as a SHA1 hash.  The Concealed table maps those hashes back to
the original names, so that authorized users can see the original email
address.  Anonymous can only access the SHA1 hash.





 ___
 fossil-users mailing list
 fossil-users@lists.fossil-scm.org
 http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users




-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Last changed date on wiki pages

2012-02-16 Thread Stephan Beal
On Thu, Feb 16, 2012 at 6:39 PM, Thomas Stover c...@thomasstover.com wrote:

 Interesting. Once I figured out I needed to rebuild with --enable-json it
 worked.


i would have mentioned that if i hadn't been typing on my phone at the time
;).



 I wonder if it could be crafted to just return the the timestamp. Or is
 the idea to render then wiki page in-browser with java script once pulled
 over from that call?


It can't be told just to return the timestamp because the JSON API
inputs/outputs _only_ JSON (even in CLI mode). However... with just a bit
of jquery (or similar) you could do something like add a script tag to your
page header with something along the lines of:

jQuery(function($){
$.ajax('/json/wiki', {
   data:{ name: 'PageName' },
   success: function(data){
   ...data might be a JSON string or a JSON object,
  depending on other ajax() options...
 });
});

(i'm going from memory there - those ajax() options might have different
names/signatures.)

In the success() callback, fish out data.payload.timestamp value and render
the information somewhere in your page. To make this work optimally you
might have to enable full HTML in your wiki so that you can easily place
HTML elements which can be used for output placement. e.g add span
id='wiki-page-timestamp'/ and fetch it with $('#wiki-page-timestamp') in
the AJAX callback.

The JSON API also supports JSONP responses. Just add the
jsonp=callback_name parameter to your request, e.g.:

stephan@tiny ~/cvs/fossil/whio $ f json wiki get whio_rc -jsonp MyCallback
| head -2
MyCallback({
fossil:4272d03e324ea05ea7dfad67e2d481e6db003864,

All that having been said, you've inadvertently pointed out the need for a
verbose wiki-list command which returns a list of all pages plus their
metadata details (e.g. size, uuid, timestamp), but without the content
(which can be arbitrarily large). i originally skimped on that feature
because the HTML interface doesn't show that info (and i was copy/pasting
most of the queries from the HTML code).

Doh, i almost forgot a recently-added feature... try:

http://.../json/wiki/get/PAGENAME?format=none
Or:
fossil wiki get PAGENAME -format none

that will return a given page's metadata without its content:

{
fossil:4272d03e324ea05ea7dfad67e2d481e6db003864,
timestamp:1329415928,
command:wiki/get,
procTimeMs:12,
payload:{
name:whio_vlbm,
uuid:4053d1e97499c9c9454f16d996b06ca88dca88e8,
lastSavedBy:stephan,
timestamp:1306176658,
contentLength:3991
}
}


-- 
- stephan beal
http://wanderinghorse.net/home/stephan/
http://gplus.to/sgbeal
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] web page icon propagation

2012-02-16 Thread Weber, Martin S
On 2012-02-16 12:41 , Thomas Stover c...@thomasstover.com wrote:

I spoke too soon. I get fossil: unknown command: configure on all my
installations. Do I need another build flag?

It's easy actually. The full command is configuration, to which all of
conf, config and even configur are valid prefixes/abbreviations. The
command is not called configure, instead that's either some over-eager
email software word completion while typing or simply a typo. Use fossil
configuration, fossil config, fossil conf, whatever rocks your cradle. No
special build flags necessary.

Regards,
-Martin

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Seeing SBS between any checkins

2012-02-16 Thread Ramon Ribó
   Hello,

   Have you tried to see the differences page on Google Chrome? I see
them ok on firefox but very bad on chrome.
It looks like it does not preserve indentation.

  RR


2012/2/16 Richard Hipp d...@sqlite.org:


 2012/2/16 Lluís Batlle i Rossell vi...@viric.name

 On Thu, Feb 16, 2012 at 11:25:32AM -0500, Richard Hipp wrote:
  2012/2/16 Lluís Batlle i Rossell vi...@viric.name
   With SBS diffs, it would be great to see diffs between branches using
   the
   web UI.
      http://yourdomain/fossil/vdiff?from=VERSION1to=VERSION2sbs=1
 
  example:
 
      http://www.fossil-scm.org/fossil/vdiff?from=releaseto=trunksbs=1

 Ah great.

 It does not work in our 1.21 though. It only shows the files modified,
 without
 diff. I'll either wait the next release or try trunk.


 I think on version 1.21 you can substitute detail=1 in place of sbs=1
 and see in-line diffs.



 Thank you!
 ___
 fossil-users mailing list
 fossil-users@lists.fossil-scm.org
 http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users




 --
 D. Richard Hipp
 d...@sqlite.org

 ___
 fossil-users mailing list
 fossil-users@lists.fossil-scm.org
 http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Seeing SBS between any checkins

2012-02-16 Thread Richard Hipp
On Thu, Feb 16, 2012 at 1:41 PM, Ramon Ribó ram...@compassis.com wrote:

   Hello,

   Have you tried to see the differences page on Google Chrome? I see
 them ok on firefox but very bad on chrome.
 It looks like it does not preserve indentation.


Try pressing Reload several times to convince Chrome to load the newest
CSS.



  RR


 2012/2/16 Richard Hipp d...@sqlite.org:
 
 
  2012/2/16 Lluís Batlle i Rossell vi...@viric.name
 
  On Thu, Feb 16, 2012 at 11:25:32AM -0500, Richard Hipp wrote:
   2012/2/16 Lluís Batlle i Rossell vi...@viric.name
With SBS diffs, it would be great to see diffs between branches
 using
the
web UI.
   http://yourdomain/fossil/vdiff?from=VERSION1to=VERSION2sbs=1
  
   example:
  
  
 http://www.fossil-scm.org/fossil/vdiff?from=releaseto=trunksbs=1
 
  Ah great.
 
  It does not work in our 1.21 though. It only shows the files modified,
  without
  diff. I'll either wait the next release or try trunk.
 
 
  I think on version 1.21 you can substitute detail=1 in place of sbs=1
  and see in-line diffs.
 
 
 
  Thank you!
  ___
  fossil-users mailing list
  fossil-users@lists.fossil-scm.org
  http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
 
 
 
 
  --
  D. Richard Hipp
  d...@sqlite.org
 
  ___
  fossil-users mailing list
  fossil-users@lists.fossil-scm.org
  http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
 
 ___
 fossil-users mailing list
 fossil-users@lists.fossil-scm.org
 http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users




-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Seeing SBS between any checkins

2012-02-16 Thread Leo Razoumov
On Thu, Feb 16, 2012 at 13:43, Richard Hipp d...@sqlite.org wrote:

 Try pressing Reload several times to convince Chrome to load the newest
 CSS.


In order to force CSS reload go to Admin-Skins, change to any skin
and then change back to the default skin.

--Leo--
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Derived code, not to be pushed public

2012-02-16 Thread Brian Smith
For what it's worth, I was working on limited branch syncing awhile back.

I never got around to merging it back into the master fossil repo, but, I think 
at least your use case is functional..

http://code.linuxfood.net/pub/repo/fossil-limsync

I really ought to finish that up and push it into the master fossil repo.

From memory, the push and pull commands now have a --branch flag (which may 
appear multiple times), so you can push/pull only individual branches. The sync 
command may also have it. Cloning a limited set of branches never got finished, 
unfortunately.
I could clean up the code and remove all of the work in progress for 
implementing it for clone, just to get at least push/pull out the door. I think 
that would probably cover quite a few use cases.

-B  


Sent with Sparrow (http://www.sparrowmailapp.com/?sig)


On Thursday, February 16, 2012 at 9:16 AM, Ron Wilson wrote:

 On Mon, Feb 6, 2012 at 1:53 PM, Lluís Batlle i Rossell vi...@viric.name 
 (mailto:vi...@viric.name) wrote:
  On Mon, Feb 06, 2012 at 01:07:30PM -0500, Ron Wilson wrote:

   Mark your branch private.

   Anything you want to push can then be merged into a non-private branch.
   
  Ah, well, that's fine for personal work. I meant a bit how to do private
  collaborative work over a public fossil base. Sorry that I did not state 
  all I
  had in mind clear enough.
   
  
  
 So you want to have a restricted branch that is shared between a
 subset of the developers?
  
 You could setup a second shared repository and only allow access to
 the select group, Then have a script that sets your group branch
 private, pushes to the public repository, then unsets the private
 attribute on the group branch.
 ___
 fossil-users mailing list
 fossil-users@lists.fossil-scm.org (mailto:fossil-users@lists.fossil-scm.org)
 http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
  
  


___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] web page icon propagation

2012-02-16 Thread Thomas Stover


On Thursday, February 16, 2012 12:18pm, Weber, Martin S 
martin.we...@nist.gov said:
 
 It's easy actually. The full command is configuration, to which all of

Awesome. fossil configuration pull skin did it. Looking at the bytes 
transferred, the icon itself must have already come over in another operation.

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Last changed date on wiki pages

2012-02-16 Thread Thomas Stover


On Thursday, February 16, 2012 12:13pm, Stephan Beal sgb...@googlemail.com 
said:

 Doh, i almost forgot a recently-added feature... try:
 
 http://.../json/wiki/get/PAGENAME?format=none
 Or:
 fossil wiki get PAGENAME -format none
 
 that will return a given page's metadata without its content:
 
 {
 fossil:4272d03e324ea05ea7dfad67e2d481e6db003864,
 timestamp:1329415928,
 command:wiki/get,
 procTimeMs:12,
 payload:{
 name:whio_vlbm,
 uuid:4053d1e97499c9c9454f16d996b06ca88dca88e8,
 lastSavedBy:stephan,
 timestamp:1306176658,
 contentLength:3991
 }
 }

That would be great. For me it worked with the command line, but not through 
the browser.

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Last changed date on wiki pages

2012-02-16 Thread Stephan Beal
On Thu, Feb 16, 2012 at 8:46 PM, Thomas Stover c...@thomasstover.com wrote:

 That would be great. For me it worked with the command line, but not
 through the browser.


Works for me?

http://fossil.wanderinghorse.net/repos/whio/index.cgi/json/wiki/get/whio_dev?format=none
Or, alternately:
http://fossil.wanderinghorse.net/repos/whio/index.cgi/json/wiki/get/?name=whio_devformat=none


The 'none' option was added a few days ago:

http://www.fossil-scm.org/index.html/info/913e0b6628

You'll need to be using a recent trunk.

The format option can be any of (none, html, raw), where 'raw' means not
wiki-parsed.

-- 
- stephan beal
http://wanderinghorse.net/home/stephan/
http://gplus.to/sgbeal
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Derived code, not to be pushed public

2012-02-16 Thread Leo Razoumov
On Thu, Feb 16, 2012 at 14:15, Brian Smith br...@linuxfood.net wrote:
 For what it's worth, I was working on limited branch syncing awhile back.

 I never got around to merging it back into the master fossil repo, but, I
 think at least your use case is functional..

 http://code.linuxfood.net/pub/repo/fossil-limsync

 I really ought to finish that up and push it into the master fossil repo.


Brian,
please, by all means, merge your changes upstream!! pull/push
individual branches opens a whole new universe of finely controlled
visibility.
Cloning individual branches would be nice to have but I can live without it.

--Leo--
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


[fossil-users] compile with --enable-json

2012-02-16 Thread Johan Samyn
Hi,
I just read a thread from this list where someone mentions compiling
with the --enable-json flag. I'm on Win7, and use 'make -f
win\Makefile.mingw' to compile fossil. I tried with adding that flag,
but the option is rejected. I did not find such flag in that
Makefile.mingw that I could uncomment neither. Could someone point me in
the right direction to solve this please?

-- 
Johan Samyn
___
Perfection is achieved, not when there is nothing more to add,
but when there is nothing left to take away. - A. de Saint-Exupery

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] compile with --enable-json

2012-02-16 Thread Stephan Beal
On Thu, Feb 16, 2012 at 9:37 PM, Johan Samyn johan.sa...@gmail.com wrote:

 Hi,
 I just read a thread from this list where someone mentions compiling
 with the --enable-json flag. I'm on Win7, and use 'make -f
 win\Makefile.mingw' to compile fossil. I tried with adding that flag,
 but the option is rejected. I did not find such flag in that
 Makefile.mingw that I could uncomment neither. Could someone point me in
 the right direction to solve this please?


As the Germans say: Good question! Next question?


As a workaround, please try:

# make -f ... CFLAGS=-DFOSSIL_ENABLE_JSON

:-?

-- 
- stephan beal
http://wanderinghorse.net/home/stephan/
http://gplus.to/sgbeal
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] compile with --enable-json

2012-02-16 Thread Johan Samyn
On 16-02-2012 21:53, Stephan Beal wrote:
 On Thu, Feb 16, 2012 at 9:37 PM, Johan Samyn johan.sa...@gmail.com
 mailto:johan.sa...@gmail.com wrote:

 Hi,
 I just read a thread from this list where someone mentions compiling
 with the --enable-json flag. I'm on Win7, and use 'make -f
 win\Makefile.mingw' to compile fossil. I tried with adding that flag,
 but the option is rejected. I did not find such flag in that
 Makefile.mingw that I could uncomment neither. Could someone point
 me in
 the right direction to solve this please?


 As the Germans say: Good question! Next question?


 As a workaround, please try:

 # make -f ... CFLAGS=-DFOSSIL_ENABLE_JSON

 :-?

Thanks Stephan. Should adding 'FOSSIL_ENABLE_JSON = 1' to my
Makefile.mingw work too (I'm a makefile noob ...) ?

No compilation rejection anymore, but 'fossil json ...' still does not
work. Need some external json lib to link with maybe ? I didn't find
anything about json in the Fossil compilation docs.

 -- 
 - stephan beal
 http://wanderinghorse.net/home/stephan/
 http://gplus.to/sgbeal



 ___
 fossil-users mailing list
 fossil-users@lists.fossil-scm.org
 http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


-- 
Johan Samyn
___
Perfection is achieved, not when there is nothing more to add,
but when there is nothing left to take away. - A. de Saint-Exupery

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] compile with --enable-json

2012-02-16 Thread Stephan Beal
On Thu, Feb 16, 2012 at 11:19 PM, Johan Samyn johan.sa...@gmail.com wrote:

 Thanks Stephan. Should adding 'FOSSIL_ENABLE_JSON = 1' to my
 Makefile.mingw work too (I'm a makefile noob ...) ?


It doesn't look like that's a known makefile option (it might be worth
adding, though):

stephan@tiny ~/cvs/fossil/fossil $ grep FOSSIL_ENABLE_JSON win/Makefile.*
stephan@tiny ~/cvs/fossil/fossil $


but what you can do is add this line to your makefile:

CPPFLAGS += -DFOSSIL_ENABLE_JSON

(instead of CFLAGS like i said earlier)

No compilation rejection anymore, but 'fossil json ...' still does not
 work.


What does it say? Are you sure you're running the newly-compiled binary and
not your old/installed one? Did you do a 'make clean' before trying it (if
you don't, it won't really rebuild anything).


 Need some external json lib to link with maybe ? I didn't find anything
 about json in the Fossil compilation docs.


That's probably because those doing the documenting live on Unix-like
platforms where './configure --help' works ;).

-- 
- stephan beal
http://wanderinghorse.net/home/stephan/
http://gplus.to/sgbeal
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] With jimtcl available can we have hooks that trigger tcl scripts stored in the db?

2012-02-16 Thread Steve Bennett
On 17/02/2012, at 2:15 AM, Nolan Darilek wrote:

 Cool, I'd like to at least have the discussion about that, though.
 
 What I'd like to see, if possible, is read-only access to the 
 repository--access to the SELECT statement, for instance, and a way to 
 iterate over the results and output them into the pages.
 
 To anyone afraid that I'll be calling for full-blown CMS features next, I'll 
 note that hooks and the ability to display arbitrary repository content are 
 the only features I've missed after nearly two years of Fossil use. I'm using 
 it quite happily for the http://spielproject.info pages, but I'd love to 
 display the last 5-10 events on the front page to liven it up a bit. Events 
 are how I announce releases. I could also see displaying timeline entries and 
 such to show the X most recent commits on certain pages, etc.
 
 Yeah, I know I can do this with Javascript, but that doesn't make the content 
 searchable.
 
 Thanks.

FWIW, you could turn a Jim Tcl interpreter into a safe interpreter by 
removing a handful
of commands from the interpreter, such as: readdir, open, exec, source, cd, file

To be most useful, read-only access to the fossil db (with some restrictions?) 
would also be required.

Of course, Jim Tcl were used for hook scripts, this interpreter would need to 
be non-safe to be useful.

Cheers,
Steve

 
 
 On 02/16/2012 08:00 AM, Richard Hipp wrote:
 
 
 
 On Thu, Feb 16, 2012 at 8:49 AM, Nolan Darilek no...@thewordnerd.info 
 wrote:
 On 02/16/2012 06:55 AM, Richard Hipp wrote:
 
 
 
 On Wed, Feb 15, 2012 at 11:15 PM, Nolan Darilek no...@thewordnerd.info 
 wrote:
 So is it currently possible to use TH1 to generate dynamic webpages? Could 
 I use it to, say, select the last 5 events and display them on the main 
 page? Or is that still out of reach?
 
 Just curious, since it seems like there are lots of scripting possibilities 
 coming down the pipeline.
 Thanks!
 
 I was once open to this kind of thing.  But since the security risks have 
 been pointed out to me, I'm now very reluctant to do anything like this.  
  
 
 
 I thought the point of TH1 was that it prevented this type of thing, that's 
 why it's used in reporting. If TH1 isn't a secure, minimal TCL that can 
 generate reports and, presumably, might be expanded a bit to pull and 
 display information on artifacts, then what is it?
 
 TH1 is secure by virtual of being minimalist.  It really doesn't do much 
 beyond simple variable substitution and if-then-else.  The point is, I want 
 to keep it that way so that it does not evolve into a security threat.  We 
 want to keep the attack surface as small as possible.
 
  
 
 ___
 fossil-users mailing list
 fossil-users@lists.fossil-scm.org
 http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
 
 
 
 
 -- 
 D. Richard Hipp
 d...@sqlite.org
 
 
 ___
 fossil-users mailing list
 fossil-users@lists.fossil-scm.org
 http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
 
 ___
 fossil-users mailing list
 fossil-users@lists.fossil-scm.org
 http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

--
µWeb: Embedded Web Framework - http://uweb.workware.net.au/
WorkWare Systems Pty Ltd
W: www.workware.net.au  P: +61 434 921 300
E: ste...@workware.net.au   F: +61 7 3391 6002





___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


[fossil-users] Building fossil on Solaris

2012-02-16 Thread Jan Danielsson
Hello,

   I've built fossil on Solaris previously using the old Makefile
(requiring only very minor changes), but Makefile.classic seems to have
degenerated a little, so I thought I'd try to use configure et al),
but I end up with this:

   $ mkdir build
   $ cd build
   $ ../configure
   Error: No auto.def found in [...]/fossil/build
   Try: 'autosetup --help' for options
   $ ls -l
   total 0

   configure --help led me to try:
   $ ../configure --init
   I don't see configure, so I will create it.
   I don't see auto.def, so I will create a default one.
   Note: I don't see Makefile.in. You will probably need to create one.
   $ ls
   auto.def   configure

   The system is (correctly) being identified as:
   Host System...sparc-sun-solaris2.9
   Build System...sparc-sun-solaris2.9


   Which are the usual suspects when Makefile.in doesn't get created?

-- 
Kind regards,
Jan Danielsson

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Building fossil on Solaris

2012-02-16 Thread Steve Bennett
On 17/02/2012, at 10:57 AM, Jan Danielsson wrote:

 Hello,
 
   I've built fossil on Solaris previously using the old Makefile
 (requiring only very minor changes), but Makefile.classic seems to have
 degenerated a little, so I thought I'd try to use configure et al),
 but I end up with this:
 
   $ mkdir build
   $ cd build
   $ ../configure
   Error: No auto.def found in [...]/fossil/build
   Try: 'autosetup --help' for options
   $ ls -l
   total 0
 
   configure --help led me to try:
   $ ../configure --init
   I don't see configure, so I will create it.
   I don't see auto.def, so I will create a default one.
   Note: I don't see Makefile.in. You will probably need to create one.
   $ ls
   auto.def   configure
 
   The system is (correctly) being identified as:
   Host System...sparc-sun-solaris2.9
   Build System...sparc-sun-solaris2.9
 
 
   Which are the usual suspects when Makefile.in doesn't get created?

Thanks for the report. I'll take a look at why out-of-tree build doesn't work 
on Solaris.
In the meantime, you can try an in-tree build. Just run ./configure from the
source directory.

Cheers,
Steve

--
µWeb: Embedded Web Framework - http://uweb.workware.net.au/
WorkWare Systems Pty Ltd
W: www.workware.net.au  P: +61 434 921 300
E: ste...@workware.net.au   F: +61 7 3391 6002





___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Building fossil on Solaris

2012-02-16 Thread Steve Bennett
On 17/02/2012, at 11:08 AM, Steve Bennett wrote:

 On 17/02/2012, at 10:57 AM, Jan Danielsson wrote:
 
 Hello,
 
  I've built fossil on Solaris previously using the old Makefile
 (requiring only very minor changes), but Makefile.classic seems to have
 degenerated a little, so I thought I'd try to use configure et al),
 but I end up with this:
 
  $ mkdir build
  $ cd build
  $ ../configure
  Error: No auto.def found in [...]/fossil/build
  Try: 'autosetup --help' for options
  $ ls -l
  total 0
 
  configure --help led me to try:
  $ ../configure --init
  I don't see configure, so I will create it.
  I don't see auto.def, so I will create a default one.
  Note: I don't see Makefile.in. You will probably need to create one.
  $ ls
  auto.def   configure
 
  The system is (correctly) being identified as:
  Host System...sparc-sun-solaris2.9
  Build System...sparc-sun-solaris2.9
 
 
  Which are the usual suspects when Makefile.in doesn't get created?
 
 Thanks for the report. I'll take a look at why out-of-tree build doesn't work 
 on Solaris.
 In the meantime, you can try an in-tree build. Just run ./configure from the
 source directory.

Looks like more problems with unexported shell variables.

Can you edit the file configure so it looks like this:

#!/bin/sh
dir=`dirname $0`/autosetup
WRAPPER=$0; export WRAPPER
exec `$dir/find-tclsh` $dir/autosetup $@

And let me know if that solves the problem?

Cheers,
Steve

--
µWeb: Embedded Web Framework - http://uweb.workware.net.au/
WorkWare Systems Pty Ltd
W: www.workware.net.au  P: +61 434 921 300
E: ste...@workware.net.au   F: +61 7 3391 6002





___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Building fossil on Solaris

2012-02-16 Thread Jan Danielsson
On 02/17/12 02:23, Steve Bennett wrote:
[.. FOO=bar ; export FOO ..]
 And let me know if that solves the problem?

   Ah, yes. Good ol' Solaris /bin/sh.

   That was it. I can't believe I missed that; I have been bitten by
that particular limitation of Solaris' /bin/sh a few times before.

   (Yes, I know Solaris technically does it right, and I respect that,
but it's getting a little old running into this problem every five-six
months or so).

   Thanks!

-- 
Kind regards,
Jan Danielsson

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Building fossil on Solaris

2012-02-16 Thread Steve Bennett
On 17/02/2012, at 11:53 AM, Jan Danielsson wrote:

 On 02/17/12 02:23, Steve Bennett wrote:
 [.. FOO=bar ; export FOO ..]
 And let me know if that solves the problem?
 
   Ah, yes. Good ol' Solaris /bin/sh.
 
   That was it. I can't believe I missed that; I have been bitten by
 that particular limitation of Solaris' /bin/sh a few times before.
 
   (Yes, I know Solaris technically does it right, and I respect that,
 but it's getting a little old running into this problem every five-six
 months or so).
 
   Thanks!

No problem. I've pushed the fix into autosetup and updated autosetup
on a branch, so perhaps Richard will merge this fix at some point.

The crazy thing is that Solaris has a Posix shell (as opposed to Bourne shell),
but it's not /bin/sh, so it's too hard to use it for this sort of bootstrapping.

Cheers,
Steve

--
µWeb: Embedded Web Framework - http://uweb.workware.net.au/
WorkWare Systems Pty Ltd
W: www.workware.net.au  P: +61 434 921 300
E: ste...@workware.net.au   F: +61 7 3391 6002





___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Building fossil on Solaris

2012-02-16 Thread Richard Hipp
On Thu, Feb 16, 2012 at 8:53 PM, Jan Danielsson
jan.m.daniels...@gmail.comwrote:

 On 02/17/12 02:23, Steve Bennett wrote:
 [.. FOO=bar ; export FOO ..]
  And let me know if that solves the problem?



We have this fix checked-in and running on a Solaris Sparc blade here:

 http://sparc.sqlite.org/fossil-src/fdiff?v1=ec171bb9e14v2=06277810ab75

The change was about a week ago.  So any of the latest versions of Fossil
should have it.  I also see that Steve has now checked in the latest
autosetup that contains a lot of other enhancements besides this one fix.


Ah, yes. Good ol' Solaris /bin/sh.

   That was it. I can't believe I missed that; I have been bitten by
 that particular limitation of Solaris' /bin/sh a few times before.

   (Yes, I know Solaris technically does it right, and I respect that,
 but it's getting a little old running into this problem every five-six
 months or so).

   Thanks!

 --
 Kind regards,
 Jan Danielsson

 ___
 fossil-users mailing list
 fossil-users@lists.fossil-scm.org
 http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users




-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Building fossil on Solaris

2012-02-16 Thread Steve Bennett
On 17/02/2012, at 1:51 PM, Richard Hipp wrote:

 
 
 On Thu, Feb 16, 2012 at 8:53 PM, Jan Danielsson jan.m.daniels...@gmail.com 
 wrote:
 On 02/17/12 02:23, Steve Bennett wrote:
 [.. FOO=bar ; export FOO ..]
  And let me know if that solves the problem?
 
 
 We have this fix checked-in and running on a Solaris Sparc blade here:
 
  http://sparc.sqlite.org/fossil-src/fdiff?v1=ec171bb9e14v2=06277810ab75
 
 The change was about a week ago.  So any of the latest versions of Fossil 
 should have it.  I also see that Steve has now checked in the latest 
 autosetup that contains a lot of other enhancements besides this one fix.

Similar problem, but in a slightly different place.
Both fixes are needed.

Cheers,
Steve

--
µWeb: Embedded Web Framework - http://uweb.workware.net.au/
WorkWare Systems Pty Ltd
W: www.workware.net.au  P: +61 434 921 300
E: ste...@workware.net.au   F: +61 7 3391 6002





___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users