[fossil-users] Case (in-)sensitive web-pages

[Jan Nijtmans]

Hi all,

I'm wondering why web-pages like /dir and /finfo (and
their JSON-equivalents) use the case-sensitive setting:
case- sensitivity is a property of the file system, but the
file-system is not accessed by those web-pages at all.

The reason I come to this, is that in
[3c781f4f0b]http://www.fossil-scm.org/index.html/info/3c781f4f0b
I
simplified the use of filename_collation() such that
it automatically creates a case-insensitive index
when it is used the first time.
This introduced a bug, which was fixed by joel in
 [d38f204d3b] http://www.fossil-scm.org/index.html/info/d38f204d3b
(Thanks!). The problem was that the
case-insensitivity index (vfile_nocase) sometimes
could not be created because the local database
was not opened yet. The commands affected were
/dir, /finfo and their JSON-equivalent, all web-pages
which are not supposed to access the file system.
One solution is simply to open the localdb,
(that's what joel did) but I really wonder whether this
is the 'right' solution, even though it works fine.

If case-sensitivity should be supported, at least I
would expect some kind of case-sensitivity url
parameter, equivalent with the --case-sensitive
command line option of fossil commands. But
I really don't think why anyone would want that.

My proposal would be to remove the use of
the function filename_collation() in those web-pages,
such that the case-sensitive setting no longer has
effect on those web-pages. This is implemented in
[c967b6619f] http://www.fossil-scm.org/index.html/info/c967b6619f. I
cannot find any problems with that.
Anyone? Did I miss anything?

Thanks!
   Jan Nijtmans
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] Case (in-)sensitive web-pages

[Stephan Beal]

On Wed, Apr 24, 2013 at 11:47 AM, Jan Nijtmans jan.nijtm...@gmail.comwrote:

 ...was not opened yet. The commands affected were
 /dir, /finfo and their JSON-equivalent, all web-pages


Regarding the json variants: i don't recall explicitly adding
case-sensitivity support to any of the JSON bits, but (A) i have the memory
of a goldfish and (B) someone else might have patched it later. i
unfortunately can't offer any sensible suggestions on the topic of
case-sensitivity (i live in Unix, so case-sensitive is second nature to me).

-- 
- stephan beal
http://wanderinghorse.net/home/stephan/
http://gplus.to/sgbeal
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] Case (in-)sensitive web-pages

[Jan Nijtmans]

2013/4/24 Stephan Beal sgb...@googlemail.com



 Regarding the json variants: i don't recall explicitly adding
 case-sensitivity support to any of the JSON bits, but (A) i have the memory
 of a goldfish and (B) someone else might have patched it later. i
 unfortunately can't offer any sensible suggestions on the topic of
 case-sensitivity (i live in Unix, so case-sensitive is second nature to me).


The comments say that the JSON variants were derived from the original
pages, so the
original /dir and /finfo already had case-sensitive support in it when you
adopted them.

(I didn't know that a goldfish had THAT huge amount of memory.) ;-)

Regards,
 Jan Nijtmans
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users