Re: [fossil-users] New regexp OpenBSD build error
2013/1/2 Stephan Beal sgb...@googlemail.com: On Wed, Jan 2, 2013 at 8:56 AM, Baptiste Daroussin baptiste.darous...@gmail.com wrote: 2013/1/2 James Turner ja...@calminferno.net: ... in.mx = nIn=0 ? nIn : strlen(zIn); ... pRe-sIn.mx = strlen(pRe-sIn.z); those are fixed now, too. Thanks again for the report. http://fossil-scm.org/index.html/info/46af6b8260 -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users Thanks it now builds and works without any warnings on FreeBSD Bapt ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] New regexp OpenBSD build error
On Sat, Jan 05, 2013 at 08:03:49PM +0100, Baptiste Daroussin wrote: 2013/1/2 Stephan Beal sgb...@googlemail.com: On Wed, Jan 2, 2013 at 8:56 AM, Baptiste Daroussin baptiste.darous...@gmail.com wrote: 2013/1/2 James Turner ja...@calminferno.net: ... in.mx = nIn=0 ? nIn : strlen(zIn); ... pRe-sIn.mx = strlen(pRe-sIn.z); those are fixed now, too. Thanks again for the report. http://fossil-scm.org/index.html/info/46af6b8260 -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users Thanks it now builds and works without any warnings on FreeBSD Bapt OpenBSD as well. -- James Turner | 0x560B0C49 ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] New regexp OpenBSD build error
On Wed, Jan 2, 2013 at 8:56 AM, Baptiste Daroussin
baptiste.darous...@gmail.com wrote:
...
For the test, I run configure --json --markdown
If you think it is worth fixing those, I can provide a patch, next
week (I'll be off the rest of the week)
Hiho,
Thank you, i'll take care of the JSON warnings this week (possibly today -
i'm alone at the office).
In file included from ./src/json_timeline.c:21:
bld/json_timeline.h:329:12: warning: duplicate 'const' declaration
specifier [-Wduplicate-decl-specifier]
const char const *json_timeline_query(void);
^
./src/json_timeline.c:95:12: warning: duplicate 'const' declaration
specifier [-Wduplicate-decl-specifier]
const char const * json_timeline_query(void){
That was possibly supposed to be (char const * const).
./src/cson_amalgamation.c:4385:20: warning: comparison of unsigned
expression 0 is always false [-Wtautological-compare]
if( ! arg || (n0) ) return cson_rc.ArgError;
That was fixed at some point in the standalone cson library build - i'll
get that fix integrated.
Thanks for the notes.
--
- stephan beal
http://wanderinghorse.net/home/stephan/
http://gplus.to/sgbeal
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] New regexp OpenBSD build error
On Wed, Jan 2, 2013 at 11:34 AM, Stephan Beal sgb...@googlemail.com wrote: Thank you, i'll take care of the JSON warnings this week (possibly today - i'm alone at the office). FYI: those and the re_execute() fixes have been committed. Thanks for the heads up. -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] New regexp OpenBSD build error
On Wed, Jan 2, 2013 at 8:56 AM, Baptiste Daroussin baptiste.darous...@gmail.com wrote: 2013/1/2 James Turner ja...@calminferno.net: ... in.mx = nIn=0 ? nIn : strlen(zIn); ... pRe-sIn.mx = strlen(pRe-sIn.z); those are fixed now, too. Thanks again for the report. http://fossil-scm.org/index.html/info/46af6b8260 -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
[fossil-users] New regexp OpenBSD build error
On OpenBSD re_exec is already defined in unistd.h causing the latest trunk to fail to build. In file included from ./src/diff.c:22: bld/diff.h:287: error: conflicting types for 're_exec' /usr/include/unistd.h:478: error: previous declaration of 're_exec' was here *** Error 1 in /home/james/code/fossil (./src/main.mk:557 'bld/diff.o') It's obsolete but sadly still present. http://www.openbsd.org/cgi-bin/man.cgi?query=re_execapropos=0sektion=0manpath=OpenBSD+Currentarch=i386format=html -- James Turner | 0x560B0C49 ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] New regexp OpenBSD build error
2013/1/2 James Turner ja...@calminferno.net:
On OpenBSD re_exec is already defined in unistd.h causing the latest
trunk to fail to build.
In file included from ./src/diff.c:22:
bld/diff.h:287: error: conflicting types for 're_exec'
/usr/include/unistd.h:478: error: previous declaration of 're_exec' was
here
*** Error 1 in /home/james/code/fossil (./src/main.mk:557 'bld/diff.o')
It's obsolete but sadly still present.
http://www.openbsd.org/cgi-bin/man.cgi?query=re_execapropos=0sektion=0manpath=OpenBSD+Currentarch=i386format=html
Same on FreeBSD,
Here is a patch to rename the re_exec to re_execute and make the code
compilable on FreeBSD.
http://people.freebsd.org/~bapt/re_exec.diff
While here I don't know what are the rules about the warnings, but I'm
building fossil with clang and I a couple of warnings.
For the test, I run configure --json --markdown
If you think it is worth fixing those, I can provide a patch, next
week (I'll be off the rest of the week)
./src/diff.c:428:25: warning: passing 'const char *' to parameter of
type 'const unsigned char *' converts between pointers to integer
types with different sign [-Wpointer-sign]
if( re_execute(pRe, aDLine-z, LENGTH(aDLine)) ){
^
bld/diff.h:287:53: note: passing argument to parameter 'zIn' here
int re_execute(ReCompiled *pRe,const unsigned char *zIn,int nIn);
^
In file included from ./src/json_timeline.c:21:
bld/json_timeline.h:329:12: warning: duplicate 'const' declaration
specifier [-Wduplicate-decl-specifier]
const char const *json_timeline_query(void);
^
./src/json_timeline.c:95:12: warning: duplicate 'const' declaration
specifier [-Wduplicate-decl-specifier]
const char const * json_timeline_query(void){
^
2 warnings generated.
./src/regexp.c:196:33: warning: passing 'const unsigned char *' to
parameter of type 'const char *' converts between pointers to integer
types with different sign [-Wpointer-sign]
in.mx = nIn=0 ? nIn : strlen(zIn);
^~~
/usr/include/string.h:92:28: note: passing argument to parameter here
size_t strlen(const char *) __pure;
^
./src/regexp.c:631:24: warning: passing 'const unsigned char *' to
parameter of type 'const char *' converts between pointers to integer
types with different sign [-Wpointer-sign]
pRe-sIn.mx = strlen(pRe-sIn.z);
^~
/usr/include/string.h:92:28: note: passing argument to parameter here
size_t strlen(const char *) __pure;
^
2 warnings generated.
./src/cson_amalgamation.c:4385:20: warning: comparison of unsigned
expression 0 is always false [-Wtautological-compare]
if( ! arg || (n0) ) return cson_rc.ArgError;
~^~
1 warning generated.
regards,
Bapt
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
