Re: [fossil-users] Ticket lists don't sort on header-click [PATCH]

2016-02-12 Thread Warren Young 
On Feb 10, 2016, at 9:39 PM, jungle Boogie  wrote:
> 
> Can someone with commit access please review the patch Mr. Young
> provided in this post:

A simplified version of it is on the trunk now:

  http://fossil-scm.org/index.html/info/0e555dee63dab159

drh missed one of the grammar fixes when rewriting the patch, though. :)

> Is it practical to make a test case for this for code coverage?

AFAIK, Fossil’s web UI currently has no regression test suite.  All the tests 
are down at the command line and and source code level.

Are you in a position to recommend a web UI regression test system which is 
consistent with Fossil’s FOSS philosophy?  Ideally, there shouldn’t be any more 
friction to getting “make test-ui” to run than an install command for the 
platform’s package manager, and this package should be available on all the 
platforms Fossil tests need to run on.

Selenium, perhaps?  I see packages in Ubuntu, Homebrew, and FreeBSD, but 
mysteriously not in CentOS, including EPEL.

This guy appears to be working on EPEL RPMs:

  https://github.com/djhenry/selenium-webdriver-rpm

…but the last commit is 10 months ago.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] Ticket lists don't sort on header-click [PATCH]

2016-02-10 Thread jungle Boogie 
Hello All,


Can someone with commit access please review the patch Mr. Young
provided in this post:
http://www.mail-archive.com/fossil-users%40lists.fossil-scm.org/msg22539.html

Is it practical to make a test case for this for code coverage?

Thanks!

On 8 February 2016 at 00:59, Ron Aaron  wrote:
> The patch works, please incorporate into the fossil src
>
>
> On 02/02/2016 04:40, Warren Young wrote:
>
> On investigating, the problem is that the call to
> output_table_sorting_javascript() in src/report.c is passed an empty string
> for the zColumnTypes parameter, which is *supposed* to
>
>
> --
> Best regards,
> Ron Aaron
> +1 425.296.0766
> +972 52.652.5543

-- 
---
inum: 883510009027723
sip: jungleboo...@sip2sip.info
xmpp: jungle-boo...@jit.si
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] Ticket lists don't sort on header-click [PATCH]

2016-02-08 Thread Ron Aaron 

  
  
The patch works, please incorporate into the fossil src


On 02/02/2016 04:40, Warren Young
  wrote:


  On investigating, the problem is that the call to output_table_sorting_javascript() in src/report.c is passed an empty string for the zColumnTypes parameter, which is *supposed* to


-- 
  

  Best regards,
  Ron Aaron
  +1 425.296.0766
  +972 52.652.5543

  

  

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] Ticket lists don't sort on header-click [PATCH]

2016-02-01 Thread Warren Young 
On Jan 31, 2016, at 7:08 AM, Ron Aaron  wrote:
> 
> It used to be the case that clicking on the header of a ticket report would 
> sort according to the column clicked.  That seems to not work now.
> 
> I verified it also doesn't work on the fossil site, so it's not just my 
> misconfiguration…

I bisected it and discovered that the problem was introduced on December 5 in 
checkin f98264231599088.

On investigating, the problem is that the call to 
output_table_sorting_javascript() in src/report.c is passed an empty string for 
the zColumnTypes parameter, which is *supposed* to mean “all columns sort as 
text” according to the function comment, but which actually means “no columns 
are sortable” since this change which optimizes out unused sorting types in the 
generated Javascript.

The attached patch restores the behavior contract in the function comment.  In 
effect, a 6-column report gets created as if you’d passed “tt” for the 
zColumnTypes parameter.

If all-text sorting isn’t the right thing, the call to 
output_table_sorting_javascript() needs to grovel through the SQLite column 
type data to generate the correct values for this parameter.



fossil-report-sorting.patch
Description: Binary data
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

[fossil-users] Ticket lists don't sort on header-click

2016-01-31 Thread Ron Aaron 

  
  
It used to be the case that clicking on the header of a ticket
report would sort according to the column clicked.  That seems to
not work now.

I verified it also doesn't work on the fossil site, so it's not just
my misconfiguration...

-- 
  

  Best regards,
  Ron Aaron
  +1 425.296.0766
  +972 52.652.5543

  

  

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users