[fossil-users] clang-analyzer results (unchecked setgid/setuid returns)

2012-06-29 Thread John Nowak
Hopefully some Fossil developer finds this useful: http://heap.johnnowak.com/2012/06/29/scan-build-2012-06-29-1/ Mostly dead stores, but it seems that the return values of 'setgid' and 'setuid' are not checked at src/main.c:1137. All of the problems seem easily correctable. - jn

Re: [fossil-users] clang-analyzer results (unchecked setgid/setuid returns)

2012-06-29 Thread Stephan Beal
On Fri, Jun 29, 2012 at 10:49 PM, John Nowak j...@johnnowak.com wrote: Hopefully some Fossil developer finds this useful: http://heap.johnnowak.com/**2012/06/29/scan-build-2012-06-**29-1/http://heap.johnnowak.com/2012/06/29/scan-build-2012-06-29-1/ Mostly dead stores, but it seems that the

Re: [fossil-users] clang-analyzer results (unchecked setgid/setuid returns)

2012-06-29 Thread Stephan Beal
On Fri, Jun 29, 2012 at 11:12 PM, Stephan Beal sgb...@googlemail.comwrote: Thanks. i've patched this locally, but before i commit it: can someone confirm that errno.h is available on Windows? Sorry, dumb question: that code is in a !-def win32 block. @Richard: umm

Re: [fossil-users] clang-analyzer results (unchecked setgid/setuid returns)

2012-06-29 Thread Andreas Kupries
On 6/29/2012 1:49 PM, John Nowak wrote: Hopefully some Fossil developer finds this useful: http://heap.johnnowak.com/2012/06/29/scan-build-2012-06-29-1/ How complicated is the generation of such a report ? (Are scripts for this available ?) -- Andreas Kupries Senior Tcl Developer Code to

Re: [fossil-users] clang-analyzer results (unchecked setgid/setuid returns)

2012-06-29 Thread Richard Hipp
On Fri, Jun 29, 2012 at 5:29 PM, Andreas Kupries andre...@activestate.comwrote: On 6/29/2012 1:49 PM, John Nowak wrote: Hopefully some Fossil developer finds this useful:

Re: [fossil-users] clang-analyzer results (unchecked setgid/setuid returns)

2012-06-29 Thread Stephan Beal
On Fri, Jun 29, 2012 at 11:19 PM, Stephan Beal sgb...@googlemail.comwrote: [stephan@host:~/cvs/fossil/fossil]$ f com -m 'Added check of rc for setgid/setuid() calls.' src/main.c Autosync: http://step...@fossil-scm.org Here you go, John: http://www.fossil-scm.org/index.html/info/4d107b597a

Re: [fossil-users] clang-analyzer results (unchecked setgid/setuid returns)

2012-06-29 Thread Stephan Beal
On Fri, Jun 29, 2012 at 11:32 PM, Stephan Beal sgb...@googlemail.comwrote: Here you go, John: http://www.fossil-scm.org/index.html/info/4d107b597a OH, the irony!!! Don't use this yet - today's manifest change broke the trunk and i had to back-rev a day to be able to commit that. Richard is

Re: [fossil-users] clang-analyzer results (unchecked setgid/setuid returns)

2012-06-29 Thread John Nowak
On 06/29/2012 05:29 PM, Andreas Kupries wrote: On 6/29/2012 1:49 PM, John Nowak wrote: Hopefully some Fossil developer finds this useful: http://heap.johnnowak.com/2012/06/29/scan-build-2012-06-29-1/ How complicated is the generation of such a report ? (Are scripts for this available ?)

Re: [fossil-users] clang-analyzer results (unchecked setgid/setuid returns)

2012-06-29 Thread Andreas Kupries
On 6/29/2012 3:01 PM, John Nowak wrote: I did only the following: scan-build ./configure scan-build make The reports will be dumped in /tmp by default. You do need to remember to run it for 'configure' otherwise you'll end up with no results for 'make'. You'll also want to do a 'make