Re: [fossil-users] configure reset skin resets too much

2015-02-03 Thread David Given
On 03/02/15 05:50, Joe Mistachkin wrote: [...] Agreed. I'm also of the opinion that this is a good change and I have no objections to it. Awesome. I merged it as [6fedb84abb] and closed the branch. Let me know if there are any problems. ...BTW, while testing I noticed the new file viewer with

Re: [fossil-users] configure reset skin resets too much

2015-02-02 Thread Stephan Beal
Fwiw: ambivalent (sent from a mobile device - please excuse brevity, typos, and top-posting) - stephan beal http://wanderinghorse.net On Feb 3, 2015 12:16 AM, Richard Hipp d...@sqlite.org wrote: On 2/2/15, David Given d...@cowlark.com wrote: On 28/01/15 23:33, David Given wrote: It

Re: [fossil-users] configure reset skin resets too much

2015-02-02 Thread David Given
On 28/01/15 23:33, David Given wrote: It seems that doing 'fossil config reset skin' *also* resets the index path to the default. Does anyone have an opinion on this? I'm not going to do a merge without a sign-off... -- ┌─── dg@cowlark.com ─ http://www.cowlark.com ─ │ There does not

Re: [fossil-users] configure reset skin resets too much

2015-02-02 Thread Richard Hipp
On 2/2/15, David Given d...@cowlark.com wrote: On 28/01/15 23:33, David Given wrote: It seems that doing 'fossil config reset skin' *also* resets the index path to the default. Does anyone have an opinion on this? I'm not going to do a merge without a sign-off... I don't have a strong

Re: [fossil-users] configure reset skin resets too much

2015-02-02 Thread Joe Mistachkin
Andy Bradford wrote: I don't think it makes much sense for the index-page to be reset with ``fossil config reset skin'' either. Is the index-page considered part of the skin? Likewise, it also seems odd that ``fossil config reset project'' doesn't reset the index-page. Agreed.

Re: [fossil-users] configure reset skin resets too much

2015-02-02 Thread Andy Bradford
Thus said David Given on Mon, 02 Feb 2015 23:51:33 +0100: It seems that doing 'fossil config reset skin' *also* resets the index path to the default. Does anyone have an opinion on this? I'm not going to do a merge without a sign-off... I don't think it makes much sense for

[fossil-users] configure reset skin resets too much

2015-01-28 Thread David Given
It seems that doing 'fossil config reset skin' *also* resets the index path to the default. This is because index-page is set as CONFIGSET_SKIN. I think that it should be CONFIGSET_PROJ, as SKIN is for look-and-feel settings only and the home page setting is a semantic change. I did the world's