Re: [fossil-users] fossil compile errors
On 12 August 2015 at 07:38, jungle Boogie wrote: > Hi Michai, > On 11 August 2015 at 22:27, Michai Ramakers wrote: >> On 12 August 2015 at 07:18, jungle Boogie wrote: >>> On 11 August 2015 at 22:16, Michai Ramakers wrote: which compiler/version? (Clang?) >>> >>> Yes, correct. >>> FreeBSD clang version 3.4.1 >> >> fwiw, builds clean with 3.6.2 and 3.5.2 here (I don't have your version >> here). >> > > As Andy pointed out, its already been corrected: > http://www.fossil-scm.org/index.html/info/c64989d5a0b79126 ...and of course I tested with that exact version. D'oh! Hours before 10:00 are best spent in bed, I think. Michai ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] fossil compile errors
Hi Michai, On 11 August 2015 at 22:27, Michai Ramakers wrote: > On 12 August 2015 at 07:18, jungle Boogie wrote: >> On 11 August 2015 at 22:16, Michai Ramakers wrote: >>> which compiler/version? (Clang?) >> >> Yes, correct. >> FreeBSD clang version 3.4.1 > > fwiw, builds clean with 3.6.2 and 3.5.2 here (I don't have your version here). > As Andy pointed out, its already been corrected: http://www.fossil-scm.org/index.html/info/c64989d5a0b79126 Thanks for testing and verifying it no longer warns! > Michai -- --- inum: 883510009027723 sip: jungleboo...@sip2sip.info xmpp: jungle-boo...@jit.si ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] fossil compile errors
Thus said jungle Boogie on Tue, 11 Aug 2015 21:32:29 -0700:
> ./src/main.c:902:18: warning: using the result of an assignment as a
> condition without parentheses [-Wparentheses]
> while( zOption = find_option(zLong, zShort, 1) ){
> ^~~
Thanks for the report, I'll have to remember to compile with -Wall next
time just to weed out things like this. I see, however, that it has
already been taken care of.
Thanks,
andy
--
TAI64 timestamp: 400055cadb7d
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] fossil compile errors
On 12 August 2015 at 07:18, jungle Boogie wrote: > On 11 August 2015 at 22:16, Michai Ramakers wrote: >> which compiler/version? (Clang?) > > Yes, correct. > FreeBSD clang version 3.4.1 fwiw, builds clean with 3.6.2 and 3.5.2 here (I don't have your version here). Michai ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] fossil compile errors
Gcc likes to warn about such constructs, too. If Michai doesn't beat me to it, i will patch this when i get to work (about an hour from now). - stephan Sent from a mobile device, possibly from bed. Please excuse brevity and typos. On Aug 12, 2015 7:19 AM, "jungle Boogie" wrote: > On 11 August 2015 at 22:16, Michai Ramakers wrote: > > which compiler/version? (Clang?) > > Yes, correct. > FreeBSD clang version 3.4.1 > > -- > --- > inum: 883510009027723 > sip: jungleboo...@sip2sip.info > xmpp: jungle-boo...@jit.si > ___ > fossil-users mailing list > fossil-users@lists.fossil-scm.org > http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users > ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] fossil compile errors
On 11 August 2015 at 22:16, Michai Ramakers wrote: > which compiler/version? (Clang?) Yes, correct. FreeBSD clang version 3.4.1 -- --- inum: 883510009027723 sip: jungleboo...@sip2sip.info xmpp: jungle-boo...@jit.si ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] fossil compile errors
On 12 August 2015 at 06:32, jungle Boogie wrote:
>
> I noticed a compile warning generated while building Fossil from latest:
>
> ./src/main.c:902:18: warning: using the result of an assignment as a
> condition without parentheses [-Wparentheses]
> while( zOption = find_option(zLong, zShort, 1) ){
> ^~~
> ./src/main.c:902:18: note: place parentheses around the assignment to
> silence this warning
> while( zOption = find_option(zLong, zShort, 1) ){
> ^
> ( )
> ./src/main.c:902:18: note: use '==' to turn this assignment into an
> equality comparison
> while( zOption = find_option(zLong, zShort, 1) ){
> ^
> ==
> 1 warning generated.
which compiler/version? (Clang?)
Michai
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
[fossil-users] fossil compile errors
Hello All,
Sorry for the spam to the list tonight...
I noticed a compile warning generated while building Fossil from latest:
./src/main.c:902:18: warning: using the result of an assignment as a
condition without parentheses [-Wparentheses]
while( zOption = find_option(zLong, zShort, 1) ){
^~~
./src/main.c:902:18: note: place parentheses around the assignment to
silence this warning
while( zOption = find_option(zLong, zShort, 1) ){
^
( )
./src/main.c:902:18: note: use '==' to turn this assignment into an
equality comparison
while( zOption = find_option(zLong, zShort, 1) ){
^
==
1 warning generated.
--
---
inum: 883510009027723
sip: jungleboo...@sip2sip.info
xmpp: jungle-boo...@jit.si
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
