Re: [fossil-users] mingw doesn't build anymore on win8-64bit

2013-10-11 Thread Jan Nijtmans
2013/10/11 Martin Gagnon eme...@gmail.com: Finally, I found that your change in config.h fix the problem on some source files, but some source files include some system header files before the config.h (some even doesn't include config.h). I tried to fix this by making sure that every source

Re: [fossil-users] mingw doesn't build anymore on win8-64bit

2013-10-11 Thread Jan Nijtmans
2013/10/11 Jan Nijtmans jan.nijtm...@gmail.com: 2013/10/11 Martin Gagnon eme...@gmail.com: I tried to fix this by making sure that every source include config.h before any other includes, but I got stuck when I go the error from sqlite3.c Thanks! Fixed now. I was able to reproduce your

Re: [fossil-users] mingw doesn't build anymore on win8-64bit

2013-10-11 Thread Martin Gagnon
On Fri, Oct 11, 2013 at 10:50:29AM +0200, Jan Nijtmans wrote: 2013/10/11 Jan Nijtmans jan.nijtm...@gmail.com: 2013/10/11 Martin Gagnon eme...@gmail.com: I tried to fix this by making sure that every source include config.h before any other includes, but I got stuck when I go the error from

Re: [fossil-users] mingw doesn't build anymore on win8-64bit

2013-10-11 Thread Jan Nijtmans
2013/10/11 Martin Gagnon eme...@gmail.com: Would it work to do the opposite way by not defining _USE_32BIT_TIME_T from the Makefile, and defining it under a #ifdef _WIN64 in the config.h ? What do you think ? Yes, that looks better. And it indeed makes things simpler. Why didn't I think of

Re: [fossil-users] mingw doesn't build anymore on win8-64bit

2013-10-11 Thread Jan Nijtmans
2013/10/11 Jan Nijtmans jan.nijtm...@gmail.com: Yes, that looks better. And it indeed makes things simpler. Why didn't I think of that ;-) ... Unfortunately, it only fixes one of the two problems, and it breaks the normal MinGW build. See below for the log. I finally figured it out. Fix

Re: [fossil-users] mingw doesn't build anymore on win8-64bit

2013-10-11 Thread Richard Hipp
On Fri, Oct 11, 2013 at 8:46 AM, Jan Nijtmans jan.nijtm...@gmail.comwrote: 2013/10/11 Jan Nijtmans jan.nijtm...@gmail.com: Yes, that looks better. And it indeed makes things simpler. Why didn't I think of that ;-) ... Unfortunately, it only fixes one of the two problems, and it

Re: [fossil-users] mingw doesn't build anymore on win8-64bit

2013-10-11 Thread Jan Nijtmans
2013/10/11 Richard Hipp d...@sqlite.org: But the content of sqlite3.h is protected from multiple inclusion using #ifndef _SQLITE3_H_ #define _SQLITE3_H_ ... #endif This protection occurs both in sqlite3.h and sqlite3.c. So why does having #include sqlite3.h in config.h

Re: [fossil-users] mingw doesn't build anymore on win8-64bit

2013-10-11 Thread Martin Gagnon
On Fri, Oct 11, 2013 at 02:46:28PM +0200, Jan Nijtmans wrote: 2013/10/11 Jan Nijtmans jan.nijtm...@gmail.com: Yes, that looks better. And it indeed makes things simpler. Why didn't I think of that ;-) ... Unfortunately, it only fixes one of the two problems, and it breaks the normal

Re: [fossil-users] mingw doesn't build anymore on win8-64bit

2013-10-11 Thread Jan Nijtmans
2013/10/11 Jan Nijtmans jan.nijtm...@gmail.com: It should be the same whether sqlite3.h is included or not I tested the MinGW compile with the latest SQLite 3.8.1 beta. It works fine. Actually, including sqlite3.h before or after config.h doesn't make any difference: The only system include in

[fossil-users] mingw doesn't build anymore on win8-64bit

2013-10-10 Thread Martin Gagnon
Hi list.. I recently try to compile latest trunk and the build failed.. Since I was already using a version I compile myself from 1 or 2 month ago, I decide to do a bisect to find which commit break it. So here my bisect result: $ fossil bisect chart

Re: [fossil-users] mingw doesn't build anymore on win8-64bit

2013-10-10 Thread Jan Nijtmans
2013/10/10 Martin Gagnon eme...@gmail.com: It happens that the only difference between 7 and 8 is the Makefile for mingw which now define: -D_USE_32BIT_TIME_T This define should only be used for a 32-bit build, never for 64-bit, so this is indeed a bug. I'll have a look how to fix this.

Re: [fossil-users] mingw doesn't build anymore on win8-64bit

2013-10-10 Thread Jan Nijtmans
2013/10/10 Jan Nijtmans jan.nijtm...@gmail.com: 2013/10/10 Martin Gagnon eme...@gmail.com: It happens that the only difference between 7 and 8 is the Makefile for mingw which now define: -D_USE_32BIT_TIME_T This define should only be used for a 32-bit build, never for 64-bit, so this is

Re: [fossil-users] mingw doesn't build anymore on win8-64bit

2013-10-10 Thread Martin Gagnon
On Thu, Oct 10, 2013 at 04:39:03PM +0200, Jan Nijtmans wrote: 2013/10/10 Jan Nijtmans jan.nijtm...@gmail.com: 2013/10/10 Martin Gagnon eme...@gmail.com: It happens that the only difference between 7 and 8 is the Makefile for mingw which now define: -D_USE_32BIT_TIME_T This define

Re: [fossil-users] mingw doesn't build anymore on win8-64bit

2013-10-10 Thread Martin Gagnon
On Thu, Oct 10, 2013 at 04:39:03PM +0200, Jan Nijtmans wrote: 2013/10/10 Jan Nijtmans jan.nijtm...@gmail.com: 2013/10/10 Martin Gagnon eme...@gmail.com: It happens that the only difference between 7 and 8 is the Makefile for mingw which now define: -D_USE_32BIT_TIME_T This define